)]}'
{"oslo_db/tests/sqlalchemy/test_options.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"9ab043d79fbb3655580538bb0a8b07af7e456596","unresolved":true,"context_lines":[{"line_number":76,"context_line":"                                       ]])[0]"},{"line_number":77,"context_line":"        self.conf([\u0027--config-file\u0027, path])"},{"line_number":78,"context_line":"        self.assertEqual(\u0027fake_connection\u0027, self.conf.database.connection)"},{"line_number":79,"context_line":"        self.assertEqual(100, self.conf.database.connection_recycle_time)"},{"line_number":80,"context_line":"        self.assertEqual(100, self.conf.database.idle_timeout)"},{"line_number":81,"context_line":"        self.assertEqual(22, self.conf.database.max_retries)"},{"line_number":82,"context_line":"        self.assertEqual(17, self.conf.database.retry_interval)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baef192a_c9681888","side":"PARENT","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":73},"updated":"2021-05-05 13:39:38.000000000","message":"Don\u0027t we need to keep this one?\n\nOnly idle_timeout has been removed and connection_recycle_time is the new one to use, isn\u0027t?","commit_id":"78d12d76969730d25f81b069b1b40730b91bd62f"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f4ec489cf24098e7808095950a85a5dc7a595d70","unresolved":true,"context_lines":[{"line_number":76,"context_line":"                                       ]])[0]"},{"line_number":77,"context_line":"        self.conf([\u0027--config-file\u0027, path])"},{"line_number":78,"context_line":"        self.assertEqual(\u0027fake_connection\u0027, self.conf.database.connection)"},{"line_number":79,"context_line":"        self.assertEqual(100, self.conf.database.connection_recycle_time)"},{"line_number":80,"context_line":"        self.assertEqual(100, self.conf.database.idle_timeout)"},{"line_number":81,"context_line":"        self.assertEqual(22, self.conf.database.max_retries)"},{"line_number":82,"context_line":"        self.assertEqual(17, self.conf.database.retry_interval)"}],"source_content_type":"text/x-python","patch_set":5,"id":"587185fd_beb216d0","side":"PARENT","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":73},"in_reply_to":"425b3ae7_f4d851b1","updated":"2021-05-12 17:07:08.000000000","message":"Ah yes I see, this test only check if the deprecated param is well bound with the new one and so if the value is well forwarded.","commit_id":"78d12d76969730d25f81b069b1b40730b91bd62f"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"acfde3f4d173ad842335e5e30e156af3ba252bf3","unresolved":true,"context_lines":[{"line_number":76,"context_line":"                                       ]])[0]"},{"line_number":77,"context_line":"        self.conf([\u0027--config-file\u0027, path])"},{"line_number":78,"context_line":"        self.assertEqual(\u0027fake_connection\u0027, self.conf.database.connection)"},{"line_number":79,"context_line":"        self.assertEqual(100, self.conf.database.connection_recycle_time)"},{"line_number":80,"context_line":"        self.assertEqual(100, self.conf.database.idle_timeout)"},{"line_number":81,"context_line":"        self.assertEqual(22, self.conf.database.max_retries)"},{"line_number":82,"context_line":"        self.assertEqual(17, self.conf.database.retry_interval)"}],"source_content_type":"text/x-python","patch_set":5,"id":"425b3ae7_f4d851b1","side":"PARENT","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":73},"in_reply_to":"baef192a_c9681888","updated":"2021-05-12 17:04:02.000000000","message":"No we don\u0027t need this anymore.","commit_id":"78d12d76969730d25f81b069b1b40730b91bd62f"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"9ab043d79fbb3655580538bb0a8b07af7e456596","unresolved":true,"context_lines":[{"line_number":90,"context_line":"                                       ]])[0]"},{"line_number":91,"context_line":"        self.conf([\u0027--config-file\u0027, path])"},{"line_number":92,"context_line":"        self.assertEqual(\u0027test_sql_connection\u0027, self.conf.database.connection)"},{"line_number":93,"context_line":"        self.assertEqual(99, self.conf.database.connection_recycle_time)"},{"line_number":94,"context_line":"        self.assertEqual(99, self.conf.database.idle_timeout)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_deprecated_dbapi_parameters(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"8fabc1c5_1fdddd75","side":"PARENT","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":72},"updated":"2021-05-05 13:39:38.000000000","message":"Same remark here","commit_id":"78d12d76969730d25f81b069b1b40730b91bd62f"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"acfde3f4d173ad842335e5e30e156af3ba252bf3","unresolved":true,"context_lines":[{"line_number":90,"context_line":"                                       ]])[0]"},{"line_number":91,"context_line":"        self.conf([\u0027--config-file\u0027, path])"},{"line_number":92,"context_line":"        self.assertEqual(\u0027test_sql_connection\u0027, self.conf.database.connection)"},{"line_number":93,"context_line":"        self.assertEqual(99, self.conf.database.connection_recycle_time)"},{"line_number":94,"context_line":"        self.assertEqual(99, self.conf.database.idle_timeout)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_deprecated_dbapi_parameters(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"f8fc3db3_cbc59938","side":"PARENT","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":72},"in_reply_to":"8fabc1c5_1fdddd75","updated":"2021-05-12 17:04:02.000000000","message":"Same here.","commit_id":"78d12d76969730d25f81b069b1b40730b91bd62f"}],"releasenotes/notes/removed-deprecated-idle-timeout-051a6a9a792bd8de.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d4953aca0182ab494cd9deace2a251d91d70560d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed deprecated option ``idle_timeout``."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4b71335c_5af8496e","line":4,"updated":"2021-05-26 16:57:29.000000000","message":"You\u0027ve actually removed a lot more:\n\n            cfg.DeprecatedOpt(\u0027idle_timeout\u0027,\n                              group\u003d\"DATABASE\"),\n            cfg.DeprecatedOpt(\u0027idle_timeout\u0027,\n                              group\u003d\"database\"),\n            cfg.DeprecatedOpt(\u0027sql_idle_timeout\u0027,\n                              group\u003d\u0027DEFAULT\u0027),\n            cfg.DeprecatedOpt(\u0027sql_idle_timeout\u0027,\n                              group\u003d\u0027DATABASE\u0027),\n            cfg.DeprecatedOpt(\u0027idle_timeout\u0027,\n                              group\u003d\u0027sql\u0027)\n\nPlus you\u0027ve removed the deprecated \u0027idle_timeout\u0027 keyword argument for the \u0027_TransactionFactory.configure_defaults\u0027 and \u0027_TransactionFactory.configure\u0027 methods, though this shouldn\u0027t affect end-users since they shouldn\u0027t be using these directly. How about:\n\n  Removed the ``[DATABASE] idle_timeout``, ``[database] idle_timeout``,\n  ``[sql] idle_timeout``, ``[DEFAULT] sql_idle_timeout`` and\n  ``[DATABASE] sql_idle_timeout`` options. These were all legacy aliases\n  for ``[database] connection_recycle_time``.","commit_id":"6edaf29da034608f413084d255e4a2a082dd0bd6"}]}