)]}'
{"oslo_db/sqlalchemy/utils.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b644990cac0e231ef1c7add8c8d1b4b3b62bcd32","unresolved":true,"context_lines":[{"line_number":1184,"context_line":"                )"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":""},{"line_number":1187,"context_line":"def getargspec(fn):"},{"line_number":1188,"context_line":"    \"\"\"Inspects a function for its argspec."},{"line_number":1189,"context_line":""},{"line_number":1190,"context_line":"    This is to handle a difference between py2/3. The Python 2.x getargspec"}],"source_content_type":"text/x-python","patch_set":1,"id":"7c990cbf_ad32445a","side":"PARENT","line":1187,"range":{"start_line":1187,"start_character":0,"end_line":1187,"end_character":19},"updated":"2021-06-03 12:35:17.000000000","message":"At first glance I didn\u0027t see external usage of this method [1][2]. It doesn\u0027t seems called outside oslo.db.\n\nI would argue that it will be more or less safe to drop it, however, I wonder if we should start by deprecating it first and then remove it in couple of months, to avoid side effect and brutal disconnection. Indeed this a public method in public module.\n\nThoughts?\n\n[1] https://codesearch.opendev.org/?q\u003dgetargspec\u0026i\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\n[2] https://codesearch.opendev.org/?q\u003dutils.getargspec\u0026i\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"78d12d76969730d25f81b069b1b40730b91bd62f"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"82e1c61c8deac3e8c7754804113fede1a0086afd","unresolved":true,"context_lines":[{"line_number":1184,"context_line":"                )"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":""},{"line_number":1187,"context_line":"def getargspec(fn):"},{"line_number":1188,"context_line":"    \"\"\"Inspects a function for its argspec."},{"line_number":1189,"context_line":""},{"line_number":1190,"context_line":"    This is to handle a difference between py2/3. The Python 2.x getargspec"}],"source_content_type":"text/x-python","patch_set":1,"id":"7eee3ffe_c18a0dd3","side":"PARENT","line":1187,"range":{"start_line":1187,"start_character":0,"end_line":1187,"end_character":19},"in_reply_to":"7c990cbf_ad32445a","updated":"2021-06-22 09:59:40.000000000","message":"I agree it would be better to deprecated first.","commit_id":"78d12d76969730d25f81b069b1b40730b91bd62f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2306afea190174cb330a627af5564747dd704424","unresolved":true,"context_lines":[{"line_number":1184,"context_line":"                )"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":""},{"line_number":1187,"context_line":"def getargspec(fn):"},{"line_number":1188,"context_line":"    \"\"\"Inspects a function for its argspec."},{"line_number":1189,"context_line":""},{"line_number":1190,"context_line":"    This is to handle a difference between py2/3. The Python 2.x getargspec"}],"source_content_type":"text/x-python","patch_set":1,"id":"c01b894f_c6df4b06","side":"PARENT","line":1187,"range":{"start_line":1187,"start_character":0,"end_line":1187,"end_character":19},"in_reply_to":"7eee3ffe_c18a0dd3","updated":"2021-06-22 10:58:48.000000000","message":"I don\u0027t think this is worth deprecating. It has no users and was only ever a utility method meant for use internally. As far as safe things go, this is pretty darn safe 😄","commit_id":"78d12d76969730d25f81b069b1b40730b91bd62f"}]}