)]}'
{"oslo_db/sqlalchemy/utils.py":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"9f8afce332c474c03190e989be99ae4e6949f5a3","unresolved":true,"context_lines":[{"line_number":683,"context_line":"    # 3) Drop old table."},{"line_number":684,"context_line":"    # 4) Rename new table to old table name."},{"line_number":685,"context_line":"    meta \u003d MetaData()"},{"line_number":686,"context_line":"    meta.bind \u003d engine"},{"line_number":687,"context_line":"    table \u003d Table(table_name, meta, autoload\u003dTrue)"},{"line_number":688,"context_line":"    default_deleted_value \u003d _get_default_deleted_value(table)"},{"line_number":689,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"73b4e36c_90ce4f2b","line":686,"updated":"2021-08-09 12:53:20.000000000","message":"the meta.bind thing overall is deprecated we just arent hitting the attribute set.","commit_id":"c85142a945b5cc1e61c9c5b08ff537d5048d80ce"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"9f8afce332c474c03190e989be99ae4e6949f5a3","unresolved":true,"context_lines":[{"line_number":684,"context_line":"    # 4) Rename new table to old table name."},{"line_number":685,"context_line":"    meta \u003d MetaData()"},{"line_number":686,"context_line":"    meta.bind \u003d engine"},{"line_number":687,"context_line":"    table \u003d Table(table_name, meta, autoload\u003dTrue)"},{"line_number":688,"context_line":"    default_deleted_value \u003d _get_default_deleted_value(table)"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"    columns \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"cf8f219a_7c45343e","line":687,"updated":"2021-08-09 12:53:20.000000000","message":"this should be Table(..., autoload_with\u003dengine)","commit_id":"c85142a945b5cc1e61c9c5b08ff537d5048d80ce"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"7b168ba255c1771030e5150b5d1771cc01d190ad","unresolved":true,"context_lines":[{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    old_deleted \u003d Column(\u0027old_deleted\u0027, Boolean, default\u003dFalse)"},{"line_number":566,"context_line":"    table.metadata.bind \u003d engine"},{"line_number":567,"context_line":"    try:"},{"line_number":568,"context_line":"        old_deleted.create(table, populate_default\u003dFalse)"},{"line_number":569,"context_line":"    finally:"},{"line_number":570,"context_line":"        table.metadata.bind \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ca92ce3_d75d259b","line":567,"updated":"2021-08-09 18:50:36.000000000","message":"these are all here strictly to appease migrate in the most minimal way possible.   by removing \"bind\" afterwards we make sure no other part of the test suite is relying upon this.","commit_id":"22b44ee18b1585bc2943a29ddaa18051cb1344ed"}],"oslo_db/tests/sqlalchemy/test_exc_filters.py":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"9f8afce332c474c03190e989be99ae4e6949f5a3","unresolved":true,"context_lines":[{"line_number":253,"context_line":"        super(TestNonExistentConstraint, self).setUp()"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        meta \u003d sqla.MetaData()"},{"line_number":256,"context_line":"        meta.bind \u003d self.engine"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        self.table_1 \u003d sqla.Table("},{"line_number":259,"context_line":"            \"resource_foo\", meta,"}],"source_content_type":"text/x-python","patch_set":4,"id":"b6f52aba_e835fa0c","line":256,"updated":"2021-08-09 12:53:20.000000000","message":"let\u0027s take this out and see if anything fails","commit_id":"c85142a945b5cc1e61c9c5b08ff537d5048d80ce"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"9f8afce332c474c03190e989be99ae4e6949f5a3","unresolved":true,"context_lines":[{"line_number":261,"context_line":"            mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":262,"context_line":"            mysql_charset\u003d\u0027utf8\u0027,"},{"line_number":263,"context_line":"        )"},{"line_number":264,"context_line":"        self.table_1.create()"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"class TestNonExistentConstraintPostgreSQL("}],"source_content_type":"text/x-python","patch_set":4,"id":"d31df745_1cf350cb","line":264,"updated":"2021-08-09 12:53:20.000000000","message":"self.table_1.create(self.engine)","commit_id":"c85142a945b5cc1e61c9c5b08ff537d5048d80ce"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"9f8afce332c474c03190e989be99ae4e6949f5a3","unresolved":true,"context_lines":[{"line_number":323,"context_line":"        super(TestNonExistentTable, self).setUp()"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        self.meta \u003d sqla.MetaData()"},{"line_number":326,"context_line":"        self.meta.bind \u003d self.engine"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        self.table_1 \u003d sqla.Table("},{"line_number":329,"context_line":"            \"foo\", self.meta,"}],"source_content_type":"text/x-python","patch_set":4,"id":"72f30460_08dce885","line":326,"updated":"2021-08-09 12:53:20.000000000","message":"remove","commit_id":"c85142a945b5cc1e61c9c5b08ff537d5048d80ce"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"9f8afce332c474c03190e989be99ae4e6949f5a3","unresolved":true,"context_lines":[{"line_number":468,"context_line":"        super(TestReferenceErrorSQLite, self).setUp()"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        meta \u003d sqla.MetaData()"},{"line_number":471,"context_line":"        meta.bind \u003d self.engine"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        self.table_1 \u003d sqla.Table("},{"line_number":474,"context_line":"            \"resource_foo\", meta,"}],"source_content_type":"text/x-python","patch_set":4,"id":"f0c4ea40_43682536","line":471,"updated":"2021-08-09 12:53:20.000000000","message":"remove","commit_id":"c85142a945b5cc1e61c9c5b08ff537d5048d80ce"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"9f8afce332c474c03190e989be99ae4e6949f5a3","unresolved":true,"context_lines":[{"line_number":477,"context_line":"            mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":478,"context_line":"            mysql_charset\u003d\u0027utf8\u0027,"},{"line_number":479,"context_line":"        )"},{"line_number":480,"context_line":"        self.table_1.create()"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        self.table_2 \u003d sqla.Table("},{"line_number":483,"context_line":"            \"resource_entity\", meta,"}],"source_content_type":"text/x-python","patch_set":4,"id":"d3aba845_7196492d","line":480,"updated":"2021-08-09 12:53:20.000000000","message":"create(self.engine)","commit_id":"c85142a945b5cc1e61c9c5b08ff537d5048d80ce"}],"oslo_db/tests/sqlalchemy/test_utils.py":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"9f8afce332c474c03190e989be99ae4e6949f5a3","unresolved":true,"context_lines":[{"line_number":667,"context_line":"    def setUp(self):"},{"line_number":668,"context_line":"        super(TestMigrationUtils, self).setUp()"},{"line_number":669,"context_line":"        self.meta \u003d MetaData()"},{"line_number":670,"context_line":"        self.meta.bind \u003d self.engine"},{"line_number":671,"context_line":"        self.conn \u003d self.engine.connect()"},{"line_number":672,"context_line":"        self.addCleanup(self.meta.drop_all)"},{"line_number":673,"context_line":"        self.addCleanup(self.conn.close)"}],"source_content_type":"text/x-python","patch_set":4,"id":"87543053_5467abc9","line":670,"updated":"2021-08-09 12:53:20.000000000","message":"remove","commit_id":"c85142a945b5cc1e61c9c5b08ff537d5048d80ce"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"9f8afce332c474c03190e989be99ae4e6949f5a3","unresolved":true,"context_lines":[{"line_number":669,"context_line":"        self.meta \u003d MetaData()"},{"line_number":670,"context_line":"        self.meta.bind \u003d self.engine"},{"line_number":671,"context_line":"        self.conn \u003d self.engine.connect()"},{"line_number":672,"context_line":"        self.addCleanup(self.meta.drop_all)"},{"line_number":673,"context_line":"        self.addCleanup(self.conn.close)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    def _populate_db_for_drop_duplicate_entries(self, engine, meta,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aa0e387_6a3b9bfc","line":672,"updated":"2021-08-09 12:53:20.000000000","message":"this is an example of why bound metadata is bad, this should use the connection ideally\n\nself.addCleanup(self.meta.drop_all, self.conn)","commit_id":"c85142a945b5cc1e61c9c5b08ff537d5048d80ce"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"9f8afce332c474c03190e989be99ae4e6949f5a3","unresolved":true,"context_lines":[{"line_number":1259,"context_line":"    def setUp(self):"},{"line_number":1260,"context_line":"        super(TestUtils, self).setUp()"},{"line_number":1261,"context_line":"        meta \u003d MetaData()"},{"line_number":1262,"context_line":"        meta.bind \u003d self.engine"},{"line_number":1263,"context_line":"        self.test_table \u003d Table("},{"line_number":1264,"context_line":"            \u0027test_table\u0027,"},{"line_number":1265,"context_line":"            meta,"}],"source_content_type":"text/x-python","patch_set":4,"id":"d7d1e44e_a40769f5","line":1262,"updated":"2021-08-09 12:53:20.000000000","message":"remove","commit_id":"c85142a945b5cc1e61c9c5b08ff537d5048d80ce"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"7b168ba255c1771030e5150b5d1771cc01d190ad","unresolved":true,"context_lines":[{"line_number":669,"context_line":"        self.meta \u003d MetaData()"},{"line_number":670,"context_line":"        self.conn \u003d self.engine.connect()"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"        # self.conn would be better here but does not work right now"},{"line_number":673,"context_line":"        self.addCleanup(self.meta.drop_all, self.engine)"},{"line_number":674,"context_line":"        self.addCleanup(self.conn.close)"},{"line_number":675,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"985f6dee_5b79388c","line":672,"updated":"2021-08-09 18:50:36.000000000","message":"not really sure what self.conn is for, by the time this cleanup happens it\u0027s already closed.","commit_id":"22b44ee18b1585bc2943a29ddaa18051cb1344ed"}]}
