)]}'
{"oslo_db/tests/sqlalchemy/test_exc_filters.py":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"9662fc564b2820263defdc0f6091255ad95b76bf","unresolved":true,"context_lines":[{"line_number":1166,"context_line":"        with self._fixture(dialect_name, exc_obj, 1, is_disconnect):"},{"line_number":1167,"context_line":"            conn \u003d self.engine.connect()"},{"line_number":1168,"context_line":"            with conn.begin():"},{"line_number":1169,"context_line":"                self.assertEqual(1, conn.scalar(sqla.select(1)))"},{"line_number":1170,"context_line":"                self.assertFalse(conn.closed)"},{"line_number":1171,"context_line":"                self.assertFalse(conn.invalidated)"},{"line_number":1172,"context_line":"                self.assertTrue(conn.in_transaction())"}],"source_content_type":"text/x-python","patch_set":5,"id":"e0727edf_cc0cbb64","side":"PARENT","line":1169,"updated":"2021-08-24 13:03:45.000000000","message":"this one is fine, \"conn\" is a Connection","commit_id":"8772fcc349226b152e8a04a8ed3e883231412043"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8a25567f9f970f4446c09791dd9c21f257642b01","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"        with self._fixture(dialect_name, exc_obj, 1, is_disconnect):"},{"line_number":1167,"context_line":"            conn \u003d self.engine.connect()"},{"line_number":1168,"context_line":"            with conn.begin():"},{"line_number":1169,"context_line":"                self.assertEqual(1, conn.scalar(sqla.select(1)))"},{"line_number":1170,"context_line":"                self.assertFalse(conn.closed)"},{"line_number":1171,"context_line":"                self.assertFalse(conn.invalidated)"},{"line_number":1172,"context_line":"                self.assertTrue(conn.in_transaction())"}],"source_content_type":"text/x-python","patch_set":5,"id":"ed046fd8_19ea902a","side":"PARENT","line":1169,"in_reply_to":"e0727edf_cc0cbb64","updated":"2021-08-25 10:18:06.000000000","message":"Ack","commit_id":"8772fcc349226b152e8a04a8ed3e883231412043"}],"oslo_db/tests/sqlalchemy/test_sqlalchemy.py":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"9662fc564b2820263defdc0f6091255ad95b76bf","unresolved":true,"context_lines":[{"line_number":479,"context_line":"        engine \u003d self._fixture(sqlite_fk\u003dTrue)"},{"line_number":480,"context_line":"        self.assertEqual("},{"line_number":481,"context_line":"            1,"},{"line_number":482,"context_line":"            engine.execute(sql.text(\u0027pragma foreign_keys\u0027)).scalars().first(),"},{"line_number":483,"context_line":"        )"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        engine \u003d self._fixture(sqlite_fk\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"177a93f3_753c66f5","line":482,"updated":"2021-08-24 13:03:45.000000000","message":"these should all be with \"with engine.connect() as conn\", but I get that you are doing exactly one warning per changeset","commit_id":"fadc0ef9022a360016d2e9af756fb93c9c308467"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8a25567f9f970f4446c09791dd9c21f257642b01","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        engine \u003d self._fixture(sqlite_fk\u003dTrue)"},{"line_number":480,"context_line":"        self.assertEqual("},{"line_number":481,"context_line":"            1,"},{"line_number":482,"context_line":"            engine.execute(sql.text(\u0027pragma foreign_keys\u0027)).scalars().first(),"},{"line_number":483,"context_line":"        )"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        engine \u003d self._fixture(sqlite_fk\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"e58cd09e_24070f09","line":482,"in_reply_to":"177a93f3_753c66f5","updated":"2021-08-25 10:18:06.000000000","message":"Yeah, I did this here [1]\n\n[1] https://review.opendev.org/c/openstack/oslo.db/+/802586/5/oslo_db/tests/sqlalchemy/test_sqlalchemy.py#479","commit_id":"fadc0ef9022a360016d2e9af756fb93c9c308467"}]}