)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a2f68c1a1265797c84ccb1df1cfb6a4fc5b7bdfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"07afcb40_d4c00144","updated":"2021-11-15 11:29:44.000000000","message":"recheck","commit_id":"df901a1c765c16de77c2f734760e9ecf95483737"}],"oslo_db/sqlalchemy/utils.py":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"140c5620750590e758e06ab8d5e03d3a6eb30859","unresolved":true,"context_lines":[{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"    params[\u0027database\u0027] \u003d connectable.engine.url.database"},{"line_number":1122,"context_line":"    query \u003d text(query_str)"},{"line_number":1123,"context_line":"    # TODO(stephenfin): What about if this is already a Connection?"},{"line_number":1124,"context_line":"    with connectable.connect() as conn:"},{"line_number":1125,"context_line":"        noninnodb \u003d conn.execute(query, params)"},{"line_number":1126,"context_line":"    return [i[0] for i in noninnodb]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9b430640_ec379ea6","line":1123,"updated":"2021-08-24 13:08:53.000000000","message":"the way it\u0027s supposed to work is \"connectable\" goes away and you have either an Engine or Connection coming in as your argument.   so this \"connectable.connect()\" should be removed","commit_id":"df901a1c765c16de77c2f734760e9ecf95483737"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1fb377b56f3758dc51e76c20219583b69decda8e","unresolved":true,"context_lines":[{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"    params[\u0027database\u0027] \u003d connectable.engine.url.database"},{"line_number":1122,"context_line":"    query \u003d text(query_str)"},{"line_number":1123,"context_line":"    # TODO(stephenfin): What about if this is already a Connection?"},{"line_number":1124,"context_line":"    with connectable.connect() as conn:"},{"line_number":1125,"context_line":"        noninnodb \u003d conn.execute(query, params)"},{"line_number":1126,"context_line":"    return [i[0] for i in noninnodb]"}],"source_content_type":"text/x-python","patch_set":5,"id":"a7eefe12_7b04ea3f","line":1123,"in_reply_to":"9b430640_ec379ea6","updated":"2021-08-25 10:20:00.000000000","message":"If I\u0027ve an Engine, don\u0027t I still need to call \u0027connect()\u0027? Or are you suggesting I take only an Engine or only a Connection as a parameter?","commit_id":"df901a1c765c16de77c2f734760e9ecf95483737"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"34ea87b2fee9af9c9185f3e67536b29930a7c62a","unresolved":true,"context_lines":[{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"    params[\u0027database\u0027] \u003d connectable.engine.url.database"},{"line_number":1122,"context_line":"    query \u003d text(query_str)"},{"line_number":1123,"context_line":"    # TODO(stephenfin): What about if this is already a Connection?"},{"line_number":1124,"context_line":"    with connectable.connect() as conn:"},{"line_number":1125,"context_line":"        noninnodb \u003d conn.execute(query, params)"},{"line_number":1126,"context_line":"    return [i[0] for i in noninnodb]"}],"source_content_type":"text/x-python","patch_set":5,"id":"48caa9f6_5a079ac4","line":1123,"in_reply_to":"a7eefe12_7b04ea3f","updated":"2021-08-25 13:52:55.000000000","message":"right, if the argument is an \"engine\", then you engine.connect().  if a Connection is passed, that\u0027s an error.    ive done away with this notion of \"nesting connectables\", nobody ever used it and people didnt understand it really.","commit_id":"df901a1c765c16de77c2f734760e9ecf95483737"}]}