)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"e77d8936506d9fc3b05addb6e22192f8e8595fe6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fcd72c62_31424b3f","updated":"2022-02-04 02:27:24.000000000","message":"OK you did a search and nobody is using them right?   I guess I wrote these...but im not seeing where they do the nested transaction.  I guess they generate the warning?","commit_id":"7013599c9e7c66e4d24ab01052153b994d593df9"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"87e78d334a0e8ca174215ae31f83459cc80f5287","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dbaa9ce7_92b0ea97","updated":"2022-02-04 03:21:53.000000000","message":"i found testresources very challenging to work with back when i did this.","commit_id":"7013599c9e7c66e4d24ab01052153b994d593df9"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"9fabf324676fc838cb336197140991d673d79d60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4821be3e_8e1bd4a8","updated":"2022-02-04 03:19:52.000000000","message":"oh OK, I see the gerrit at https://review.opendev.org/c/openstack/oslo.db/+/804773 is failing because of these.   weird, let me try to understand where that is happening","commit_id":"7013599c9e7c66e4d24ab01052153b994d593df9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1eadefb2c0c92b4372592e59daf9341bc021dcfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"096d5894_a3c5f5b2","updated":"2022-02-04 19:38:01.000000000","message":"recheck I think I forgot to reverse the order of this and the previous change","commit_id":"7013599c9e7c66e4d24ab01052153b994d593df9"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"ec29e6b7b04171e48de555af81f989b745134708","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70072e8f_7e407f20","updated":"2022-02-04 03:28:30.000000000","message":"yeah i see how this works.  yes this was the height of how the \"subtransactions\" thing was supposed to work, and we see very cleverly that we have both an \"Engine\" and a \"Connection\" that are both just a \"Connection\", with this very slick approach of just calling \"begin()\" inside \"begin()\" and it all works out.    Works great yet we see here it took me 20 minutes to understand what this code was doing and I hardly even recognized that I\u0027m the one that wrote it :) ","commit_id":"7013599c9e7c66e4d24ab01052153b994d593df9"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"bf237214a9a47a27eb60cef6fc10672919583d29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7e17fd91_d630341e","in_reply_to":"c4630406_7c10c3f9","updated":"2022-02-04 03:28:59.000000000","message":"Done","commit_id":"7013599c9e7c66e4d24ab01052153b994d593df9"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"e8707f9080633fa65b4b735a2e511336772609bc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c4630406_7c10c3f9","in_reply_to":"fcd72c62_31424b3f","updated":"2022-02-04 02:29:29.000000000","message":"to be clear, I mean \"subtransactions\".  \"nested\" transactions are SAVEPOINTs, those are fine.  Is the code here using subtransactions (where?)\n\nat the same time, I added these fixtures anticipationally back when we were compelled to integrate testresources and if they aren\u0027t needed we might be better off getting rid of them.","commit_id":"7013599c9e7c66e4d24ab01052153b994d593df9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"15e2eb29a5fd73b4503ca5ff3d2bbd112215d077","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1cb47c22_0e49c880","updated":"2022-02-08 16:12:28.000000000","message":"Just change the order of these. CI will protect us if this is still failing.","commit_id":"22c602f075795b6d5ecbbc2e229817f759613ea2"}],"oslo_db/sqlalchemy/utils.py":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"87e78d334a0e8ca174215ae31f83459cc80f5287","unresolved":false,"context_lines":[{"line_number":1286,"context_line":""},{"line_number":1287,"context_line":"    def __init__(self, connection):"},{"line_number":1288,"context_line":"        self.connection \u003d connection"},{"line_number":1289,"context_line":"        self._trans \u003d connection.begin()"},{"line_number":1290,"context_line":"        self._restart_nested()"},{"line_number":1291,"context_line":""},{"line_number":1292,"context_line":"    def _restart_nested(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"760961e9_cb79c3a1","side":"PARENT","line":1289,"updated":"2022-02-04 03:21:53.000000000","message":"oh duh it\u0027s right here.   OK sorry.   yes no reason to keep this unused stuff around","commit_id":"5e5ab7c7bde332fd5d866ecc58586272c1e1d814"}]}