)]}'
{"oslo_db/sqlalchemy/utils.py":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"85a4c4f2597fdff985c9ac926ae619b3f0509e3f","unresolved":true,"context_lines":[{"line_number":1136,"context_line":"    return [i[0] for i in noninnodb]"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":"def get_non_ndbcluster_tables(connectable, skip_tables\u003dNone):"},{"line_number":1140,"context_line":"    \"\"\"Get a list of tables which don\u0027t use MySQL Cluster (NDB) storage engine."},{"line_number":1141,"context_line":""},{"line_number":1142,"context_line":"    :param connectable: a SQLAlchemy Engine or Connection instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"d2c19d9c_874518d8","line":1139,"updated":"2022-02-08 15:29:34.000000000","message":"I think this whole method is a zombie at this point.  there was a programmer I think working for Oracle who came through and got us to add all this \"NDB Cluster\" stuff to oslo.db, they then vanished.  Their many gerrits across many openstack projects, most of which were not accepted, have been slowly being abandoned since then.","commit_id":"43142792502afe5e5ce29a4cc3c291f673ef066e"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"a707952d0893c4c7a1b448d6eff2ddb6201180c5","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"    return [i[0] for i in noninnodb]"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":"def get_non_ndbcluster_tables(connectable, skip_tables\u003dNone):"},{"line_number":1140,"context_line":"    \"\"\"Get a list of tables which don\u0027t use MySQL Cluster (NDB) storage engine."},{"line_number":1141,"context_line":""},{"line_number":1142,"context_line":"    :param connectable: a SQLAlchemy Engine or Connection instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"e9563eeb_10174248","line":1139,"in_reply_to":"d2c19d9c_874518d8","updated":"2022-07-20 14:08:50.000000000","message":"Done","commit_id":"43142792502afe5e5ce29a4cc3c291f673ef066e"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"85a4c4f2597fdff985c9ac926ae619b3f0509e3f","unresolved":true,"context_lines":[{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":"    params[\u0027database\u0027] \u003d connectable.engine.url.database"},{"line_number":1164,"context_line":"    query \u003d text(query_str)"},{"line_number":1165,"context_line":"    # TODO(stephenfin): What about if this is already a Connection?"},{"line_number":1166,"context_line":"    with connectable.connect() as conn, conn.begin():"},{"line_number":1167,"context_line":"        nonndbcluster \u003d connectable.execute(query, **params)"},{"line_number":1168,"context_line":"    return [i[0] for i in nonndbcluster]"}],"source_content_type":"text/x-python","patch_set":3,"id":"2a52baf3_a7e580f8","line":1165,"updated":"2022-02-08 15:29:34.000000000","message":"it will raise an error :)   we should look to see that NDB is a non-starter in the outside openstack world and deprecate all this stuff","commit_id":"43142792502afe5e5ce29a4cc3c291f673ef066e"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"a707952d0893c4c7a1b448d6eff2ddb6201180c5","unresolved":false,"context_lines":[{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":"    params[\u0027database\u0027] \u003d connectable.engine.url.database"},{"line_number":1164,"context_line":"    query \u003d text(query_str)"},{"line_number":1165,"context_line":"    # TODO(stephenfin): What about if this is already a Connection?"},{"line_number":1166,"context_line":"    with connectable.connect() as conn, conn.begin():"},{"line_number":1167,"context_line":"        nonndbcluster \u003d connectable.execute(query, **params)"},{"line_number":1168,"context_line":"    return [i[0] for i in nonndbcluster]"}],"source_content_type":"text/x-python","patch_set":3,"id":"66d1308c_e1e13f93","line":1165,"in_reply_to":"2a52baf3_a7e580f8","updated":"2022-07-20 14:08:50.000000000","message":"zero use, i would suggest all \"ndb\" gets removed from oslo.db at a later date\n\nhttps://codesearch.openstack.org/?q\u003dget_non_ndbcluster_tables\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"43142792502afe5e5ce29a4cc3c291f673ef066e"}]}
