)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"f1523a9450fc6e5635545d963a4105688677b4c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad704239_42a73ae4","updated":"2023-01-17 14:24:08.000000000","message":"OK I see you\u0027ve mentioned this at https://review.opendev.org/c/openstack/tacker/+/868851 .\n\nI thought also that if a galera env. has wsrep_sync_wait set to a non-zero value in config, and someone wants to set to zero, we should accept that.  So disregard my previous comment, let\u0027s make the default change here so that it\u0027s None, but also remove the language \"default 0\", say, \"defaults to None, which indicates no setting will be passed\".\n\nThen we need a test for a cfg -\u003e enginefacade -\u003e no event.    I added tests for this but apparently not enough.\n","commit_id":"bee6c77dd119429be9f681dd72a84511d7ff4e85"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"a2bbc1f096c67d13dd42856e4225d299a4850f64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e0f5ba3c_6ba9444e","updated":"2023-01-17 14:20:11.000000000","message":"why dont we leave it at \"0\" and instead, modify the event handler so that the event is not emitted if the value is 0.\n\nthat would also need a unit test.   The failure here is that there was not a test showing that this event is emitted uncondtiionally.\n\nalso no launchpad issue? I had heard about this problem anecdotally but I think it should be tracked.","commit_id":"bee6c77dd119429be9f681dd72a84511d7ff4e85"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a38129850add68c8eeef67392d71972dfe9c8b5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8c9a09c4_45cc05ef","in_reply_to":"ad704239_42a73ae4","updated":"2023-01-17 15:39:23.000000000","message":"Thanks for your comment.\n\n\u003e OK I see you\u0027ve mentioned this at https://review.opendev.org/c/openstack/tacker/+/868851 .\nYes, this patch fixes for tacker gate jobs.\n\nAnd I have changed docstrings like you said. Please kindly confirm it.\n\n\u003e Then we need a test for a cfg -\u003e enginefacade -\u003e no event.    I added tests for this but apparently not enough.\nIf you need a test, could you add it for me instead. Thanks.","commit_id":"bee6c77dd119429be9f681dd72a84511d7ff4e85"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f97dcb18a4f1c36e4dcd9a5d9d699cf7858456fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7c4c3e86_afdae97f","updated":"2023-01-18 09:09:51.000000000","message":"LGTM","commit_id":"b689b6320cdb7dbbb366bf35f23083814f5e79ec"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"375acc77528144d0f2552680292ad1fa246b2d38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3cc90998_2087810b","updated":"2023-01-18 16:44:16.000000000","message":"Releasing it with https://review.opendev.org/c/openstack/releases/+/870972","commit_id":"b689b6320cdb7dbbb366bf35f23083814f5e79ec"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"853a2f7ba3a5d55d87628ca77c7a1c8f32613aa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b668bd1a_2f40bafb","updated":"2023-01-18 02:16:35.000000000","message":"recheck - Unexpected identity error","commit_id":"b689b6320cdb7dbbb366bf35f23083814f5e79ec"}]}