)]}'
{"id":"openstack%2Foslo.db~878146","triplet_id":"openstack%2Foslo.db~master~I50d862d3cbb126987a63209795352c6e801ed919","project":"openstack/oslo.db","branch":"master","topic":"sqlalchemy-20","attention_set":{},"removed_from_attention_set":{"16688":{"account":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"last_update":"2023-04-05 12:47:58.000000000","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change","reason_account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},"11816":{"account":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"last_update":"2023-04-06 18:04:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I50d862d3cbb126987a63209795352c6e801ed919","subject":"Use SQLAlchemy native pre-ping","status":"MERGED","created":"2023-03-21 18:28:05.000000000","updated":"2023-04-09 04:23:35.000000000","submitted":"2023-04-06 18:04:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"878146-sqlalchemy-20","meta_rev_id":"5e513ce87cd9cf02afcbd8b6a1fdafc1812ad47f","_number":878146,"virtual_id_number":878146,"owner":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-04-06 18:04:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2023-04-06 16:07:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-04-09 04:23:35.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":1},"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2023-04-06 16:07:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-21 20:03:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-04-05 12:47:58.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2023-04-09 04:23:35.000000000","updated_by":{"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"},"reviewer":{"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"},"state":"REVIEWER"}],"messages":[{"id":"25b6af6334c196dc4bef7b97e89845c67fcde73c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"date":"2023-03-21 18:28:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1607ecfa42aa10885b1dbc9c2623fd7022961946","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"date":"2023-03-21 18:41:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c931e7307b656a42887e8993589f3face62824e2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-21 20:03:47.000000000","message":"Patch Set 2: Verified-1\n\n(27 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/dfe66e2c3e3547e4909e8470059e23ec\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/5c85a97e891d454ea189245f70289d1c : SUCCESS in 1h 20m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/84b70a3b743249418c03155f5e443545 : FAILURE in 4m 51s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7475796aee6747b68adec9f434ad1837 : SUCCESS in 5m 01s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/44621e4fb48c40c0b8fa31b817a08cdd : SUCCESS in 5m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/904df2df1b9344059d97d879efbb7d52 : SUCCESS in 4m 33s\n\nWarning:\n  Comments left for invalid file oslo_db/sqlalchemy/utils.py\n  Comments left for invalid file oslo_db/tests/sqlalchemy/test_provision.py\n  Comments left for invalid file oslo_db/tests/sqlalchemy/test_utils.py","accounts_in_message":[],"_revision_number":2},{"id":"1ff34cac0608667b5322aaeb4d358a128f1f887c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-03-22 11:16:06.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"dc75991578dc22c087d7d3b1e5245df1058a6bc5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-22 12:38:02.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/380a515f9e804e8aafc8da8a9c9fd5e1\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/dd042c998ee0482f9df37620df3c2601 : SUCCESS in 1h 20m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/428ea5f424d14fd182ed10cd00244688 : SUCCESS in 3m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3855d6dee40e403ea04f719a72deb09a : SUCCESS in 4m 42s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/4075c35e579e4083a9b47aedecc55ccf : SUCCESS in 3m 49s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dd407d967fcb4534a8b0143b6d66036a : SUCCESS in 4m 50s","accounts_in_message":[],"_revision_number":3},{"id":"67a969eb6b8e2a871d7495dd8d90a10b4dbaf6b4","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-03-23 12:06:20.000000000","message":"Topic use_native_pre_ping removed","accounts_in_message":[],"_revision_number":3},{"id":"1eb7d36dabcfff41fed97da18b73a63a6021860c","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-03-23 12:06:29.000000000","message":"Topic set to sqlalchemy-20","accounts_in_message":[],"_revision_number":3},{"id":"26168afaef76da29ed05ddc6981d6e646702c7f4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2023-04-04 15:47:01.000000000","message":"Patch Set 4: Patch Set 3 was rebased","accounts_in_message":[],"_revision_number":4},{"id":"60c5477c95e9698550e2a07bb3e1be5be5931230","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-04 17:09:50.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/6a41c130fd4f48a4af9e24751b59dd47\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/e4947f22966e4b7caeabc3115db6377b : SUCCESS in 1h 17m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/df53b13a285743c88311964229512fb3 : FAILURE in 3m 59s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/71c36f6aaa3744beb8838abffb007f19 : FAILURE in 4m 08s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/3d1dd38cd7834f3ba4b967f5dfc6ee6f : FAILURE in 4m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/48d7016bbed14c159bac6d1fee8dd895 : SUCCESS in 3m 54s\n\nWarning:\n  Comments left for invalid file oslo_db/tests/sqlalchemy/test_utils.py","accounts_in_message":[],"_revision_number":4},{"id":"7dc460aa02433cc1ab0094e6a5a8fa9440ea0cab","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-04-05 12:30:37.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"106e01eb6215a847af136621d410a1f73d6d3861","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-04-05 12:47:58.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"06f765929068f8122b0a0dfdfcb235e9e14e7212","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-05 14:17:27.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/64e5f2e2f49d4ab592b3818e6e6b277f\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/1b0d4f2104f7491ea6f0680b4653a315 : SUCCESS in 1h 39m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f1b29841605849a3af552e33b36303ca : SUCCESS in 3m 15s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/111e4aeea7724a359d9c61a066bac81c : SUCCESS in 3m 58s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/19ac4f4575de4a97bad176b4f942bcf7 : SUCCESS in 3m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8eeb8e68830243b3a6dbf93e7253a507 : SUCCESS in 4m 34s","accounts_in_message":[],"_revision_number":5},{"id":"d54b8557d3fad97fca70dbf67d347ff8ed73e929","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-04-06 13:55:14.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"bdaf15be46713c92016ff01e4d627a739232b199","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-06 15:32:34.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4e1b6832cfd54b4587195b5fb3e2f8ca\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/bf48f886890f447c8a21f90abbc4d702 : SUCCESS in 1h 31m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bf04cee694cc411b90c6396802a6f0c3 : SUCCESS in 4m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2b1dfaa5972e427d9efe6b1da2455be8 : SUCCESS in 4m 34s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/bae02a54ad02489f8bb9a9f1b596eb01 : SUCCESS in 4m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2078dde67d2c4cef9dbbce634d997fda : SUCCESS in 6m 24s","accounts_in_message":[],"_revision_number":6},{"id":"4d45d87b2ced7ee6daec4c3e9fab93d9941a8bd4","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-04-06 16:07:23.000000000","message":"Patch Set 6: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":6},{"id":"ceaf774ef79a0464f71de2ee3e49e4f7a030786a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-06 16:08:04.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"853b8ee3a650d59d7c56220d31d1912c4700aa87","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-06 18:04:29.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f5a817a2d7ff4ab8b78ede78ab89e156\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/23c36149ced24661aece082c86db09ef : SUCCESS in 1h 23m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1856510f7bbe43b78fb5493aa4f5ac38 : SUCCESS in 4m 55s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1519d20254f3462f8e1e36c00ffa5eba : SUCCESS in 5m 17s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/b2cdb887ceff44ae9d78de03a67f9dae : SUCCESS in 5m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9bdd494b5d1340058bb89b2ec85aee7b : SUCCESS in 4m 39s","accounts_in_message":[],"_revision_number":6},{"id":"39b570c97e18306e1fa52207a7d8f8fc8b1807de","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-06 18:04:29.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":6},{"id":"5ee8d7d7347de937f30781468c96f0914a4d9765","author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"date":"2023-04-06 18:06:57.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"5e513ce87cd9cf02afcbd8b6a1fdafc1812ad47f","author":{"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"},"date":"2023-04-09 04:23:35.000000000","message":"Patch Set 6: Code-Review+1","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"64e50494f219b5c06ed79f947c91cdb7f37cb0d6","revisions":{"d54c1de62d020148f71dcf2685198d1730159d8c":{"kind":"REWORK","_number":1,"created":"2023-03-21 18:28:05.000000000","uploader":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"ref":"refs/changes/46/878146/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.db","ref":"refs/changes/46/878146/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/1"}}},"commit":{"parents":[{"commit":"7e6ef95e8da91319d2f6640c44afeb6614f008d8","subject":"Get 2.0 to pass fully with test suite","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/7e6ef95e8da91319d2f6640c44afeb6614f008d8"}]}],"author":{"name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","date":"2023-03-21 18:23:19.000000000","tz":-240},"committer":{"name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","date":"2023-03-21 18:27:33.000000000","tz":-240},"subject":"use SQLAlchemy native pre-ping","message":"use SQLAlchemy native pre-ping\n\nThis functionality has been available upstream since SQLALchemy 1.2 [1].\nHowever, for oslo.db to use this feature while maintaining full\nbehavior, we need at least SQLAlchemy 2.0.5 to provide complete\nevent support.  In particular, oslo.db adds several new\n\"is disconnect\" conditions including those specific to Galera.\n\nBehavior of the handle_error event is modified to expect the\n\"pre-ping\" calling form, which may not have an \"engine\" present\n(only a dialect), and additionally takes advantage of the\nnew is_pre_ping attribute which informs on the correct way to\naffect the disconnection status within the ping handler.\n\nChange-Id: I50d862d3cbb126987a63209795352c6e801ed919\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/d54c1de62d020148f71dcf2685198d1730159d8c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/d54c1de62d020148f71dcf2685198d1730159d8c"}]},"branch":"refs/heads/master"},"d47af983c786119e87c8f073a4a691b185830ac8":{"kind":"REWORK","_number":2,"created":"2023-03-21 18:41:30.000000000","uploader":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"ref":"refs/changes/46/878146/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.db","ref":"refs/changes/46/878146/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/2"}}},"commit":{"parents":[{"commit":"a41c34add8df3482f941950800ce85deb0a69398","subject":"Get 2.0 to pass fully with test suite","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/a41c34add8df3482f941950800ce85deb0a69398"}]}],"author":{"name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","date":"2023-03-21 18:23:19.000000000","tz":-240},"committer":{"name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","date":"2023-03-21 18:40:44.000000000","tz":-240},"subject":"use SQLAlchemy native pre-ping","message":"use SQLAlchemy native pre-ping\n\nThis functionality has been available upstream since SQLALchemy 1.2 [1].\nHowever, for oslo.db to use this feature while maintaining full\nbehavior, we need at least SQLAlchemy 2.0.5 to provide complete\nevent support.  In particular, oslo.db adds several new\n\"is disconnect\" conditions including those specific to Galera.\n\nBehavior of the handle_error event is modified to expect the\n\"pre-ping\" calling form, which may not have an \"engine\" present\n(only a dialect), and additionally takes advantage of the\nnew is_pre_ping attribute which informs on the correct way to\naffect the disconnection status within the ping handler.\n\nChange-Id: I50d862d3cbb126987a63209795352c6e801ed919\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/d47af983c786119e87c8f073a4a691b185830ac8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/d47af983c786119e87c8f073a4a691b185830ac8"}]},"branch":"refs/heads/master"},"a3dff278f29dc46856d61596fa6f1fb7fed37027":{"kind":"REWORK","_number":3,"created":"2023-03-22 11:16:06.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/46/878146/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.db","ref":"refs/changes/46/878146/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/3"}}},"commit":{"parents":[{"commit":"e12f759f6dac97863c9a5e907ab478856475c775","subject":"Get 2.0 to pass fully with test suite","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/e12f759f6dac97863c9a5e907ab478856475c775"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-03-22 11:15:16.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-03-22 11:15:16.000000000","tz":0},"subject":"Use SQLAlchemy native pre-ping","message":"Use SQLAlchemy native pre-ping\n\nThis functionality has been available upstream since SQLALchemy 1.2 [1].\nHowever, for oslo.db to use this feature while maintaining full\nbehavior, we need at least SQLAlchemy 2.0.5 to provide complete event\nsupport.  In particular, oslo.db adds several new \"is disconnect\"\nconditions including those specific to Galera.\n\nBehavior of the handle_error event is modified to expect the \"pre-ping\"\ncalling form, which may not have an \"engine\" present (only a dialect),\nand additionally takes advantage of the new is_pre_ping attribute which\ninforms on the correct way to affect the disconnection status within the\nping handler.\n\nChange-Id: I50d862d3cbb126987a63209795352c6e801ed919\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/a3dff278f29dc46856d61596fa6f1fb7fed37027"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/a3dff278f29dc46856d61596fa6f1fb7fed37027"}]},"branch":"refs/heads/master"},"ca546714a9a5baeb109a4e7be1a305ca2dc31590":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2023-04-04 15:47:01.000000000","uploader":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"ref":"refs/changes/46/878146/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.db","ref":"refs/changes/46/878146/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/4"}}},"commit":{"parents":[{"commit":"f6139cc46a0a9825c0919b7c36620d8d097d8419","subject":"Get 2.0 to pass fully with test suite","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/f6139cc46a0a9825c0919b7c36620d8d097d8419"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-03-22 11:15:16.000000000","tz":0},"committer":{"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","date":"2023-04-04 15:47:01.000000000","tz":0},"subject":"Use SQLAlchemy native pre-ping","message":"Use SQLAlchemy native pre-ping\n\nThis functionality has been available upstream since SQLALchemy 1.2 [1].\nHowever, for oslo.db to use this feature while maintaining full\nbehavior, we need at least SQLAlchemy 2.0.5 to provide complete event\nsupport.  In particular, oslo.db adds several new \"is disconnect\"\nconditions including those specific to Galera.\n\nBehavior of the handle_error event is modified to expect the \"pre-ping\"\ncalling form, which may not have an \"engine\" present (only a dialect),\nand additionally takes advantage of the new is_pre_ping attribute which\ninforms on the correct way to affect the disconnection status within the\nping handler.\n\nChange-Id: I50d862d3cbb126987a63209795352c6e801ed919\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/ca546714a9a5baeb109a4e7be1a305ca2dc31590"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/ca546714a9a5baeb109a4e7be1a305ca2dc31590"}]},"branch":"refs/heads/master","description":"Rebase"},"cf0ec6f5f5003ee1ff84be5a571a01f0d8ded438":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2023-04-05 12:30:37.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/46/878146/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.db","ref":"refs/changes/46/878146/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/5"}}},"commit":{"parents":[{"commit":"7bf46a197b065de97b645475feeb5f5c5a98c6b1","subject":"Get 2.0 to pass fully with test suite","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/7bf46a197b065de97b645475feeb5f5c5a98c6b1"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-03-22 11:15:16.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-04-05 12:28:24.000000000","tz":60},"subject":"Use SQLAlchemy native pre-ping","message":"Use SQLAlchemy native pre-ping\n\nThis functionality has been available upstream since SQLALchemy 1.2 [1].\nHowever, for oslo.db to use this feature while maintaining full\nbehavior, we need at least SQLAlchemy 2.0.5 to provide complete event\nsupport.  In particular, oslo.db adds several new \"is disconnect\"\nconditions including those specific to Galera.\n\nBehavior of the handle_error event is modified to expect the \"pre-ping\"\ncalling form, which may not have an \"engine\" present (only a dialect),\nand additionally takes advantage of the new is_pre_ping attribute which\ninforms on the correct way to affect the disconnection status within the\nping handler.\n\nChange-Id: I50d862d3cbb126987a63209795352c6e801ed919\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/cf0ec6f5f5003ee1ff84be5a571a01f0d8ded438"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/cf0ec6f5f5003ee1ff84be5a571a01f0d8ded438"}]},"branch":"refs/heads/master"},"64e50494f219b5c06ed79f947c91cdb7f37cb0d6":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2023-04-06 13:55:14.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/46/878146/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.db","ref":"refs/changes/46/878146/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.db refs/changes/46/878146/6"}}},"commit":{"parents":[{"commit":"1f003bcb0b74cecbfe24f52402328b76a07c9983","subject":"Get test suite to full pass with SQLAlchemy 2.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/1f003bcb0b74cecbfe24f52402328b76a07c9983"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-03-22 11:15:16.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-04-06 13:55:03.000000000","tz":60},"subject":"Use SQLAlchemy native pre-ping","message":"Use SQLAlchemy native pre-ping\n\nThis functionality has been available upstream since SQLALchemy 1.2 [1].\nHowever, for oslo.db to use this feature while maintaining full\nbehavior, we need at least SQLAlchemy 2.0.5 to provide complete event\nsupport.  In particular, oslo.db adds several new \"is disconnect\"\nconditions including those specific to Galera.\n\nBehavior of the handle_error event is modified to expect the \"pre-ping\"\ncalling form, which may not have an \"engine\" present (only a dialect),\nand additionally takes advantage of the new is_pre_ping attribute which\ninforms on the correct way to affect the disconnection status within the\nping handler.\n\nChange-Id: I50d862d3cbb126987a63209795352c6e801ed919\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/64e50494f219b5c06ed79f947c91cdb7f37cb0d6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/64e50494f219b5c06ed79f947c91cdb7f37cb0d6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
