)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"878fe973f8f96310853a072466db7ee869b23baa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a10bf019_be5aa96c","updated":"2023-07-20 13:43:06.000000000","message":"so the idea of enginefacade was that it would be doing the \"begin\" for you, and here if \"autobegin\" is set to False, enginefacade is still calling begin() for you.  The net change in behavior should be zero.  So given that current design, I\u0027m not sure what the usefulness of this parameter is for enginefacade?","commit_id":"66d8d46206e649bc33844d15b25f7a6e05c52c9a"}],"oslo_db/sqlalchemy/enginefacade.py":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"878fe973f8f96310853a072466db7ee869b23baa","unresolved":true,"context_lines":[{"line_number":646,"context_line":"            self.session \u003d self.factory._create_session("},{"line_number":647,"context_line":"                bind\u003dself.connection, mode\u003dself.mode)"},{"line_number":648,"context_line":"            try:"},{"line_number":649,"context_line":"                self.session.begin()"},{"line_number":650,"context_line":"                with self._add_context(self.session, context):"},{"line_number":651,"context_line":"                    yield self.session"},{"line_number":652,"context_line":"                self._end_session_transaction(self.session)"}],"source_content_type":"text/x-python","patch_set":1,"id":"550f60cd_ced9ff94","line":649,"updated":"2023-07-20 13:43:06.000000000","message":"begin is called right here.   so if autobegin\u003dFalse, there is no net effect","commit_id":"66d8d46206e649bc33844d15b25f7a6e05c52c9a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"07c330cc40a5f936278288b9278bf119f2f46dbd","unresolved":false,"context_lines":[{"line_number":646,"context_line":"            self.session \u003d self.factory._create_session("},{"line_number":647,"context_line":"                bind\u003dself.connection, mode\u003dself.mode)"},{"line_number":648,"context_line":"            try:"},{"line_number":649,"context_line":"                self.session.begin()"},{"line_number":650,"context_line":"                with self._add_context(self.session, context):"},{"line_number":651,"context_line":"                    yield self.session"},{"line_number":652,"context_line":"                self._end_session_transaction(self.session)"}],"source_content_type":"text/x-python","patch_set":1,"id":"db57f99a_9d404efa","line":649,"in_reply_to":"550f60cd_ced9ff94","updated":"2023-07-26 15:53:48.000000000","message":"Yeah, I missed this. I had been working on Glance which doesn\u0027t use the context-based stuff yet, but that legacy stuff is all deprecated and doesn\u0027t need this.","commit_id":"66d8d46206e649bc33844d15b25f7a6e05c52c9a"}]}