)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"eb672dfc01c6e0aa12e7b220471517cd8ac2b7e0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If opportunistic test case, i.e. fixture, can\u0027t connect to a test"},{"line_number":10,"context_line":"database, it is happening silently, without any logs. Most of times we"},{"line_number":11,"context_line":"need to know a cause of fall."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia9f93a2ed38d11ec22d7aaafc90e194b153c5393"},{"line_number":14,"context_line":"Closes-Bug: #1306017"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ae8d1ca_da553bc7","line":11,"updated":"2014-05-28 22:54:18.000000000","message":"Nit: s/fall/failure/","commit_id":"964934b03802497cb3798cd9e0d88ebe5898eda7"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"e40c278b3fc6dac95b0292ec9619e148fe1214e3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If opportunistic test case, i.e. fixture, can\u0027t connect to a test"},{"line_number":10,"context_line":"database, it is happening silently, without any logs. Most of times we"},{"line_number":11,"context_line":"need to know a cause of fall."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia9f93a2ed38d11ec22d7aaafc90e194b153c5393"},{"line_number":14,"context_line":"Closes-Bug: #1306017"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ae8d1ca_f2d76ceb","line":11,"in_reply_to":"3ae8d1ca_da553bc7","updated":"2014-05-29 12:31:41.000000000","message":"Done","commit_id":"964934b03802497cb3798cd9e0d88ebe5898eda7"}],"oslo/db/sqlalchemy/utils.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"14b10f0d4dd3ca93e07ad95e63381043b8ff1cde","unresolved":false,"context_lines":[{"line_number":634,"context_line":"    except Exception as e:"},{"line_number":635,"context_line":"        # intentionally catch all to handle exceptions even if we don\u0027t"},{"line_number":636,"context_line":"        # have any backend code loaded."},{"line_number":637,"context_line":"        LOG.info(_LI(\"The backend is unavailable: {0}\").format(e))"},{"line_number":638,"context_line":"        return False"},{"line_number":639,"context_line":"    else:"},{"line_number":640,"context_line":"        connection.close()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_740bc9d5","line":637,"updated":"2014-05-19 20:18:58.000000000","message":"It probably isn\u0027t a big deal here, but I\u0027d prefer to use the logging format functionality here.  ie:\n\n  LOG.info(_LI(\u0027The backend is unavailable: %s\u0027), e)\n\nThat\u0027s preferred because it avoids doing the string formatting in the case where the current log level won\u0027t actually log the message.\n\nIn this case that\u0027s maybe not likely, but I\u0027d rather not have someone look at this and think it\u0027s how they should do their logging statement too.","commit_id":"1c61f8524040f51ca23bcc0db8148853a402ac4a"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"3546e04b74121ff429202c090e9a91b31e012d96","unresolved":false,"context_lines":[{"line_number":634,"context_line":"    except Exception as e:"},{"line_number":635,"context_line":"        # intentionally catch all to handle exceptions even if we don\u0027t"},{"line_number":636,"context_line":"        # have any backend code loaded."},{"line_number":637,"context_line":"        LOG.info(_LI(\"The backend is unavailable: {0}\").format(e))"},{"line_number":638,"context_line":"        return False"},{"line_number":639,"context_line":"    else:"},{"line_number":640,"context_line":"        connection.close()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_478e122f","line":637,"in_reply_to":"7adec928_740bc9d5","updated":"2014-05-20 09:00:21.000000000","message":"Ok.","commit_id":"1c61f8524040f51ca23bcc0db8148853a402ac4a"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"eb672dfc01c6e0aa12e7b220471517cd8ac2b7e0","unresolved":false,"context_lines":[{"line_number":634,"context_line":"    except Exception as e:"},{"line_number":635,"context_line":"        # intentionally catch all to handle exceptions even if we don\u0027t"},{"line_number":636,"context_line":"        # have any backend code loaded."},{"line_number":637,"context_line":"        LOG.info(_LI(\"The backend is unavailable: %s\"), e)"},{"line_number":638,"context_line":"        return False"},{"line_number":639,"context_line":"    else:"},{"line_number":640,"context_line":"        connection.close()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ae8d1ca_fa6757b5","line":637,"updated":"2014-05-28 22:54:18.000000000","message":"I think we should include the attempted backend in the log message too.  This will be getting run against any supported backend, so it won\u0027t necessarily be obvious which backend the exception is referring to.","commit_id":"964934b03802497cb3798cd9e0d88ebe5898eda7"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"e40c278b3fc6dac95b0292ec9619e148fe1214e3","unresolved":false,"context_lines":[{"line_number":634,"context_line":"    except Exception as e:"},{"line_number":635,"context_line":"        # intentionally catch all to handle exceptions even if we don\u0027t"},{"line_number":636,"context_line":"        # have any backend code loaded."},{"line_number":637,"context_line":"        LOG.info(_LI(\"The backend is unavailable: %s\"), e)"},{"line_number":638,"context_line":"        return False"},{"line_number":639,"context_line":"    else:"},{"line_number":640,"context_line":"        connection.close()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ae8d1ca_52e900b7","line":637,"in_reply_to":"3ae8d1ca_fa6757b5","updated":"2014-05-29 12:31:41.000000000","message":"Done","commit_id":"964934b03802497cb3798cd9e0d88ebe5898eda7"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"3cf9be7779dfbb8fff8f813ceaa9450c7017e26b","unresolved":false,"context_lines":[{"line_number":634,"context_line":"    except Exception as e:"},{"line_number":635,"context_line":"        # intentionally catch all to handle exceptions even if we don\u0027t"},{"line_number":636,"context_line":"        # have any backend code loaded."},{"line_number":637,"context_line":"        LOG.info(_LI(\"The %s is unavailable: %s\"), backend, e)"},{"line_number":638,"context_line":"        return False"},{"line_number":639,"context_line":"    else:"},{"line_number":640,"context_line":"        connection.close()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_eabe8dd3","line":637,"updated":"2014-05-29 16:39:11.000000000","message":"\"The mysql is unavailable\" might be a little difficult to parse for some people.  I would suggest leaving \"backend\" in there so it\u0027s something like \"The mysql backend is unavailable\".","commit_id":"3ca4c7a629aaf57cb336c01f358c08819d313126"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"7ecd6e67cd89720787690fe41cac17dbfc031a7c","unresolved":false,"context_lines":[{"line_number":634,"context_line":"    except Exception as e:"},{"line_number":635,"context_line":"        # intentionally catch all to handle exceptions even if we don\u0027t"},{"line_number":636,"context_line":"        # have any backend code loaded."},{"line_number":637,"context_line":"        LOG.info(_LI(\"The %s is unavailable: %s\"), backend, e)"},{"line_number":638,"context_line":"        return False"},{"line_number":639,"context_line":"    else:"},{"line_number":640,"context_line":"        connection.close()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_33dbee1c","line":637,"in_reply_to":"3ae8d1ca_eabe8dd3","updated":"2014-05-30 09:38:02.000000000","message":"Done","commit_id":"3ca4c7a629aaf57cb336c01f358c08819d313126"}],"tests/sqlalchemy/test_utils.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"3cf9be7779dfbb8fff8f813ceaa9450c7017e26b","unresolved":false,"context_lines":[{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def test_is_backend_unavail(self):"},{"line_number":653,"context_line":"        log \u003d self.useFixture(fixtures.FakeLogger())"},{"line_number":654,"context_line":"        error_cause \u003d \u0027Gang-bang error\u0027"},{"line_number":655,"context_line":"        error_msg \u003d (\"The %s is unavailable: %s\\n\" %"},{"line_number":656,"context_line":"                     (\u0027mysql\u0027, error_cause))"},{"line_number":657,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_0a9bb967","line":654,"updated":"2014-05-29 16:39:11.000000000","message":"I realize this is a weird objection, but \"gang-bang\" has some kind of offensive connotations here.  Can we use something else for this message?","commit_id":"3ca4c7a629aaf57cb336c01f358c08819d313126"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"7ecd6e67cd89720787690fe41cac17dbfc031a7c","unresolved":false,"context_lines":[{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def test_is_backend_unavail(self):"},{"line_number":653,"context_line":"        log \u003d self.useFixture(fixtures.FakeLogger())"},{"line_number":654,"context_line":"        error_cause \u003d \u0027Gang-bang error\u0027"},{"line_number":655,"context_line":"        error_msg \u003d (\"The %s is unavailable: %s\\n\" %"},{"line_number":656,"context_line":"                     (\u0027mysql\u0027, error_cause))"},{"line_number":657,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_73b656de","line":654,"in_reply_to":"3ae8d1ca_0a9bb967","updated":"2014-05-30 09:38:02.000000000","message":"No problem. I\u0027m sorry for any potential offensive connotations. I\u0027ll fix it.","commit_id":"3ca4c7a629aaf57cb336c01f358c08819d313126"}]}
