)]}'
{"tests/sqlalchemy/test_models.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"43adc22e45914e86b4c163015d70a3f4ca02351c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            \u0027b\u0027: \u00272\u0027,"},{"line_number":64,"context_line":"        }"},{"line_number":65,"context_line":"        self.ekm.update(h)"},{"line_number":66,"context_line":"        found_items \u003d 0"},{"line_number":67,"context_line":"        for key, value in self.ekm.iteritems():"},{"line_number":68,"context_line":"            self.assertEqual(expected[key], value)"},{"line_number":69,"context_line":"            found_items +\u003d 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_879d705c","line":66,"updated":"2014-07-08 12:54:47.000000000","message":"can we just compare two dicts using assertEquals() instead?","commit_id":"9a4d9a9312732078364dea2e13eb179fcbda25e6"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"17bd26beedd9848a332f9e0dc17a95d557145f4a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            \u0027b\u0027: \u00272\u0027,"},{"line_number":64,"context_line":"        }"},{"line_number":65,"context_line":"        self.ekm.update(h)"},{"line_number":66,"context_line":"        found_items \u003d 0"},{"line_number":67,"context_line":"        for key, value in self.ekm.iteritems():"},{"line_number":68,"context_line":"            self.assertEqual(expected[key], value)"},{"line_number":69,"context_line":"            found_items +\u003d 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_05a6c7aa","line":66,"in_reply_to":"baada198_879d705c","updated":"2014-07-15 13:38:23.000000000","message":"Done","commit_id":"9a4d9a9312732078364dea2e13eb179fcbda25e6"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"298d4d7878a5a30f2f29604124bf8fc483017379","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027b\u0027: \u00272\u0027,"},{"line_number":75,"context_line":"        }"},{"line_number":76,"context_line":"        self.ekm.update(h)"},{"line_number":77,"context_line":"        self.assertEqual(dict(self.ekm.iteritems()), expected)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_modelbase_iter(self):"},{"line_number":80,"context_line":"        expected \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_ef2c4c95","line":77,"updated":"2014-07-15 15:35:11.000000000","message":"I don\u0027t think this is safe to do in Python 2.6, which we unfortunately still support.  The assertDictEqual that is needed for this to work correctly wasn\u0027t added until 2.7: https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertDictEqual","commit_id":"35afdf17463eb970b04e8762988ef2274d622d96"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"18f8f8ca9db608d7e1e51b5ef7869efbc25e59d4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027b\u0027: \u00272\u0027,"},{"line_number":75,"context_line":"        }"},{"line_number":76,"context_line":"        self.ekm.update(h)"},{"line_number":77,"context_line":"        self.assertEqual(dict(self.ekm.iteritems()), expected)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_modelbase_iter(self):"},{"line_number":80,"context_line":"        expected \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_e380ab4b","line":77,"in_reply_to":"baada198_6f5ba72e","updated":"2014-07-16 19:36:07.000000000","message":"Hmm, apparently I was wrong: \"Mappings (dictionaries) compare equal if and only if their sorted (key, value) lists compare equal.\" from https://docs.python.org/2.7/reference/expressions.html#not-in\n\nMakes me wonder what the purpose of assertDictEqual in py27 is, but whatever. :-)","commit_id":"35afdf17463eb970b04e8762988ef2274d622d96"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"3de55239925db9788c5bb30159a8e1c604db13be","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027b\u0027: \u00272\u0027,"},{"line_number":75,"context_line":"        }"},{"line_number":76,"context_line":"        self.ekm.update(h)"},{"line_number":77,"context_line":"        self.assertEqual(dict(self.ekm.iteritems()), expected)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_modelbase_iter(self):"},{"line_number":80,"context_line":"        expected \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_e3db4b1f","line":77,"in_reply_to":"baada198_e380ab4b","updated":"2014-07-16 19:42:14.000000000","message":"maybe it has a better pretty-printing when they are non equal.   in any case a peek at the source would make it clear...","commit_id":"35afdf17463eb970b04e8762988ef2274d622d96"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"41d9559dcd7d7c07b8f7a6c82ec18f05e2157c0e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027b\u0027: \u00272\u0027,"},{"line_number":75,"context_line":"        }"},{"line_number":76,"context_line":"        self.ekm.update(h)"},{"line_number":77,"context_line":"        self.assertEqual(dict(self.ekm.iteritems()), expected)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_modelbase_iter(self):"},{"line_number":80,"context_line":"        expected \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_29b459d0","line":77,"in_reply_to":"baada198_ef2c4c95","updated":"2014-07-16 15:01:39.000000000","message":"Hi, Ben. Thanks for your review. \n\nCould you please explain what is the best way to compare 2 dictionaries in py26 test?","commit_id":"35afdf17463eb970b04e8762988ef2274d622d96"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"a52b4c5b83fe24cd12255338e1d60da60e457714","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027b\u0027: \u00272\u0027,"},{"line_number":75,"context_line":"        }"},{"line_number":76,"context_line":"        self.ekm.update(h)"},{"line_number":77,"context_line":"        self.assertEqual(dict(self.ekm.iteritems()), expected)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_modelbase_iter(self):"},{"line_number":80,"context_line":"        expected \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_6f5ba72e","line":77,"in_reply_to":"baada198_ef2c4c95","updated":"2014-07-16 16:31:17.000000000","message":"I don\u0027t understand that.   Why can\u0027t assertEqual() work with a dictionary?   `{} \u003d\u003d {}`.  Is it anticipating special dict-like types?  I don\u0027t see why this should be a problem for regular dictionaries.\n\nthough I will point out the assertEqual we use in \"fixtures\" does expect the \"expected\" value to be first: https://github.com/testing-cabal/testtools/blob/master/testtools/testcase.py#L330","commit_id":"35afdf17463eb970b04e8762988ef2274d622d96"}]}