)]}'
{"oslo/db/api.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"2f616eebf6fc716ecdf6639d9ac96557aeba7b17","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        return cls(backend_name\u003dconf.database.backend,"},{"line_number":183,"context_line":"                   backend_mapping\u003dbackend_mapping,"},{"line_number":184,"context_line":"                   lazy\u003dlazy,"},{"line_number":185,"context_line":"                   **dict(conf.database.items()))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_0e6fad93","line":185,"updated":"2014-05-27 12:13:35.000000000","message":"It looks like the constructor only actually uses 5 of the config options other than the backend_name. Could we pass those explicitly instead of passing in values that won\u0027t be used?","commit_id":"41ab54083dfc4eed2ae85e24a251f9e9791628eb"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"b527d376006d20a62c968446814f7324cdfdfb80","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        return cls(backend_name\u003dconf.database.backend,"},{"line_number":183,"context_line":"                   backend_mapping\u003dbackend_mapping,"},{"line_number":184,"context_line":"                   lazy\u003dlazy,"},{"line_number":185,"context_line":"                   **dict(conf.database.items()))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_ce8865ea","line":185,"in_reply_to":"3ae8d1ca_0e6fad93","updated":"2014-05-27 12:49:15.000000000","message":"Done","commit_id":"41ab54083dfc4eed2ae85e24a251f9e9791628eb"}],"oslo/db/options.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"2f616eebf6fc716ecdf6639d9ac96557aeba7b17","unresolved":false,"context_lines":[{"line_number":134,"context_line":"]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"def set_defaults(conf, **kwargs):"},{"line_number":138,"context_line":"    \"\"\"Set defaults for configuration variables.\"\"\""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    conf.register_opts(database_opts, group\u003d\u0027database\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_0e37ade4","line":137,"updated":"2014-05-27 12:13:35.000000000","message":"Instead of **kwds, this function should take explicit arguments for the options where overriding the defaults in code make sense, so the callers know what they can pass.","commit_id":"41ab54083dfc4eed2ae85e24a251f9e9791628eb"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"b527d376006d20a62c968446814f7324cdfdfb80","unresolved":false,"context_lines":[{"line_number":134,"context_line":"]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"def set_defaults(conf, **kwargs):"},{"line_number":138,"context_line":"    \"\"\"Set defaults for configuration variables.\"\"\""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    conf.register_opts(database_opts, group\u003d\u0027database\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_11e42c0c","line":137,"in_reply_to":"3ae8d1ca_0e37ade4","updated":"2014-05-27 12:49:15.000000000","message":"Ack. Let\u0027s stick to the subset of options that set_defaults() takes now (one of the next patches in the series will probably add slave_connection). Done.","commit_id":"41ab54083dfc4eed2ae85e24a251f9e9791628eb"}]}