)]}'
{"oslo/db/sqlalchemy/session.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"91d0eaa0518b6c98e47ebc36a3505bef8603575c","unresolved":false,"context_lines":[{"line_number":870,"context_line":""},{"line_number":871,"context_line":"        \"\"\""},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"        for arg in list(kwargs):"},{"line_number":874,"context_line":"            if arg not in (\u0027autocommit\u0027, \u0027expire_on_commit\u0027):"},{"line_number":875,"context_line":"                del kwargs[arg]"},{"line_number":876,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_3130f455","line":873,"updated":"2014-06-02 19:28:05.000000000","message":"Since only 2 keys are actually being kept, wouldn\u0027t it be simpler to just build a new dictionary with those 2 keys?\n\n  new_kwargs\u003d{}\n  if \u0027autocommit\u0027 in kwargs:\n    new_kwargs[\u0027autocommit\u0027] \u003d kwargs[\u0027autocommit\u0027]\n  if \u0027expire_on_commit\u0027 in kwargs:\n    new_kwargs[\u0027expire_on_commit\u0027] \u003d kwargs[\u0027expire_on_commit\u0027]","commit_id":"80cc45fa65251f2cd6558c4bca0ef7897504bd77"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"155147491491a770cedbcfaee4142284576889db","unresolved":false,"context_lines":[{"line_number":870,"context_line":""},{"line_number":871,"context_line":"        \"\"\""},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"        for arg in list(kwargs):"},{"line_number":874,"context_line":"            if arg not in (\u0027autocommit\u0027, \u0027expire_on_commit\u0027):"},{"line_number":875,"context_line":"                del kwargs[arg]"},{"line_number":876,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_e3995420","line":873,"in_reply_to":"1ae5cdf2_3130f455","updated":"2014-06-03 08:36:48.000000000","message":"Hmm, the more I look at this, the more I think method signature we have now kind of restricts the user in terms of SQLAlchemy Session usage.\n\nWe could probably accept keyword arguments,  pop() oslo.db specific arguments, and then pass all kwargs left to SQLAlchemy sessionmaker instance call as is (it supports more arguments: http://docs.sqlalchemy.org/en/rel_0_9/orm/session.html#sqlalchemy.orm.session.Session)","commit_id":"80cc45fa65251f2cd6558c4bca0ef7897504bd77"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"bf8cc4100b09230ffb04493222a4654e9256f53d","unresolved":false,"context_lines":[{"line_number":856,"context_line":""},{"line_number":857,"context_line":"        return self._engine"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"    def get_session(self, **kwargs):"},{"line_number":860,"context_line":"        \"\"\"Get a Session instance."},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        Keyword arugments will be passed to a sessionmaker instance as is (if"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_a805647b","line":859,"updated":"2014-06-03 09:16:59.000000000","message":"Before you ask: the next patch in the series will actually add oslo.db specific param here :)","commit_id":"28df4edde0eca54e4783e5e1e8253689af941779"}]}