)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"18533652aacf1c07d62fff6b7e23f55bb1bf2448","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9865395b_d659ea8d","updated":"2025-05-07 12:29:54.000000000","message":"hi, im not really understanding this patch.   oslo.db has always had \"pre-ping\" turned on for many years, SQLAlchemy\u0027s pre-ping feature is in fact a generalization of the feature as it was first invented in oslo.db!    The patch here seems to ignore that pool_pre_ping is already being set unconditionally to True a few lines above, and by changing the default to False is actually breaking oslo.db\u0027s contract that pre-ping is always turned on.\n\nlooking at the issue it would appear to be an invalid issue right up front.  pre-ping is already turned on in all cases.   not sure what the origin of the launchpad issue is since it does not indicate any symptoms.","commit_id":"98fdfb409aa1604a52a1c95e5cfb255586de6164"}],"oslo_db/sqlalchemy/engines.py":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"18533652aacf1c07d62fff6b7e23f55bb1bf2448","unresolved":true,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    _vet_url(url)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    _native_pre_ping \u003d compat.native_pre_ping_event_support"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    engine_args \u003d {"},{"line_number":226,"context_line":"        \"pool_recycle\": connection_recycle_time,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a45b984f_141d694a","line":223,"updated":"2025-05-07 12:29:54.000000000","message":"this is going to be True in all cases now since we are on SQLAlchemy 2.0","commit_id":"98fdfb409aa1604a52a1c95e5cfb255586de6164"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"18533652aacf1c07d62fff6b7e23f55bb1bf2448","unresolved":true,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    engine_args \u003d {"},{"line_number":226,"context_line":"        \"pool_recycle\": connection_recycle_time,"},{"line_number":227,"context_line":"        \"pool_pre_ping\": _native_pre_ping,"},{"line_number":228,"context_line":"        \"connect_args\": {},"},{"line_number":229,"context_line":"        \"logging_name\": logging_name,"},{"line_number":230,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"92b025a1_b6ac985d","line":227,"updated":"2025-05-07 12:29:54.000000000","message":"pre_ping is already set to True here.  it defaults to True, so we can\u0027t change this default to False","commit_id":"98fdfb409aa1604a52a1c95e5cfb255586de6164"}]}