)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"1f4eba8ab506a132118e7a45ed45a77f05dbbb45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3914a571_76d3ec49","updated":"2025-11-18 16:13:50.000000000","message":"i think we should default it to zero first and see how that goes","commit_id":"d00849c8bab13a399deb1780b46e0aa1ed09bc6d"}],"oslo_db/options.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"78685e4b5c24d9a9a6b46176f6de0e5ada530629","unresolved":true,"context_lines":[{"line_number":111,"context_line":"            \u0027Maximum number of SQL connections to keep open in a pool. \u0027"},{"line_number":112,"context_line":"            \u0027Setting a value of 0 indicates no limit.\u0027"},{"line_number":113,"context_line":"        ),"},{"line_number":114,"context_line":"    ),"},{"line_number":115,"context_line":"    cfg.IntOpt("},{"line_number":116,"context_line":"        \u0027max_retries\u0027,"},{"line_number":117,"context_line":"        default\u003d10,"},{"line_number":118,"context_line":"        help\u003d("},{"line_number":119,"context_line":"            \u0027Maximum number of database connection retries during startup. \u0027"},{"line_number":120,"context_line":"            \u0027Set to -1 to specify an infinite retry count.\u0027"},{"line_number":121,"context_line":"        ),"},{"line_number":122,"context_line":"    ),"},{"line_number":123,"context_line":"    cfg.IntOpt("},{"line_number":124,"context_line":"        \u0027retry_interval\u0027,"},{"line_number":125,"context_line":"        default\u003d10,"},{"line_number":126,"context_line":"        help\u003d\u0027Interval between retries of opening a SQL connection.\u0027,"},{"line_number":127,"context_line":"    ),"},{"line_number":128,"context_line":"    cfg.IntOpt("},{"line_number":129,"context_line":"        \u0027max_overflow\u0027,"},{"line_number":130,"context_line":"        default\u003d50,"},{"line_number":131,"context_line":"        help\u003d\u0027If set, use this value for max_overflow with SQLAlchemy.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f14c8a3_f04c495a","side":"PARENT","line":128,"range":{"start_line":114,"start_character":6,"end_line":128,"end_character":15},"updated":"2025-11-18 16:09:39.000000000","message":"IMO we should only deprecate these options and should not drop directly during this cycle.","commit_id":"8c343e58ee88acf56dddc7598d3bab0a2ddede14"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1a9bf385c095c4ee26d706824e08820772765c16","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            \u0027Maximum number of SQL connections to keep open in a pool. \u0027"},{"line_number":112,"context_line":"            \u0027Setting a value of 0 indicates no limit.\u0027"},{"line_number":113,"context_line":"        ),"},{"line_number":114,"context_line":"    ),"},{"line_number":115,"context_line":"    cfg.IntOpt("},{"line_number":116,"context_line":"        \u0027max_retries\u0027,"},{"line_number":117,"context_line":"        default\u003d10,"},{"line_number":118,"context_line":"        help\u003d("},{"line_number":119,"context_line":"            \u0027Maximum number of database connection retries during startup. \u0027"},{"line_number":120,"context_line":"            \u0027Set to -1 to specify an infinite retry count.\u0027"},{"line_number":121,"context_line":"        ),"},{"line_number":122,"context_line":"    ),"},{"line_number":123,"context_line":"    cfg.IntOpt("},{"line_number":124,"context_line":"        \u0027retry_interval\u0027,"},{"line_number":125,"context_line":"        default\u003d10,"},{"line_number":126,"context_line":"        help\u003d\u0027Interval between retries of opening a SQL connection.\u0027,"},{"line_number":127,"context_line":"    ),"},{"line_number":128,"context_line":"    cfg.IntOpt("},{"line_number":129,"context_line":"        \u0027max_overflow\u0027,"},{"line_number":130,"context_line":"        default\u003d50,"},{"line_number":131,"context_line":"        help\u003d\u0027If set, use this value for max_overflow with SQLAlchemy.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da62ca35_2ee8608d","side":"PARENT","line":128,"range":{"start_line":114,"start_character":6,"end_line":128,"end_character":15},"in_reply_to":"92602150_01b2a2ba","updated":"2025-11-20 11:41:45.000000000","message":"I misunderstood what was happening in the previous patch: we are changing the defaults, not removing the functionality entirely. Will address.","commit_id":"8c343e58ee88acf56dddc7598d3bab0a2ddede14"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"1f4eba8ab506a132118e7a45ed45a77f05dbbb45","unresolved":true,"context_lines":[{"line_number":111,"context_line":"            \u0027Maximum number of SQL connections to keep open in a pool. \u0027"},{"line_number":112,"context_line":"            \u0027Setting a value of 0 indicates no limit.\u0027"},{"line_number":113,"context_line":"        ),"},{"line_number":114,"context_line":"    ),"},{"line_number":115,"context_line":"    cfg.IntOpt("},{"line_number":116,"context_line":"        \u0027max_retries\u0027,"},{"line_number":117,"context_line":"        default\u003d10,"},{"line_number":118,"context_line":"        help\u003d("},{"line_number":119,"context_line":"            \u0027Maximum number of database connection retries during startup. \u0027"},{"line_number":120,"context_line":"            \u0027Set to -1 to specify an infinite retry count.\u0027"},{"line_number":121,"context_line":"        ),"},{"line_number":122,"context_line":"    ),"},{"line_number":123,"context_line":"    cfg.IntOpt("},{"line_number":124,"context_line":"        \u0027retry_interval\u0027,"},{"line_number":125,"context_line":"        default\u003d10,"},{"line_number":126,"context_line":"        help\u003d\u0027Interval between retries of opening a SQL connection.\u0027,"},{"line_number":127,"context_line":"    ),"},{"line_number":128,"context_line":"    cfg.IntOpt("},{"line_number":129,"context_line":"        \u0027max_overflow\u0027,"},{"line_number":130,"context_line":"        default\u003d50,"},{"line_number":131,"context_line":"        help\u003d\u0027If set, use this value for max_overflow with SQLAlchemy.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"92602150_01b2a2ba","side":"PARENT","line":128,"range":{"start_line":114,"start_character":6,"end_line":128,"end_character":15},"in_reply_to":"9f14c8a3_f04c495a","updated":"2025-11-18 16:13:50.000000000","message":"yeah I agree on that....","commit_id":"8c343e58ee88acf56dddc7598d3bab0a2ddede14"}],"oslo_db/sqlalchemy/engines.py":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"1f4eba8ab506a132118e7a45ed45a77f05dbbb45","unresolved":true,"context_lines":[{"line_number":200,"context_line":"    pool_timeout\u003dNone,"},{"line_number":201,"context_line":"    sqlite_synchronous\u003dTrue,"},{"line_number":202,"context_line":"    connection_trace\u003dFalse,"},{"line_number":203,"context_line":"    max_retries\u003d10,"},{"line_number":204,"context_line":"    retry_interval\u003d10,"},{"line_number":205,"context_line":"    thread_checkin\u003dTrue,"},{"line_number":206,"context_line":"    logging_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"39c81a2d_39e5766e","line":203,"updated":"2025-11-18 16:13:50.000000000","message":"should we be defaulting this to zero so that the max_retries behavior is turned off by default?    it might change things since some projects may have expectations that the DB is pre-connected somehow","commit_id":"d00849c8bab13a399deb1780b46e0aa1ed09bc6d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d74c75ff483f16ede7b08afbdf541790f02a3623","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    pool_timeout\u003dNone,"},{"line_number":201,"context_line":"    sqlite_synchronous\u003dTrue,"},{"line_number":202,"context_line":"    connection_trace\u003dFalse,"},{"line_number":203,"context_line":"    max_retries\u003d10,"},{"line_number":204,"context_line":"    retry_interval\u003d10,"},{"line_number":205,"context_line":"    thread_checkin\u003dTrue,"},{"line_number":206,"context_line":"    logging_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"159008dd_783102e3","line":203,"in_reply_to":"39c81a2d_39e5766e","updated":"2025-11-20 11:52:21.000000000","message":"Done","commit_id":"d00849c8bab13a399deb1780b46e0aa1ed09bc6d"}]}
