)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b716efd50372545142195072286820fa20c10541","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de2978c7_7b522203","updated":"2025-11-24 16:18:59.000000000","message":"I\u0027m against adding that config option to allow users to inject arbitrary code. In case any applications using this library requires such hook then they can implement their own hook code and register the hooks using append_on_engine_create .\n\nIf we are aware of any hook which may be widely useful then we should add it to oslo.db.","commit_id":"7a2b76d5a326655b80b020736158d1a0583d21f6"},{"author":{"_account_id":29525,"name":"Artem Vasilyev","email":"artem.v.vasilyev@gmail.com","username":"artem.v.vasilyev"},"change_message_id":"8484d7ccd77406025a121470348264ef0ca38151","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b4761bb2_14ada694","updated":"2025-11-24 15:18:13.000000000","message":"recheck oslodb-tox-py313-tips","commit_id":"7a2b76d5a326655b80b020736158d1a0583d21f6"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"81d6aa694b6287aeca660ff6bce97aba568c1dd9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f5ff19f6_2b2a91ba","in_reply_to":"de2978c7_7b522203","updated":"2025-11-24 17:15:02.000000000","message":"Agree, instead of having\n\n    [database]\n    on_engine_create \u003d some.package.sqlalchemy_swimming_pool\n    \nit should be on the application to curate the plugins it supports:\n\n    [nifty-tool]\n    enable_db_swimming_pool \u003d true\n    \ncurious though what plugins we\u0027re talking about.   I assume I added this on_engine_create hook in the first place, however I believe it would have been to support this very specific sqlalchemy-collectd plugin I was working on, for which I used the second approach above to integrate.","commit_id":"7a2b76d5a326655b80b020736158d1a0583d21f6"},{"author":{"_account_id":29525,"name":"Artem Vasilyev","email":"artem.v.vasilyev@gmail.com","username":"artem.v.vasilyev"},"change_message_id":"30680df419d1a83bd98cd8afbb56d11eab810590","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d8904765_e4980528","in_reply_to":"f5ff19f6_2b2a91ba","updated":"2025-11-25 09:35:05.000000000","message":"My motivation was to avoid having to\nmanually register our third-party metrics hook in every OpenStack service\nand instead have a configuration option to do it. Given the feedback I agree to abandon this change.","commit_id":"7a2b76d5a326655b80b020736158d1a0583d21f6"}]}