)]}'
{"oslo/db/sqlalchemy/session.py":[{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"d0ff9d2fa6764486b6bf3b0d02008c25887351e4","unresolved":false,"context_lines":[{"line_number":728,"context_line":"    \"\"\""},{"line_number":729,"context_line":"    import traceback"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    import MySQLdb.cursors"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"    old_mysql_do_query \u003d MySQLdb.cursors.BaseCursor._do_query"},{"line_number":734,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_6716905a","line":731,"updated":"2014-06-16 12:33:42.000000000","message":"If we are fixing all the wrong grouped imports, I have a question. Why are this imports inside the function at 7xx lines? Is it impossible to group it at beginning of the module?","commit_id":"308873d3df6bed9d811bbabfcbb4fc117549bdf6"},{"author":{"_account_id":8041,"name":"Petr Blaho","email":"pblaho@redhat.com","username":"pblaho"},"change_message_id":"349603885ea01955618d3bda0281bb0b0045e7a5","unresolved":false,"context_lines":[{"line_number":728,"context_line":"    \"\"\""},{"line_number":729,"context_line":"    import traceback"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    import MySQLdb.cursors"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"    old_mysql_do_query \u003d MySQLdb.cursors.BaseCursor._do_query"},{"line_number":734,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_6515a3e4","line":731,"in_reply_to":"1ae5cdf2_6716905a","updated":"2014-06-16 14:46:28.000000000","message":"I was not sure about the original intention with importing these modules in this place so I just solved pep8 issue by separating these lines.\n\nIn the next patch I moved these imports to the corresponding groups in the beginning of the module.\n\nConsider it done.","commit_id":"308873d3df6bed9d811bbabfcbb4fc117549bdf6"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"85d01a6ea8fea3e952ea10d32fc09b874d04b9eb","unresolved":false,"context_lines":[{"line_number":726,"context_line":""},{"line_number":727,"context_line":"    Patches MySQLdb.cursors.BaseCursor._do_query."},{"line_number":728,"context_line":"    \"\"\""},{"line_number":729,"context_line":"    import MySQLdb.cursors"},{"line_number":730,"context_line":"    import traceback"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"    old_mysql_do_query \u003d MySQLdb.cursors.BaseCursor._do_query"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_0094cd8a","side":"PARENT","line":729,"updated":"2014-06-16 14:52:15.000000000","message":"I believe this import was intentionally put here, so that we don\u0027t impose MySQLdb as a runtime dependency, if e.g. psql+psycopg2 is used.","commit_id":"455b47168f8a09e62f9ffe4d74d26d60d44eea5f"}],"tests/sqlalchemy/test_utils.py":[{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"d0ff9d2fa6764486b6bf3b0d02008c25887351e4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import uuid"},{"line_number":17,"context_line":"import warnings"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import fixtures"},{"line_number":20,"context_line":"from migrate.changeset import UniqueConstraint"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"from oslotest import base as test_base"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_62359ea7","line":19,"updated":"2014-06-16 12:33:42.000000000","message":"At least for now this is an inappropriate change. I see several ways to solve this discrepancy:\n\n* Describe the change wider, without binding to `oslo.config` naming bug.\n* Create two dependent patches, one for oslo.config naming problem solvation and one for really wrong grouped imports.","commit_id":"308873d3df6bed9d811bbabfcbb4fc117549bdf6"},{"author":{"_account_id":8041,"name":"Petr Blaho","email":"pblaho@redhat.com","username":"pblaho"},"change_message_id":"349603885ea01955618d3bda0281bb0b0045e7a5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import uuid"},{"line_number":17,"context_line":"import warnings"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import fixtures"},{"line_number":20,"context_line":"from migrate.changeset import UniqueConstraint"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"from oslotest import base as test_base"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_e5a2934a","line":19,"in_reply_to":"1ae5cdf2_62359ea7","updated":"2014-06-16 14:46:28.000000000","message":"I choose to not mention oslo.config naming problem directly in commit message but I still left comment w/r/t to it in code.\n\nSee in next version of patch.","commit_id":"308873d3df6bed9d811bbabfcbb4fc117549bdf6"}],"tests/test_api.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"9bbf6ec5d738b60835dcad233a187839454a25c2","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":"from oslo.db import api"},{"line_number":22,"context_line":"from oslo.db import exception"},{"line_number":23,"context_line":"from oslo.db.openstack.common import importutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1e000eaa","line":20,"updated":"2014-06-12 15:14:17.000000000","message":"this not required","commit_id":"76988ce7387d4952305cf3e827a72a0c73ceb04c"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"9eb3dffdf9193631f3a2af79ecfc9d1ae44cce2e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# hacking is confused with oslo.* namespace"},{"line_number":20,"context_line":"# see https://bugs.launchpad.net/hacking/+bug/1329363"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"from oslo.config import cfg  # noqa"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo.db import api"},{"line_number":25,"context_line":"from oslo.db import exception"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_97ca3b6c","line":22,"updated":"2014-07-21 13:09:17.000000000","message":"I believe, if we remove hackings we want to fix unmatched lines, but not  produce new #noqa\u0027s.","commit_id":"988b7355d00d1ce6e9ddebeb1ca7a7aa36c0a66a"}],"tests/utils.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"9bbf6ec5d738b60835dcad233a187839454a25c2","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslotest import base as test_base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo.config import cfg"},{"line_number":19,"context_line":"from oslo.db.openstack.common.fixture import moxstubout"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_5e0616cf","line":18,"updated":"2014-06-12 15:14:17.000000000","message":"this not required","commit_id":"76988ce7387d4952305cf3e827a72a0c73ceb04c"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"1233da6dd355270da78b955fa74e0947b9c73410","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# needs to noqa oslo.config import"},{"line_number":17,"context_line":"# hacking is confused with oslo.* namespace"},{"line_number":18,"context_line":"# see https://bugs.launchpad.net/hacking/+bug/1329363"},{"line_number":19,"context_line":"from oslo.config import cfg  # noqa"},{"line_number":20,"context_line":"from oslotest import base as test_base  # noqa"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_1565d844","line":18,"updated":"2014-07-09 15:42:54.000000000","message":"hm... Maybe we should leave this rule skipped in tox.ini and add TODO with detailed description there?","commit_id":"988b7355d00d1ce6e9ddebeb1ca7a7aa36c0a66a"},{"author":{"_account_id":8041,"name":"Petr Blaho","email":"pblaho@redhat.com","username":"pblaho"},"change_message_id":"7c4d88e7db4d23787e9cb4080b01b0dfddea72ee","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# needs to noqa oslo.config import"},{"line_number":17,"context_line":"# hacking is confused with oslo.* namespace"},{"line_number":18,"context_line":"# see https://bugs.launchpad.net/hacking/+bug/1329363"},{"line_number":19,"context_line":"from oslo.config import cfg  # noqa"},{"line_number":20,"context_line":"from oslotest import base as test_base  # noqa"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_16e474a6","line":18,"in_reply_to":"baada198_1565d844","updated":"2014-08-03 14:22:17.000000000","message":"Done","commit_id":"988b7355d00d1ce6e9ddebeb1ca7a7aa36c0a66a"}]}