)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"acab3a34da8f1a1bd2c215a27c5069dc03d3bea9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"01e90178_303faa53","updated":"2023-02-17 11:48:05.000000000","message":"These test failures are real. We\u0027ve got mocks of getdefaultlocale which need to be updated. The replacement suggested also feels slightly reductive. Looking at the logic for \u0027getdefaultlocale\u0027 [1], I see use trying multiple envvars. Shouldn\u0027t we be doing the same thing here?\n\n[1] https://github.com/python/cpython/blob/3.11/Lib/locale.py#L534","commit_id":"721dd76cb9a99973ae45cf5ff0e1e2f052281150"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"2ee7d25f604da37dbafad541fbb031ae45a9fdd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"83271939_08a41fff","in_reply_to":"01e90178_303faa53","updated":"2023-03-09 02:17:11.000000000","message":"I think the mechanism of checking environment variables is still present. It\u0027s the difference between looking at the environment (which can be set in any way by the external forces) and looking at the properties of the library. The theory is, the library examines the Linux environment variables on startup, then constructs its state accordingly. This is why it lacks a LANG attribute: the LANG env is parsed into a bunch of LC_xxx attributes. Because we do not parse environment ourselves, fallback is not needed. At least this is how I understand it.\n\nI adjusted the tests, sorry about that.","commit_id":"721dd76cb9a99973ae45cf5ff0e1e2f052281150"}]}