)]}'
{"oslo_limit/limit.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"f2f478cd70f87db67f27931989a4787e53641f70","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    connection \u003d _get_keystone_connection()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    endpoint_id \u003d CONF.oslo_limit.endpoint_id"},{"line_number":56,"context_line":"    service_name \u003d CONF.oslo_limit.service_name"},{"line_number":57,"context_line":"    region_name \u003d CONF.oslo_limit.region_name"},{"line_number":58,"context_line":"    if endpoint_id:"},{"line_number":59,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_ca638841","line":56,"updated":"2020-05-15 21:49:09.000000000","message":"Could be done in a later change but maybe we want to support searching by service type too?","commit_id":"a2f35e9fe81cb669d554af1e6c6743a3ea6f3c43"},{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"afd38919404d0a65bfef50929ff307c830aa6540","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    connection \u003d _get_keystone_connection()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    endpoint_id \u003d CONF.oslo_limit.endpoint_id"},{"line_number":56,"context_line":"    service_name \u003d CONF.oslo_limit.service_name"},{"line_number":57,"context_line":"    region_name \u003d CONF.oslo_limit.region_name"},{"line_number":58,"context_line":"    if endpoint_id:"},{"line_number":59,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_85f3b373","line":56,"in_reply_to":"ff570b3c_ca638841","updated":"2020-05-23 15:22:59.000000000","message":"Done","commit_id":"a2f35e9fe81cb669d554af1e6c6743a3ea6f3c43"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"4ed34e0c7f687a8c564516933e65f83129b8de2e","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    endpoint_id \u003d CONF.oslo_limit.endpoint_id"},{"line_number":56,"context_line":"    service_name \u003d CONF.oslo_limit.service_name"},{"line_number":57,"context_line":"    region_name \u003d CONF.oslo_limit.region_name"},{"line_number":58,"context_line":"    if endpoint_id:"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            endpoint \u003d connection.get_endpoint(endpoint_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_97dfa20b","line":57,"updated":"2020-05-20 17:40:42.000000000","message":"These name opts are not defined in oslo.limit. I assume they\u0027re being registered by keystoneauth. Is it safe for us to reference them in our code? My concern is that if they were ever to be renamed, the oslo.config deprecation mechanism doesn\u0027t protect in-code references, only the user-visible references in config files.","commit_id":"a2f35e9fe81cb669d554af1e6c6743a3ea6f3c43"},{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"afd38919404d0a65bfef50929ff307c830aa6540","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    endpoint_id \u003d CONF.oslo_limit.endpoint_id"},{"line_number":56,"context_line":"    service_name \u003d CONF.oslo_limit.service_name"},{"line_number":57,"context_line":"    region_name \u003d CONF.oslo_limit.region_name"},{"line_number":58,"context_line":"    if endpoint_id:"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            endpoint \u003d connection.get_endpoint(endpoint_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_05096330","line":57,"in_reply_to":"ff570b3c_7878fa8e","updated":"2020-05-23 15:22:59.000000000","message":"Indeed, I think it come from the fixture, as if I declare service_name/server_type option in oslo_limit, test fail with a duplicate option issue, I need to deep dive this thing.","commit_id":"a2f35e9fe81cb669d554af1e6c6743a3ea6f3c43"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"37704a978d81e056c6a324405959d6199e9200bc","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    endpoint_id \u003d CONF.oslo_limit.endpoint_id"},{"line_number":56,"context_line":"    service_name \u003d CONF.oslo_limit.service_name"},{"line_number":57,"context_line":"    region_name \u003d CONF.oslo_limit.region_name"},{"line_number":58,"context_line":"    if endpoint_id:"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            endpoint \u003d connection.get_endpoint(endpoint_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_a83083a0","line":57,"in_reply_to":"ff570b3c_97dfa20b","updated":"2020-05-20 18:47:56.000000000","message":"Hmm, no they\u0027re supposed to be registered by oslo.limit here: https://opendev.org/openstack/oslo.limit/src/branch/master/oslo_limit/opts.py#L27-L35\n\nMakes me more confused that this is passing unit tests.","commit_id":"a2f35e9fe81cb669d554af1e6c6743a3ea6f3c43"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"f2fc505f5e50e942dfd79eae11023b9f507703bf","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    endpoint_id \u003d CONF.oslo_limit.endpoint_id"},{"line_number":56,"context_line":"    service_name \u003d CONF.oslo_limit.service_name"},{"line_number":57,"context_line":"    region_name \u003d CONF.oslo_limit.region_name"},{"line_number":58,"context_line":"    if endpoint_id:"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            endpoint \u003d connection.get_endpoint(endpoint_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_7878fa8e","line":57,"in_reply_to":"ff570b3c_a83083a0","updated":"2020-05-20 21:27:32.000000000","message":"That\u0027s...extremely confusing. I assumed they must have been registered by _something_ since the tests do seem to be calling this code. Then I thought maybe the config fixture was somehow hiding the missing opts, but it sure looks to me like that should fail too. :-/","commit_id":"a2f35e9fe81cb669d554af1e6c6743a3ea6f3c43"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"4ed34e0c7f687a8c564516933e65f83129b8de2e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                             \"endpoint_id in oslo_limit configuration\""},{"line_number":69,"context_line":"                             % (len(services), service_name))"},{"line_number":70,"context_line":"        return (services.pop().id, region_name)"},{"line_number":71,"context_line":"    raise ValueError(\"No endpoint_id or service_name/region_name \""},{"line_number":72,"context_line":"                     \"defined in oslo_limit configuration\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_5747cabc","line":71,"updated":"2020-05-20 17:40:42.000000000","message":"Not a big deal, but I wonder if we should also have a warning if they set both endpoint_id and the _name opts. The behavior is well-defined in that case, but it\u0027s probably not what they meant to do.","commit_id":"a2f35e9fe81cb669d554af1e6c6743a3ea6f3c43"},{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"afd38919404d0a65bfef50929ff307c830aa6540","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                             \"endpoint_id in oslo_limit configuration\""},{"line_number":69,"context_line":"                             % (len(services), service_name))"},{"line_number":70,"context_line":"        return (services.pop().id, region_name)"},{"line_number":71,"context_line":"    raise ValueError(\"No endpoint_id or service_name/region_name \""},{"line_number":72,"context_line":"                     \"defined in oslo_limit configuration\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_250c6741","line":71,"in_reply_to":"ff570b3c_5747cabc","updated":"2020-05-23 15:22:59.000000000","message":"Done","commit_id":"a2f35e9fe81cb669d554af1e6c6743a3ea6f3c43"}]}