)]}'
{"id":"openstack%2Foslo.limit~726929","triplet_id":"openstack%2Foslo.limit~master~I1ccf40d4456d5afcfbe65f826d14b16142cfc2d9","project":"openstack/oslo.limit","branch":"master","topic":"bug/1835106","hashtags":[],"change_id":"I1ccf40d4456d5afcfbe65f826d14b16142cfc2d9","subject":"Allow configuration per service and region name","status":"ABANDONED","created":"2020-05-11 19:07:47.000000000","updated":"2024-10-27 05:01:17.000000000","total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4921dd8e7f8b3ab09129d8757bed84f8da17a389","_number":726929,"virtual_id_number":726929,"owner":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-07-15 14:11:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-20 21:48:19.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"},{"updated":"2020-07-10 15:46:32.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"},{"updated":"2020-07-15 14:11:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ed3503161ab9a2330fb4a8f1defd64f663894d8a","author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"date":"2020-05-11 19:07:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"03dbf0b21c12445712d7bed4665e3c6b11e16762","author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"date":"2020-05-11 19:08:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e2c248dabef971c1cdb6cbfef9eee716ef1702d8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-11 20:39:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/9010ba7d7ba8453987517df21d7fa676 : SUCCESS in 1h 29m 01s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/02d505c7b2154e0fb335615daf2ee5c1 : SUCCESS in 5m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/12434d3999704374af72bce3a0c3dc76 : SUCCESS in 4m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/642520d97b6d4b8e9e360cdff988d8a4 : SUCCESS in 3m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/45bba051a6544683ad1cda421cf51d4b : SUCCESS in 5m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2dff57306ec4469eb695f548c03c30a1 : SUCCESS in 9m 32s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/076b727da17c4e65a83c7a90a24914c5 : SUCCESS in 3m 32s\n- oslo-limit-functional-devstack https://zuul.opendev.org/t/openstack/build/f475d5343df44829a930a5a8e9656c9a : SUCCESS in 32m 42s","accounts_in_message":[],"_revision_number":2},{"id":"f2f478cd70f87db67f27931989a4787e53641f70","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2020-05-15 21:49:09.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8f475153e638689447a44ac24b49621ec2ca0a4a","author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"date":"2020-05-16 12:03:30.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a3bf4480888b65cc1d7315cd2270e94f5a66affe","author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"date":"2020-05-16 12:05:29.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"387c94fbd6ba9186ece900bd6dec2c44a126f42a","author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"date":"2020-05-16 12:07:41.000000000","message":"Patch Set 4:\n\nJust note that this patch (https://review.opendev.org/#/c/726621/) need to be merged in the SDK in order to filter services by name, should I need to update the lower-constraints then ?","accounts_in_message":[],"_revision_number":4},{"id":"423bb6db70be3ac974bf13a8268a193da9a1da8b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-16 13:22:11.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/e427a67cc0f543d880ec489269fa83e7 : SUCCESS in 1h 16m 17s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/da6433c77bf44a68b0d0222db4c413c4 : SUCCESS in 3m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9d749ca643254c01b0953ec618cd6eb1 : SUCCESS in 3m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/261e87c0bd3d486c9531a643c5cacf88 : SUCCESS in 3m 29s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6d734cb635c34719ae71c76899a81fad : SUCCESS in 4m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9c2cf5ec8e174092a0ff730ba3c081c2 : SUCCESS in 3m 56s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/87c0ed84e5ac429d8286c9bd7ece6f05 : SUCCESS in 3m 12s\n- oslo-limit-functional-devstack https://zuul.opendev.org/t/openstack/build/9493160a46194cc39fb718aa9a626c87 : SUCCESS in 24m 55s","accounts_in_message":[],"_revision_number":4},{"id":"7626621f7b1528340dcf6ccde716413dbd5adc3e","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2020-05-19 20:45:35.000000000","message":"Patch Set 4:\n\n\u003e Just note that this patch (https://review.opendev.org/#/c/726621/)\n \u003e need to be merged in the SDK in order to filter services by name,\n \u003e should I need to update the lower-constraints then ?\n\nYou should add \"Depends-on: https://review.opendev.org/726621\" in the commit message to make it clear that there\u0027s a relationship between these and to prevent zuul from merging this one before the other. In reality this won\u0027t be able to take advantage of the sdk change until there\u0027s a new release of sdk containing that change.\n\nThe fact that this is passing tests even though it depends on an unmerged patch in another library is a little concerning to me, it makes it seem like perhaps the tests here are over-mocked. It might be better to let the other tests serve as an example and only mock out the sdk connection and return values but still exercise the sdk functions.","accounts_in_message":[],"_revision_number":4},{"id":"4ed34e0c7f687a8c564516933e65f83129b8de2e","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2020-05-20 17:40:42.000000000","message":"Patch Set 4:\n\n(2 comments)\n\nOops, left my inline comments on an old PS. I think they\u0027re still valid now though.\n\nI\u0027m okay with the mocking - it\u0027s happening on the boundary between oslo.limit and the external library that we call. Ideally we don\u0027t want to mock things that are called from code we don\u0027t control, which I think is what would happen if we called the real sdk functions. Maybe there\u0027s a way to do it so that we aren\u0027t reliant on sdk implementation details though.\n\nI think the issue is that we have no functional testing in this repo that would exercise the external library. We can get that either by writing explicit functional tests against an actual Keystone, or get it somewhat for free by running Tempest once someone has adopted oslo.limit. Obviously functional tests are preferred since we don\u0027t want to wait to test this properly until after someone is already using it, but I realize that\u0027s a non-trivial amount of work.","accounts_in_message":[],"_revision_number":4},{"id":"37704a978d81e056c6a324405959d6199e9200bc","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2020-05-20 18:47:56.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f2fc505f5e50e942dfd79eae11023b9f507703bf","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2020-05-20 21:27:32.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nThere are quite a few opts appearing in the oslo_limit group that we didn\u0027t register here: {\u0027cafile\u0027: None, \u0027certfile\u0027: None, \u0027keyfile\u0027: None, \u0027insecure\u0027: False, \u0027timeout\u0027: None, \u0027collect_timing\u0027: False, \u0027split_loggers\u0027: False, \u0027service_type\u0027: \u0027my_service_type\u0027, \u0027service_name\u0027: \u0027my_service\u0027, \u0027valid_interfaces\u0027: None, \u0027region_name\u0027: \u0027my_region\u0027, \u0027endpoint_override\u0027: None, \u0027version\u0027: None, \u0027min_version\u0027: None, \u0027max_version\u0027: None, \u0027connect_retries\u0027: None, \u0027connect_retry_delay\u0027: None, \u0027status_code_retries\u0027: None, \u0027status_code_retry_delay\u0027: None, \u0027auth_section\u0027: None, \u0027auth_type\u0027: None, \u0027endpoint_id\u0027: None}\n\nShould https://github.com/openstack/oslo.limit/blob/master/oslo_limit/limit.py#L34 be loading from the olso_limit group or should that be using keystone_authtoken? I\u0027m wondering if this is part of the dynamic opt registration from ksa.","accounts_in_message":[],"_revision_number":4},{"id":"8373d6b4e268cc0de9c50a04fb04576a031cead5","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2020-05-20 21:48:19.000000000","message":"Patch Set 4:\n\n\u003e (1 comment)\n \u003e \n \u003e There are quite a few opts appearing in the oslo_limit group that\n \u003e we didn\u0027t register here: {\u0027cafile\u0027: None, \u0027certfile\u0027: None,\n \u003e \u0027keyfile\u0027: None, \u0027insecure\u0027: False, \u0027timeout\u0027: None,\n \u003e \u0027collect_timing\u0027: False, \u0027split_loggers\u0027: False, \u0027service_type\u0027:\n \u003e \u0027my_service_type\u0027, \u0027service_name\u0027: \u0027my_service\u0027, \u0027valid_interfaces\u0027:\n \u003e None, \u0027region_name\u0027: \u0027my_region\u0027, \u0027endpoint_override\u0027: None,\n \u003e \u0027version\u0027: None, \u0027min_version\u0027: None, \u0027max_version\u0027: None,\n \u003e \u0027connect_retries\u0027: None, \u0027connect_retry_delay\u0027: None,\n \u003e \u0027status_code_retries\u0027: None, \u0027status_code_retry_delay\u0027: None,\n \u003e \u0027auth_section\u0027: None, \u0027auth_type\u0027: None, \u0027endpoint_id\u0027: None}\n\nThis are all registered by keystoneauth, from the auth and session options defined in the loading modules here:\n\nhttps://opendev.org/openstack/keystoneauth/src/branch/master/keystoneauth1/loading\n\nThese are all for configuring how the service user authenticates to keystone and for discovering information about the service endpoints in the keystone catalog.\n\n \u003e \n \u003e Should https://github.com/openstack/oslo.limit/blob/master/oslo_limit/limit.py#L34\n \u003e be loading from the olso_limit group or should that be using\n \u003e keystone_authtoken?\n\nkeystone_authtoken is specific to keystonemiddleware, it should not be reused here.\n\n \u003e I\u0027m wondering if this is part of the dynamic\n \u003e opt registration from ksa.\n\nYeah, so it seems like the fact that we\u0027re loading keystoneauth options under [oslo_limit] is why these options are already available here. However, that\u0027s not what they\u0027re for. The options from keystoneauth are meant for authentication and discovery. But the endpoint_id option that\u0027s already in oslo.limit is meant for gathering registered limit data for that endpoint. Similarly, the service_name/type and region options being added in this patch are for querying registered limit data, whereas the options by the same name in keystoneauth are for catalog discovery. I\u0027m really not sure whether it\u0027s best to reuse them (oslo.limit isn\u0027t going to use them for discovery anyway) or register new options with different names. Creating a new not-keystone_authtoken section just for auth isn\u0027t ideal because really a service that wants to use oslo.limit should only need to configure the [oslo_limit] section.","accounts_in_message":[],"_revision_number":4},{"id":"de1d51fc9142467007b3a43bfb3cf6e1450ba76e","author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"date":"2020-05-23 15:13:29.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"afd38919404d0a65bfef50929ff307c830aa6540","author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"date":"2020-05-23 15:22:59.000000000","message":"Patch Set 2:\n\n(3 comments)\n\n\u003e Yeah, so it seems like the fact that we\u0027re loading keystoneauth\n \u003e options under [oslo_limit] is why these options are already\n \u003e available here. However, that\u0027s not what they\u0027re for. The options\n \u003e from keystoneauth are meant for authentication and discovery. But\n \u003e the endpoint_id option that\u0027s already in oslo.limit is meant for\n \u003e gathering registered limit data for that endpoint. Similarly, the\n \u003e service_name/type and region options being added in this patch are\n \u003e for querying registered limit data, whereas the options by the same\n \u003e name in keystoneauth are for catalog discovery. I\u0027m really not sure\n \u003e whether it\u0027s best to reuse them (oslo.limit isn\u0027t going to use them\n \u003e for discovery anyway) or register new options with different names.\n \u003e Creating a new not-keystone_authtoken section just for auth isn\u0027t\n \u003e ideal because really a service that wants to use oslo.limit should\n \u003e only need to configure the [oslo_limit] section.\n\nI think that using option from ksa is ok, as in this context, these options looks like catalog discovery, not really querying registered limit itself. The goal of these option here is only to get an endpoint_id for after, query registered limits.","accounts_in_message":[],"_revision_number":2},{"id":"1303cd5bb6f7d755cf40e6f9dfbd8a75a63a5e3a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-23 16:37:06.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/3f95f0be493f47d5be01f6bd72c88ea2 : SUCCESS in 1h 18m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d2a2efb15ee54937b3d3505311b7888e : SUCCESS in 4m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1207cac889ae4f8ea2e9251cd0d0cd4e : SUCCESS in 3m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/be0b2b53b9e5471fb5c6fb4200d2b42f : SUCCESS in 3m 57s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/50a902f6e0f24d109655de7cf4b54cee : SUCCESS in 4m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1ab5476ff0234015bd6eb1b250333a90 : SUCCESS in 3m 54s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d992cd6628cf422eaf9d1022ec673fb0 : SUCCESS in 3m 05s\n- oslo-limit-functional-devstack https://zuul.opendev.org/t/openstack/build/e645eb4b41e14bc8979461fd5ff04a5e : SUCCESS in 24m 34s","accounts_in_message":[],"_revision_number":5},{"id":"c4e58ca49e6f3fee7903cc654b91475ad6ae3d00","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2020-06-05 20:49:11.000000000","message":"Patch Set 5: Code-Review-1\n\nWe can\u0027t use opts registered by another library. They aren\u0027t considered a stable interface and if they get changed it will break us. The only way we could reuse those is if keystoneauth provided a stable API we could query to get them, but I\u0027m not sure that\u0027s desirable (or even possible).\n\nIn any case, I pushed https://review.opendev.org/733881 to move the ksa opts to oslo_limit_keystoneauth. Then we can define our own service/region opts in oslo_limit and everything should work as intended.","accounts_in_message":[],"_revision_number":5},{"id":"5a2d8412777bb75f9ae0d14854176f7492c79c0c","author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"date":"2020-06-20 11:43:25.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"686d0ee23833a5383d2789087ac585543059e296","author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"date":"2020-06-20 11:46:33.000000000","message":"Patch Set 6:\n\n\u003e We can\u0027t use opts registered by another library. They aren\u0027t\n \u003e considered a stable interface and if they get changed it will break\n \u003e us. The only way we could reuse those is if keystoneauth provided a\n \u003e stable API we could query to get them, but I\u0027m not sure that\u0027s\n \u003e desirable (or even possible).\n \u003e \n \u003e In any case, I pushed https://review.opendev.org/733881 to move the\n \u003e ksa opts to oslo_limit_keystoneauth. Then we can define our own\n \u003e service/region opts in oslo_limit and everything should work as\n \u003e intended.\n\nI propose to rename the used service name/type options to specific \"enforcer_service_name/enforcer_service_type/enforcer_region_name\", it will then allow operator to only use 1 section and save us from a breaking change if we move ksa option to another section.","accounts_in_message":[],"_revision_number":6},{"id":"32e1730ceeddf3fb0dd58598777e0de6aceaa54a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-20 13:17:57.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/2a612cc3ed3d4eee9c0214ccb1e64bbe : SUCCESS in 2m 21s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b9e3a7f8228e453bace50cb823d04dd5 : SUCCESS in 1h 29m 36s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1ec21b47c76a435492fd4cc9c77356f5 : SUCCESS in 3m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e13dc35db69e4a51811139aa7323aafc : SUCCESS in 3m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a448aa3b6ef74661b7e23d2c2515fb58 : SUCCESS in 3m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c6a275cbe8e848d2a7cb00a6780d491b : SUCCESS in 4m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/521ff604aea3453aba061dcabba9909f : SUCCESS in 3m 47s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d2f733e5f9c94db08b35964d5deb2b4e : SUCCESS in 3m 32s\n- oslo-limit-functional-devstack https://zuul.opendev.org/t/openstack/build/917d53e21c2949739af2c2f5c8e9afd1 : SUCCESS in 25m 56s","accounts_in_message":[],"_revision_number":6},{"id":"9325a191864676ea8494d315da9c2847544d04b7","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2020-07-10 15:46:32.000000000","message":"Patch Set 6: Code-Review-1\n\nThis also works, but after some more thought I\u0027d still prefer to move the ksa opts. The reason being that they are dynamically generated at runtime, which means the oslo-config-validator tool can\u0027t validate them so you have to omit the entire group from validation. If we register them in the oslo_limit group then none of the other oslo.limit opts can be validated either. If they\u0027re in a separate group then only the ksa opts go unvalidated.\n\nAnd as I noted in my other review, we don\u0027t have to worry about breaking changes in oslo.limit right now. This is the period of development where we are allowed to make breaking changes in order to come up with a solid design for the library (technically 1.0 got released, but that was an accident and doesn\u0027t reflect the actual state of the library).","accounts_in_message":[],"_revision_number":6},{"id":"64cdb33b4d2cdfb9ab9ce2fd3f5b755fc03678f6","author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"date":"2020-07-15 12:57:28.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"31c7634c104a07a53d903676d7dd47325afa346d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-15 14:11:40.000000000","message":"Patch Set 7: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/b6b83ecfd3e341579e3bae2d595fbe6f : SUCCESS in 4m 13s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/68cf4fdaa4b84e589d0d3128e7f6c6da : SUCCESS in 56m 36s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d952efec257e4281a010cadf1e54e87a : FAILURE in 4m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/10aa51c28a104378a5684736c65348ac : SUCCESS in 4m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/242f32949c18457a82959008c6a9084f : FAILURE in 3m 57s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/250d163028bf43da81c2207af1ba92ca : FAILURE in 4m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e1f56273067e429cbb0960f40a2f305f : FAILURE in 4m 32s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6009c9806c3e49e69133479c5a9faab0 : SUCCESS in 6m 05s\n- oslo-limit-functional-devstack https://zuul.opendev.org/t/openstack/build/7a0d638d32c54bff998f7699fc70c4e4 : SUCCESS in 34m 05s","accounts_in_message":[],"_revision_number":7},{"id":"d90a67959261fcc155565650d8b08a6c214bcb82","author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"date":"2021-06-22 16:06:57.000000000","message":"Patch Set 7:\n\nrecheck","accounts_in_message":[],"_revision_number":7},{"id":"a8c3fc83625037b41561da5490588eab750c6f47","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-22 16:07:31.000000000","message":"Patch Set 7:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":7},{"id":"4921dd8e7f8b3ab09129d8757bed84f8da17a389","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2024-10-27 05:01:17.000000000","message":"Abandoned\n\nThis was achieved by https://review.opendev.org/c/openstack/oslo.limit/+/914783","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"adc1d3ed273f23ba0334350d6b00acf06b9f69ea","revisions":{"2df0faa05caf648e62ee9df290e68a374652c719":{"kind":"REWORK","_number":1,"created":"2020-05-11 19:07:47.000000000","uploader":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"ref":"refs/changes/29/726929/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.limit","ref":"refs/changes/29/726929/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/1"}}},"commit":{"parents":[{"commit":"3b5a820db3cb51224c482123f2e40b74e460b5ab","subject":"Add Python3 victoria unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/3b5a820db3cb51224c482123f2e40b74e460b5ab"}]}],"author":{"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","date":"2020-05-11 07:58:01.000000000","tz":0},"committer":{"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","date":"2020-05-11 19:07:36.000000000","tz":0},"subject":"Allow configuration per service and region name","message":"Allow configuration per service and region name\n\nCurrently oslo_limit only allow configuration per endpoint_id.\nThis commit allow configuration per service and region name in\norder to ease the generation of configuration file for deployer.\n\nIn both endpoint_id and service/region name are specified,\nendpoint_id preceed.\n\nCloses-Bug: #1835106\nChange-Id: I1ccf40d4456d5afcfbe65f826d14b16142cfc2d9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/2df0faa05caf648e62ee9df290e68a374652c719"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/2df0faa05caf648e62ee9df290e68a374652c719"}]},"branch":"refs/heads/master"},"a2f35e9fe81cb669d554af1e6c6743a3ea6f3c43":{"kind":"REWORK","_number":2,"created":"2020-05-11 19:08:43.000000000","uploader":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"ref":"refs/changes/29/726929/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.limit","ref":"refs/changes/29/726929/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/2"}}},"commit":{"parents":[{"commit":"3b5a820db3cb51224c482123f2e40b74e460b5ab","subject":"Add Python3 victoria unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/3b5a820db3cb51224c482123f2e40b74e460b5ab"}]}],"author":{"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","date":"2020-05-11 07:58:01.000000000","tz":0},"committer":{"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","date":"2020-05-11 19:08:36.000000000","tz":0},"subject":"Allow configuration per service and region name","message":"Allow configuration per service and region name\n\nCurrently oslo_limit only allow configuration per endpoint_id.\nThis commit allow configuration per service and region name in\norder to ease the generation of configuration file for deployer.\n\nIn both endpoint_id and service/region name are specified,\nendpoint_id preceed.\n\nCloses-Bug: #1835106\nChange-Id: I1ccf40d4456d5afcfbe65f826d14b16142cfc2d9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/a2f35e9fe81cb669d554af1e6c6743a3ea6f3c43"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/a2f35e9fe81cb669d554af1e6c6743a3ea6f3c43"}]},"branch":"refs/heads/master"},"27ca3d274728429dee16454698234269199c36ff":{"kind":"REWORK","_number":3,"created":"2020-05-16 12:03:30.000000000","uploader":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"ref":"refs/changes/29/726929/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.limit","ref":"refs/changes/29/726929/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/3"}}},"commit":{"parents":[{"commit":"3b5a820db3cb51224c482123f2e40b74e460b5ab","subject":"Add Python3 victoria unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/3b5a820db3cb51224c482123f2e40b74e460b5ab"}]}],"author":{"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","date":"2020-05-11 07:58:01.000000000","tz":0},"committer":{"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","date":"2020-05-16 12:02:48.000000000","tz":0},"subject":"Allow configuration per service and region name","message":"Allow configuration per service and region name\n\nCurrently oslo_limit only allow configuration per endpoint_id.\nThis commit allow configuration per service and region name in\norder to ease the generation of configuration file for deployer.\n\nIn both endpoint_id and service/region name are specified,\nendpoint_id preceed.\n\nCloses-Bug: #1835106\nChange-Id: I1ccf40d4456d5afcfbe65f826d14b16142cfc2d9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/27ca3d274728429dee16454698234269199c36ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/27ca3d274728429dee16454698234269199c36ff"}]},"branch":"refs/heads/master"},"ccee8feedd3454b6762e0cdb5b99196bee306258":{"kind":"REWORK","_number":4,"created":"2020-05-16 12:05:29.000000000","uploader":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"ref":"refs/changes/29/726929/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.limit","ref":"refs/changes/29/726929/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/4"}}},"commit":{"parents":[{"commit":"3b5a820db3cb51224c482123f2e40b74e460b5ab","subject":"Add Python3 victoria unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/3b5a820db3cb51224c482123f2e40b74e460b5ab"}]}],"author":{"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","date":"2020-05-11 07:58:01.000000000","tz":0},"committer":{"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","date":"2020-05-16 12:05:21.000000000","tz":0},"subject":"Allow configuration per service and region name","message":"Allow configuration per service and region name\n\nCurrently oslo_limit only allow configuration per endpoint_id.\nThis commit allow configuration per service and region name in\norder to ease the generation of configuration file for deployer.\n\nIn both endpoint_id and service/region name are specified,\nendpoint_id preceed.\n\nCloses-Bug: #1835106\nChange-Id: I1ccf40d4456d5afcfbe65f826d14b16142cfc2d9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/ccee8feedd3454b6762e0cdb5b99196bee306258"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/ccee8feedd3454b6762e0cdb5b99196bee306258"}]},"branch":"refs/heads/master"},"1d8497b40d8b5f3b6da9927b332cf7dd129a986f":{"kind":"REWORK","_number":5,"created":"2020-05-23 15:13:29.000000000","uploader":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"ref":"refs/changes/29/726929/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.limit","ref":"refs/changes/29/726929/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/5"}}},"commit":{"parents":[{"commit":"3b5a820db3cb51224c482123f2e40b74e460b5ab","subject":"Add Python3 victoria unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/3b5a820db3cb51224c482123f2e40b74e460b5ab"}]}],"author":{"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","date":"2020-05-11 07:58:01.000000000","tz":0},"committer":{"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","date":"2020-05-23 15:13:15.000000000","tz":0},"subject":"Allow configuration per service and region name","message":"Allow configuration per service and region name\n\nCurrently oslo_limit only allow configuration per endpoint_id.\nThis commit allow configuration per service and region name in\norder to ease the generation of configuration file for deployer.\n\nIn both endpoint_id and service/region name are specified,\nendpoint_id preceed.\n\nCloses-Bug: #1835106\nDepends-on: https://review.opendev.org/726621\nChange-Id: I1ccf40d4456d5afcfbe65f826d14b16142cfc2d9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/1d8497b40d8b5f3b6da9927b332cf7dd129a986f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/1d8497b40d8b5f3b6da9927b332cf7dd129a986f"}]},"branch":"refs/heads/master"},"ccc161108f9ae6d0d273a752a30ffcfeda2d4b28":{"kind":"REWORK","_number":6,"created":"2020-06-20 11:43:25.000000000","uploader":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"ref":"refs/changes/29/726929/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.limit","ref":"refs/changes/29/726929/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/6"}}},"commit":{"parents":[{"commit":"0b35c1614c455a6c06e866899e6ee21586eb14ff","subject":"Merge \"Add debug tox environment\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/0b35c1614c455a6c06e866899e6ee21586eb14ff"}]}],"author":{"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","date":"2020-05-11 07:58:01.000000000","tz":0},"committer":{"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","date":"2020-06-20 11:43:10.000000000","tz":0},"subject":"Allow configuration per service and region name","message":"Allow configuration per service and region name\n\nCurrently oslo_limit only allow configuration per endpoint_id.\nThis commit allow configuration per service and region name in\norder to ease the generation of configuration file for deployer.\n\nIn both endpoint_id and service/region name are specified,\nendpoint_id preceed.\n\nCloses-Bug: #1835106\nDepends-on: https://review.opendev.org/726621\nChange-Id: I1ccf40d4456d5afcfbe65f826d14b16142cfc2d9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/ccc161108f9ae6d0d273a752a30ffcfeda2d4b28"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/ccc161108f9ae6d0d273a752a30ffcfeda2d4b28"}]},"branch":"refs/heads/master"},"adc1d3ed273f23ba0334350d6b00acf06b9f69ea":{"kind":"REWORK","_number":7,"created":"2020-07-15 12:57:28.000000000","uploader":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"ref":"refs/changes/29/726929/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.limit","ref":"refs/changes/29/726929/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.limit refs/changes/29/726929/7"}}},"commit":{"parents":[{"commit":"0b35c1614c455a6c06e866899e6ee21586eb14ff","subject":"Merge \"Add debug tox environment\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/0b35c1614c455a6c06e866899e6ee21586eb14ff"}]}],"author":{"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","date":"2020-05-11 07:58:01.000000000","tz":0},"committer":{"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","date":"2020-07-15 12:56:32.000000000","tz":120},"subject":"Allow configuration per service and region name","message":"Allow configuration per service and region name\n\nCurrently oslo_limit only allow configuration per endpoint_id.\nThis commit allow configuration per service and region name in\norder to ease the generation of configuration file for deployer.\n\nIn both endpoint_id and service/region name are specified,\nendpoint_id preceed.\n\nCloses-Bug: #1835106\nDepends-on: https://review.opendev.org/726621\nDepends-on: https://review.opendev.org/733881\nChange-Id: I1ccf40d4456d5afcfbe65f826d14b16142cfc2d9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/adc1d3ed273f23ba0334350d6b00acf06b9f69ea"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/adc1d3ed273f23ba0334350d6b00acf06b9f69ea"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}