)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"adcfdd54ede8c38f7c88023ffcf74eba614b15ae","unresolved":false,"context_lines":[{"line_number":18,"context_line":"will result in duplicate names in two groups, but that problem"},{"line_number":19,"context_line":"already exists in some service projects that also need keystone"},{"line_number":20,"context_line":"configuration in multiple places. We will need to be careful with"},{"line_number":21,"context_line":"our documentation to ensure the difference is clear."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I0b21dbe85358bd7308f244bbc7599a34cd69083a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_dc1486eb","line":21,"updated":"2020-08-10 19:44:05.000000000","message":"Should we add a release note calling out this change?\n\nAnd maybe some docs somewhere? Not sure if we have any existing docs that would be relevant.","commit_id":"1ff89aa0293f000dc55d9a1eb1bd3b58fa830794"},{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"d1d2ea4cc04bee45c02b4b4229a79e2e9e7a113c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"will result in duplicate names in two groups, but that problem"},{"line_number":19,"context_line":"already exists in some service projects that also need keystone"},{"line_number":20,"context_line":"configuration in multiple places. We will need to be careful with"},{"line_number":21,"context_line":"our documentation to ensure the difference is clear."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I0b21dbe85358bd7308f244bbc7599a34cd69083a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_bcb39297","line":21,"in_reply_to":"9f560f44_dc1486eb","updated":"2020-08-10 20:19:45.000000000","message":"I agree for the release note.\nFor the doc, this patch is a prerequisite for this one : https://review.opendev.org/#/c/726929/, I can handle update of the user guide I previously write (https://review.opendev.org/#/c/726930) in it.","commit_id":"1ff89aa0293f000dc55d9a1eb1bd3b58fa830794"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b22ff64aac564947a2ceeae1055ab3f3a00fda93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"814f5769_4d052325","updated":"2022-01-11 11:00:14.000000000","message":"IMO it\u0027s too late to make this change without deprecation. The oslo.limits library is already consumed by Glance, and puppet-glance already supports the existing usage. This change directly breaks the deployment during upgrade.\n\nAn alternative approach would be to add a prefix to the parameters which are used to look up endpoint, like endpoint_service_name with keeping the existing parameters. Otherwise IMO we should keep but deprecate the existing usage and wait for one cycle.","commit_id":"bd45929aac0b2ea2f167399da87982c6f5fd36ad"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"63031ece1ea6d016644b4da819f07e24729e963f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d6e68a56_c30de2bf","in_reply_to":"814f5769_4d052325","updated":"2022-01-11 11:05:06.000000000","message":"Sorry I didn\u0027t notice the same was already discussed, but I\u0027m still very much worried about the fact that the library is already used. I\u0027m not core in oslo so my vote doesn\u0027t block merging this change, and this can be merged if this is agreed among core reviewers. \n\nIf we make this change IMO we should make glance team aware of the change, and have them mark the unified limit feature experimental.","commit_id":"bd45929aac0b2ea2f167399da87982c6f5fd36ad"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"6c3a8a47055415a686050fec064ef6ec3fc79d1a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"698fce85_8ec51949","in_reply_to":"d6e68a56_c30de2bf","updated":"2022-04-27 12:15:21.000000000","message":"I agree with Takashi. I removed my +2 to highlight Takashi\u0027s comment (and his -1).","commit_id":"bd45929aac0b2ea2f167399da87982c6f5fd36ad"}],"oslo_limit/opts.py":[{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"74f1e83298cdac32c298f831452d1e558ecb697e","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def register_opts(conf):"},{"line_number":54,"context_line":"    loading.register_session_conf_options(CONF, _option_group)"},{"line_number":55,"context_line":"    loading.register_adapter_conf_options(CONF, _option_group,"},{"line_number":56,"context_line":"                                          include_deprecated\u003dFalse)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_af7091a5","line":54,"updated":"2020-07-15 12:45:35.000000000","message":"Use _keystoneauth_option_group","commit_id":"bc74d735b606f9ddd8096a937232c25ad461e275"},{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"74f1e83298cdac32c298f831452d1e558ecb697e","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def register_opts(conf):"},{"line_number":54,"context_line":"    loading.register_session_conf_options(CONF, _option_group)"},{"line_number":55,"context_line":"    loading.register_adapter_conf_options(CONF, _option_group,"},{"line_number":56,"context_line":"                                          include_deprecated\u003dFalse)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    loading.register_auth_conf_options(CONF, _keystoneauth_option_group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0f6b7db6","line":55,"updated":"2020-07-15 12:45:35.000000000","message":"Use _keystoneauth_option_group","commit_id":"bc74d735b606f9ddd8096a937232c25ad461e275"}]}