)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1e5aa7b42727c09aa96ad96b86d0de6963f6c3d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f237c77b_75252332","updated":"2021-10-20 07:45:23.000000000","message":"Hello,\n\nDoes these changes are related to a launchpad issue?\n\nIt could be worth to add a release note to highlight this topic.","commit_id":"e9c038ef3bb035909fbd421eb7a679fad410ca04"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8f9b5efc0d49ee37c46a189534a15bcf2b894598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"191f7658_256f1f34","in_reply_to":"069ec2ae_a5429241","updated":"2021-10-25 12:20:07.000000000","message":"Hi,\n\nOk no problem. Let\u0027s continue without launchpad bug for now.\n\nThanks for you answers.","commit_id":"e9c038ef3bb035909fbd421eb7a679fad410ca04"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9015e8f16d60be4c353179cd45bab452b47ea572","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"069ec2ae_a5429241","in_reply_to":"7f94476b_fb04a133","updated":"2021-10-20 22:00:08.000000000","message":"Hi, I didn\u0027t open a bug about this because at the time I wasn\u0027t sure if it was going to be considered a bug or a enhancement to change it to not raise an exception in this situation.","commit_id":"e9c038ef3bb035909fbd421eb7a679fad410ca04"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"331110fdee5ae16b8138530c14f2e4641b78682a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f94476b_fb04a133","in_reply_to":"f237c77b_75252332","updated":"2021-10-20 20:51:56.000000000","message":"No, I don\u0027t think we filed a bug for any of this (maybe melwitt did?). This came from a conversation and review in another project where we identified this as a shortcoming.\n\nIf you want a bug filed, I can do that, just let me know.","commit_id":"e9c038ef3bb035909fbd421eb7a679fad410ca04"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"91bc0b67c742a3e9cc9ff44016196bdcf0c4b2a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a77e8abd_ba834a03","updated":"2022-01-10 20:45:13.000000000","message":"LGTM","commit_id":"a49f3a04d02ef6fe43423eda313d9115588f0287"}],"oslo_limit/limit.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9fb34c74fffd5fbcf5ea6a5ef4058f891f89709d","unresolved":true,"context_lines":[{"line_number":284,"context_line":"            try:"},{"line_number":285,"context_line":"                limit \u003d self._get_limit(project_id, resource_name)"},{"line_number":286,"context_line":"            except _LimitNotFound:"},{"line_number":287,"context_line":"                limit \u003d 0"},{"line_number":288,"context_line":"            project_limits.append((resource_name, limit))"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        return project_limits"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ec9acfe_2d15f64e","line":287,"updated":"2021-08-30 20:55:33.000000000","message":"The only remotely possible issue I could think of with this is if a caller wanted to be able to distinguish between a limit that is not found vs a limit that has been set deliberately to zero. But, enforce_limits does not tolerate a \"limit\" of None presently, so to do that it would have to be changed to treat limit\u003dNone as another over limit condition.\n\nI don\u0027t think I could predict whether any callers would want to be able to distinguish between not found and zero, though. For my current use case, I am fine with only zero.\n\nJust wanted to mention the potential use case if anyone else thinks that might be important to oslo.limit users.","commit_id":"e9c038ef3bb035909fbd421eb7a679fad410ca04"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1e5aa7b42727c09aa96ad96b86d0de6963f6c3d1","unresolved":true,"context_lines":[{"line_number":284,"context_line":"            try:"},{"line_number":285,"context_line":"                limit \u003d self._get_limit(project_id, resource_name)"},{"line_number":286,"context_line":"            except _LimitNotFound:"},{"line_number":287,"context_line":"                limit \u003d 0"},{"line_number":288,"context_line":"            project_limits.append((resource_name, limit))"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        return project_limits"}],"source_content_type":"text/x-python","patch_set":1,"id":"179131f0_52de7472","line":287,"in_reply_to":"52081937_b8760799","updated":"2021-10-20 07:45:23.000000000","message":"The `None` capabilitie could be added later as an improvement if the need arises in use. For now the current version of these changes LGTM.","commit_id":"e9c038ef3bb035909fbd421eb7a679fad410ca04"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"97f68d78371ca97acd4ea1e66cbb65a350e67336","unresolved":true,"context_lines":[{"line_number":284,"context_line":"            try:"},{"line_number":285,"context_line":"                limit \u003d self._get_limit(project_id, resource_name)"},{"line_number":286,"context_line":"            except _LimitNotFound:"},{"line_number":287,"context_line":"                limit \u003d 0"},{"line_number":288,"context_line":"            project_limits.append((resource_name, limit))"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        return project_limits"}],"source_content_type":"text/x-python","patch_set":1,"id":"52081937_b8760799","line":287,"in_reply_to":"7ec9acfe_2d15f64e","updated":"2021-08-30 22:06:52.000000000","message":"Yep, and I started thinking I would return {\u0027limit\u0027: None} in the dict. But then I got to thinking that the enforce doesn\u0027t tell you whether or not the limit was zero or unregistered, and plumbing None through the results as well would be more work. This way, all the tests that validate the unregistered limit still show the same behavior, which is nice validation that this doesn\u0027t break anyone who currently relies on it.","commit_id":"e9c038ef3bb035909fbd421eb7a679fad410ca04"}],"oslo_limit/tests/test_limit.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"709be4b7d34b566c9e06538c780a23b94251bde7","unresolved":true,"context_lines":[{"line_number":259,"context_line":"        deltas \u003d {\"a\": 0, \"b\": 0}"},{"line_number":260,"context_line":"        fake_limit \u003d klimit.Limit()"},{"line_number":261,"context_line":"        fake_limit.resource_name \u003d \u0027a\u0027"},{"line_number":262,"context_line":"        fake_limit.default_limit \u003d 20"},{"line_number":263,"context_line":"        mock_get_reglimit.return_value \u003d None"},{"line_number":264,"context_line":"        mock_get_limit.return_value \u003d None"},{"line_number":265,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"cd431801_88b8979a","line":262,"updated":"2022-01-10 20:35:21.000000000","message":"Unless I\u0027m missing something, it looks like fake_limit isn\u0027t used anywhere?","commit_id":"a9615e052ae6f618c4c2bcf26805eecb7653dc5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bbc90263418c1e7a4d01991afa4717c5ca4e856b","unresolved":true,"context_lines":[{"line_number":259,"context_line":"        deltas \u003d {\"a\": 0, \"b\": 0}"},{"line_number":260,"context_line":"        fake_limit \u003d klimit.Limit()"},{"line_number":261,"context_line":"        fake_limit.resource_name \u003d \u0027a\u0027"},{"line_number":262,"context_line":"        fake_limit.default_limit \u003d 20"},{"line_number":263,"context_line":"        mock_get_reglimit.return_value \u003d None"},{"line_number":264,"context_line":"        mock_get_limit.return_value \u003d None"},{"line_number":265,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab47241_a5629a8f","line":262,"in_reply_to":"cd431801_88b8979a","updated":"2022-01-10 20:38:46.000000000","message":"Yeah, in the previous rev too. I dunno, but..fixed :)","commit_id":"a9615e052ae6f618c4c2bcf26805eecb7653dc5e"}]}