)]}'
{"id":"openstack%2Foslo.limit~828813","triplet_id":"openstack%2Foslo.limit~master~I28cdd4d3f4927b94acea3309b36999850cf2ee2a","project":"openstack/oslo.limit","branch":"master","topic":"bp/unified-limits-nova","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2022-04-05 11:45:19.000000000","reason":"Change was submitted"},"28522":{"account":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"last_update":"2022-04-05 10:22:19.000000000","reason":"Hervé Beraud replied on the change"}},"hashtags":[],"change_id":"I28cdd4d3f4927b94acea3309b36999850cf2ee2a","subject":"Move Enforcer caching closer to limit retrieval","status":"MERGED","created":"2022-02-11 02:32:04.000000000","updated":"2022-04-05 11:46:56.000000000","submitted":"2022-04-05 11:45:19.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"828813-bp/unified-limits-nova","meta_rev_id":"2f467c5ac94e46a3486ddc1684f23f955b623e7a","_number":828813,"virtual_id_number":828813,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-04-05 11:45:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2022-03-22 12:07:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2022-04-05 10:22:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":1,"date":"2022-04-05 10:22:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-02-11 04:15:00.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-03-22 12:07:28.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2022-03-22 12:07:28.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"}],"messages":[{"id":"57ca752eef1fb3bf59de40cb839783135c56813d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2022-02-11 02:32:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"90814d1c5732c49081fe4f9e8df30eb27a27e22b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-11 04:15:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b2cb5eee313345d78c32845c184f57ae : SUCCESS in 1h 34m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e9d21a4ebdcd408181734a660aade443 : SUCCESS in 5m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4b151961013a4ebeb50fc8ba172aa8c7 : SUCCESS in 4m 28s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/cd3524646e0f49b9a0aabc25c8bacb0d : SUCCESS in 6m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d87077c64f314484984bf27d7a8f7225 : SUCCESS in 5m 27s\n- oslo-limit-functional-devstack https://zuul.opendev.org/t/openstack/build/c71274e3a85249b184b7982f9d034c38 : SUCCESS in 31m 10s","accounts_in_message":[],"_revision_number":1},{"id":"ac90cfeea8ef0af4fdd4d64059c7b97753f04062","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2022-03-15 01:21:07.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"f0ad879c28cf66fee8fbfcda7b2f1478dd3ac043","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-03-15 02:47:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/596d39d7d3a64aff969015f991bff79c : SUCCESS in 1h 24m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f38fb33bbbaf41ec83c9348400cab69f : SUCCESS in 5m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/da753661dd3f4aed8077f6707b09a6f6 : SUCCESS in 5m 18s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3387c364b28740059f5d1e9b65f6886f : SUCCESS in 4m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/03889974ea6d4b9fad4133161cf49263 : SUCCESS in 4m 57s\n- oslo-limit-functional-devstack https://zuul.opendev.org/t/openstack/build/6c85ab0812b44c35a51854162ddf4a59 : SUCCESS in 24m 14s","accounts_in_message":[],"_revision_number":2},{"id":"3af616bbd0be97bb01f79ab424817d53fd497884","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-03-22 12:07:28.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c5d4d3858dc81df9f8d3b1b4f20fad0f1b4f6348","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2022-04-05 10:22:19.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"8a23be3a5e54b6951f9197b28095ba3d73e45a2c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-04-05 10:23:12.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"477671dcee6d775918b64af5c15e6d67b916b94a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-04-05 11:45:19.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/fa92a9577514467f977042091b48a314 : SUCCESS in 1h 21m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2d81765ab47641d5a679c1c1720c0c16 : SUCCESS in 4m 00s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/22bcc2222fa54dac94851dfb9c7e5ef4 : SUCCESS in 3m 51s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0cc022e213384f81b1d9f3c0490df953 : SUCCESS in 4m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7f21bad71cfd456791f451089dcda6cc : SUCCESS in 4m 39s\n- oslo-limit-functional-devstack https://zuul.opendev.org/t/openstack/build/c41bbca60a7d4b14ac40696a005f62ba : SUCCESS in 26m 18s","accounts_in_message":[],"_revision_number":2},{"id":"a8c566bf18c6176110766c0b13c16872474011e2","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-04-05 11:45:19.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"2f467c5ac94e46a3486ddc1684f23f955b623e7a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-04-05 11:46:56.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5d243a2e50f9467e88721bb4947d3c84 : SUCCESS in 1m 12s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c67c9cf0df47947834b00bc2cbbd4524521bc011","revisions":{"d581f89f85514621b44663d0fa5b7a73a53e2985":{"kind":"REWORK","_number":1,"created":"2022-02-11 02:32:04.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/13/828813/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.limit","ref":"refs/changes/13/828813/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/13/828813/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/13/828813/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/13/828813/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.limit refs/changes/13/828813/1"}}},"commit":{"parents":[{"commit":"bf9deb10c3af4c43f6952f0fcedb9d48dfd8340d","subject":"Add interfaces for getting limits without enforcing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/bf9deb10c3af4c43f6952f0fcedb9d48dfd8340d"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2022-02-11 01:34:41.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2022-02-11 02:31:26.000000000","tz":0},"subject":"Move Enforcer caching closer to limit retrieval","message":"Move Enforcer caching closer to limit retrieval\n\nIn change I22234e0bb6b3a1cecb29a6b99a3afcd02ffdbf5f added a\nget_registered_limits() interface but missed making it work with the\nEnforcer cache because caching was implemented in a higher layer,\n_get_limit() and get_registered_limits() could not make use of\n_get_limit().\n\nThis moves the caching logic to where limits are retrieved from\nkeystone, so that get_registered_limits() will use caching and any\ninterfaces that might be added in the future will be able to benefit\nfrom using the cache.\n\nChange-Id: I28cdd4d3f4927b94acea3309b36999850cf2ee2a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/d581f89f85514621b44663d0fa5b7a73a53e2985"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/d581f89f85514621b44663d0fa5b7a73a53e2985"}]},"branch":"refs/heads/master"},"c67c9cf0df47947834b00bc2cbbd4524521bc011":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-03-15 01:21:07.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/13/828813/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.limit","ref":"refs/changes/13/828813/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/13/828813/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/13/828813/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.limit refs/changes/13/828813/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.limit refs/changes/13/828813/2"}}},"commit":{"parents":[{"commit":"bf9deb10c3af4c43f6952f0fcedb9d48dfd8340d","subject":"Add interfaces for getting limits without enforcing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/bf9deb10c3af4c43f6952f0fcedb9d48dfd8340d"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2022-02-11 01:34:41.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2022-03-15 01:21:07.000000000","tz":0},"subject":"Move Enforcer caching closer to limit retrieval","message":"Move Enforcer caching closer to limit retrieval\n\nIn change I22234e0bb6b3a1cecb29a6b99a3afcd02ffdbf5f added a\nget_registered_limits() interface but missed making it work with the\nEnforcer cache because caching was implemented in a higher layer,\n_get_limit() and get_registered_limits() could not make use of\n_get_limit().\n\nThis moves the caching logic to where limits are retrieved from\nkeystone, so that get_registered_limits() will use caching and any\ninterfaces that might be added in the future will be able to benefit\nfrom using the cache.\n\nCloses-Bug: #1964848\n\nChange-Id: I28cdd4d3f4927b94acea3309b36999850cf2ee2a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/c67c9cf0df47947834b00bc2cbbd4524521bc011"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.limit/commit/c67c9cf0df47947834b00bc2cbbd4524521bc011"}]},"branch":"refs/heads/master","description":"Edit commit message"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}