)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"667f93e7e7f5d3df373480c672c6883220c1bcd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b3d439f7_7f128b64","updated":"2023-11-15 17:37:12.000000000","message":"Probably some more discussion is needed on this, and I\u0027m sorry I missed the nova ptg session on this, but happy to circle back if you have time.","commit_id":"dee335b113698cc1c9f746c3d04edebe11d4b2e8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e3ef8aa9152b280407aff01987266983446c768d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b5a25990_af85e465","updated":"2023-11-15 17:28:25.000000000","message":"we chatted about this a little downstram and think we shoudl discuss this upstream\n\ndansmith raised concenrs that htis would break how glance is now using limits","commit_id":"dee335b113698cc1c9f746c3d04edebe11d4b2e8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6b81eb04d9740aec7b799119b4c780beda380b7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"edf56892_03d301f0","updated":"2024-04-10 09:40:06.000000000","message":"I am very happy for someone else to own this effort, I don\u0027t have the bandwidth to take it much further.","commit_id":"7193a52d55b3034a3f6981f1866d218479d082b8"}],"oslo_limit/limit.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"667f93e7e7f5d3df373480c672c6883220c1bcd6","unresolved":true,"context_lines":[{"line_number":317,"context_line":"                found_a_limit \u003d True"},{"line_number":318,"context_line":"                limit \u003d reg_limit.default_limit"},{"line_number":319,"context_line":"            else:"},{"line_number":320,"context_line":"                # default to unlimited"},{"line_number":321,"context_line":"                limit \u003d -1"},{"line_number":322,"context_line":"            registered_limits.append((resource_name, limit))"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"905c06ae_eb163a82","line":320,"updated":"2023-11-15 17:37:12.000000000","message":"I don\u0027t think this is legit to change, IMHO. oslo.limit is a library and this is a pretty substantial change to the behavior. In glance, we specifically say that if limits in keystone is enabled, all the limits must be registered. We also can\u0027t check all of our limits at a single point in time, which means we would get different behavior for each of the limits because of how we check.\n\nThat, and it also means that if you typo one of the several limits you create, that one will be silently unlimited until you realize your mistake, which I also think is bad.\n\nPersonally, I think that having these be strict and \"default closed\" is the right behavior. Projects querying for a large list of limits, many of which may be unregistered because \"we don\u0027t care about that limit\" feels wrong to me. I\u0027d rather this be strict and have projects only query for things that must have limits, and/or have a list of limits that should be checked, and/or have some other way to communicate that specific limits are optional.","commit_id":"dee335b113698cc1c9f746c3d04edebe11d4b2e8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a4458ecf6f499518f6250742dda1e6e885132ba5","unresolved":true,"context_lines":[{"line_number":317,"context_line":"                found_a_limit \u003d True"},{"line_number":318,"context_line":"                limit \u003d reg_limit.default_limit"},{"line_number":319,"context_line":"            else:"},{"line_number":320,"context_line":"                # default to unlimited"},{"line_number":321,"context_line":"                limit \u003d -1"},{"line_number":322,"context_line":"            registered_limits.append((resource_name, limit))"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"055c5ec1_a08a0301","line":320,"in_reply_to":"905c06ae_eb163a82","updated":"2024-04-10 09:02:09.000000000","message":"I like the idea of the caller having the option to give provide a different default, thus giving is strict vs not.","commit_id":"dee335b113698cc1c9f746c3d04edebe11d4b2e8"}]}