)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fd15c2de1617a89986f22694ff738cb8777889ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b87233b4_3a7bb8d6","updated":"2025-03-11 18:07:49.000000000","message":"Thanks for reviewing! I\u0027ll push a new PS soon.","commit_id":"c30e8b5820fb2d47cce8fb14f128d2359c3abed0"}],"oslo_limit/limit.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cb6f13ae8e037c7d1c81dc5e30fc98ee3379a02f","unresolved":true,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        # If an empty list or None was passed for resource_names, get and"},{"line_number":372,"context_line":"        # return all of the registered limits."},{"line_number":373,"context_line":"        if not resource_names:"},{"line_number":374,"context_line":"            reg_limits \u003d self.connection.registered_limits("},{"line_number":375,"context_line":"                service_id\u003dself._service_id, region_id\u003dself._region_id)"},{"line_number":376,"context_line":"            for reg_limit in reg_limits:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e941cdbf_8504405d","line":373,"range":{"start_line":373,"start_character":8,"end_line":373,"end_character":30},"updated":"2025-03-11 11:13:37.000000000","message":"I\u0027m concerned with changing the behavior for empty lists, because the previous behavior might be already \"expected. Can we use only None ? IIUC None has never worked so it may not break any of the existing usage.","commit_id":"c30e8b5820fb2d47cce8fb14f128d2359c3abed0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"22f40024a559dd68cb19e43f7316e734e71c4fd3","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        # If an empty list or None was passed for resource_names, get and"},{"line_number":372,"context_line":"        # return all of the registered limits."},{"line_number":373,"context_line":"        if not resource_names:"},{"line_number":374,"context_line":"            reg_limits \u003d self.connection.registered_limits("},{"line_number":375,"context_line":"                service_id\u003dself._service_id, region_id\u003dself._region_id)"},{"line_number":376,"context_line":"            for reg_limit in reg_limits:"}],"source_content_type":"text/x-python","patch_set":1,"id":"29066ab9_111fe10d","line":373,"range":{"start_line":373,"start_character":8,"end_line":373,"end_character":30},"in_reply_to":"9544250c_9b327033","updated":"2025-03-12 00:20:22.000000000","message":"Done","commit_id":"c30e8b5820fb2d47cce8fb14f128d2359c3abed0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fd15c2de1617a89986f22694ff738cb8777889ff","unresolved":true,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        # If an empty list or None was passed for resource_names, get and"},{"line_number":372,"context_line":"        # return all of the registered limits."},{"line_number":373,"context_line":"        if not resource_names:"},{"line_number":374,"context_line":"            reg_limits \u003d self.connection.registered_limits("},{"line_number":375,"context_line":"                service_id\u003dself._service_id, region_id\u003dself._region_id)"},{"line_number":376,"context_line":"            for reg_limit in reg_limits:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9544250c_9b327033","line":373,"range":{"start_line":373,"start_character":8,"end_line":373,"end_character":30},"in_reply_to":"e941cdbf_8504405d","updated":"2025-03-11 18:07:49.000000000","message":"That\u0027s a fair point -- previous behavior for the empty list would have been empty. I\u0027ll update to use only None.","commit_id":"c30e8b5820fb2d47cce8fb14f128d2359c3abed0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cb6f13ae8e037c7d1c81dc5e30fc98ee3379a02f","unresolved":true,"context_lines":[{"line_number":371,"context_line":"        # If an empty list or None was passed for resource_names, get and"},{"line_number":372,"context_line":"        # return all of the registered limits."},{"line_number":373,"context_line":"        if not resource_names:"},{"line_number":374,"context_line":"            reg_limits \u003d self.connection.registered_limits("},{"line_number":375,"context_line":"                service_id\u003dself._service_id, region_id\u003dself._region_id)"},{"line_number":376,"context_line":"            for reg_limit in reg_limits:"},{"line_number":377,"context_line":"                registered_limits.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"c39037c0_47f19ea4","line":374,"range":{"start_line":374,"start_character":30,"end_line":374,"end_character":58},"updated":"2025-03-11 11:13:37.000000000","message":"Can we implement _get_registered_limits, which internally updates cache data using the full list ?","commit_id":"c30e8b5820fb2d47cce8fb14f128d2359c3abed0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"22f40024a559dd68cb19e43f7316e734e71c4fd3","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        # If an empty list or None was passed for resource_names, get and"},{"line_number":372,"context_line":"        # return all of the registered limits."},{"line_number":373,"context_line":"        if not resource_names:"},{"line_number":374,"context_line":"            reg_limits \u003d self.connection.registered_limits("},{"line_number":375,"context_line":"                service_id\u003dself._service_id, region_id\u003dself._region_id)"},{"line_number":376,"context_line":"            for reg_limit in reg_limits:"},{"line_number":377,"context_line":"                registered_limits.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"29a17d2a_3b2059f0","line":374,"range":{"start_line":374,"start_character":30,"end_line":374,"end_character":58},"in_reply_to":"b2444a04_9433001a","updated":"2025-03-12 00:20:22.000000000","message":"Done","commit_id":"c30e8b5820fb2d47cce8fb14f128d2359c3abed0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fd15c2de1617a89986f22694ff738cb8777889ff","unresolved":true,"context_lines":[{"line_number":371,"context_line":"        # If an empty list or None was passed for resource_names, get and"},{"line_number":372,"context_line":"        # return all of the registered limits."},{"line_number":373,"context_line":"        if not resource_names:"},{"line_number":374,"context_line":"            reg_limits \u003d self.connection.registered_limits("},{"line_number":375,"context_line":"                service_id\u003dself._service_id, region_id\u003dself._region_id)"},{"line_number":376,"context_line":"            for reg_limit in reg_limits:"},{"line_number":377,"context_line":"                registered_limits.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"b2444a04_9433001a","line":374,"range":{"start_line":374,"start_character":30,"end_line":374,"end_character":58},"in_reply_to":"c39037c0_47f19ea4","updated":"2025-03-11 18:07:49.000000000","message":"Makes sense, I\u0027ll add that.","commit_id":"c30e8b5820fb2d47cce8fb14f128d2359c3abed0"}]}