)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ea039e06908f5aee033f35fa94b225dcaaddd681","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af62adcb_aa4ebbbe","updated":"2025-09-17 16:57:07.000000000","message":"As you note, this is completely broken as-is, so this seems reasonable to backport. We can backport the other change once it\u0027s ready also.","commit_id":"b14c31dbaac99edda8c60a4f5fca49e0cce5acbb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a9cfb78ef2cf222240ad37666f8ed369d89d6ad4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ecf11c3e_4dc7b993","updated":"2025-10-08 15:58:06.000000000","message":"Let\u0027s get this in.","commit_id":"b14c31dbaac99edda8c60a4f5fca49e0cce5acbb"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"74615266b9e8148a00ebcf381a8edc4eed1a2856","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d7bc7cc3_d1d93291","updated":"2025-09-17 09:29:06.000000000","message":"The rationale behind these changes LGTM, I just have a minor concern about the removed choices, please see my inline comment.","commit_id":"b14c31dbaac99edda8c60a4f5fca49e0cce5acbb"}],"oslo_limit/opts.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"74615266b9e8148a00ebcf381a8edc4eed1a2856","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    cfg.StrOpt("},{"line_number":41,"context_line":"        \u0027endpoint_interface\u0027,"},{"line_number":42,"context_line":"        default\u003d\u0027publicURL\u0027,"},{"line_number":43,"context_line":"        choices\u003d[\u0027public\u0027, \u0027publicURL\u0027, \u0027internal\u0027, \u0027internalURL\u0027,"},{"line_number":44,"context_line":"                 \u0027admin\u0027, \u0027adminURL\u0027],"},{"line_number":45,"context_line":"        help\u003d_(\"The interface for endpoint discovery\")),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0c8a0fe7_06e09503","side":"PARENT","line":44,"range":{"start_line":43,"start_character":7,"end_line":44,"end_character":38},"updated":"2025-09-17 09:29:06.000000000","message":"Should we not respect first a deprecation period for those removed choices?\nIf people use them in their config, that would break their instance.","commit_id":"0a7ed3a102fecb7643187823155a585283a840b3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d9a4935ab934ad8b98822ac1bb47d956741ca96a","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    cfg.StrOpt("},{"line_number":41,"context_line":"        \u0027endpoint_interface\u0027,"},{"line_number":42,"context_line":"        default\u003d\u0027publicURL\u0027,"},{"line_number":43,"context_line":"        choices\u003d[\u0027public\u0027, \u0027publicURL\u0027, \u0027internal\u0027, \u0027internalURL\u0027,"},{"line_number":44,"context_line":"                 \u0027admin\u0027, \u0027adminURL\u0027],"},{"line_number":45,"context_line":"        help\u003d_(\"The interface for endpoint discovery\")),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5cdcd095_b9e82861","side":"PARENT","line":44,"range":{"start_line":43,"start_character":7,"end_line":44,"end_character":38},"in_reply_to":"0c8a0fe7_06e09503","updated":"2025-09-17 12:46:35.000000000","message":"I\u0027m unsure how many people may set these values at this moment given the fact that the feature using this is completely broken, but probably merging https://review.opendev.org/c/openstack/oslo.limit/+/961478 and including it in this backport may resolve that concern.","commit_id":"0a7ed3a102fecb7643187823155a585283a840b3"}]}