)]}'
{"oslo/log/helpers.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a323fe1d25668737df5eaa405d8cbc8468bd3dcc","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    :param method: Method to decorate to be logged."},{"line_number":29,"context_line":"    :type method: method definition"},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":"    LOG \u003d logging.getLogger(method.__module__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @functools.wraps(method)"},{"line_number":34,"context_line":"    def wrapper(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_799d37bb","line":31,"updated":"2014-11-29 16:34:45.000000000","message":"This doesn\u0027t feel like it should be uppercase anymore; since its not a module constant value anymore... Thoughts?","commit_id":"c93b08fd95d5bf628bd0a27e46b9938d87624e01"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3591b9385ddb1e6fd7e248d2997ebef777dc2e5b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    :param method: Method to decorate to be logged."},{"line_number":29,"context_line":"    :type method: method definition"},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":"    LOG \u003d logging.getLogger(method.__module__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @functools.wraps(method)"},{"line_number":34,"context_line":"    def wrapper(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_5925cd5a","line":31,"in_reply_to":"5a890539_799d37bb","updated":"2014-12-01 10:04:25.000000000","message":"Done","commit_id":"c93b08fd95d5bf628bd0a27e46b9938d87624e01"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"d74e884bc818d7a48a2e2caa789363afa394a6ce","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @functools.wraps(method)"},{"line_number":34,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":35,"context_line":"        first_arg \u003d args[0]"},{"line_number":36,"context_line":"        cls \u003d first_arg if isinstance(first_arg, type) else first_arg.__class__"},{"line_number":37,"context_line":"        data \u003d {\u0027class_name\u0027: _get_class_name(cls),"},{"line_number":38,"context_line":"                \u0027method_name\u0027: method.__name__,"},{"line_number":39,"context_line":"                \u0027args\u0027: args[1:], \u0027kwargs\u0027: kwargs}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_a4984f6b","line":36,"updated":"2014-11-30 20:22:16.000000000","message":"Use __qualname__ if u can?","commit_id":"c93b08fd95d5bf628bd0a27e46b9938d87624e01"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3591b9385ddb1e6fd7e248d2997ebef777dc2e5b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @functools.wraps(method)"},{"line_number":34,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":35,"context_line":"        first_arg \u003d args[0]"},{"line_number":36,"context_line":"        cls \u003d first_arg if isinstance(first_arg, type) else first_arg.__class__"},{"line_number":37,"context_line":"        data \u003d {\u0027class_name\u0027: _get_class_name(cls),"},{"line_number":38,"context_line":"                \u0027method_name\u0027: method.__name__,"},{"line_number":39,"context_line":"                \u0027args\u0027: args[1:], \u0027kwargs\u0027: kwargs}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_991e550c","line":36,"in_reply_to":"5a890539_a4984f6b","updated":"2014-12-01 10:04:25.000000000","message":"Done","commit_id":"c93b08fd95d5bf628bd0a27e46b9938d87624e01"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3ceca20dcbafb05bfe91745e196e2c589775ad3f","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @functools.wraps(method)"},{"line_number":35,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":36,"context_line":"        first_arg \u003d args[0]"},{"line_number":37,"context_line":"        cls \u003d first_arg if isinstance(first_arg, type) else first_arg.__class__"},{"line_number":38,"context_line":"        data \u003d {\u0027class_name\u0027: _get_full_class_name(cls),"},{"line_number":39,"context_line":"                \u0027method_name\u0027: method.__name__,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_ef467e7a","line":36,"updated":"2014-12-02 12:12:38.000000000","message":"What if there\u0027s no args? (e.g. function/staticmethod)","commit_id":"928b6e219dfcc8f66029334c7ec87e2b42c7c239"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"79dcbc51aed15b908ded637df42b8dbbbd195427","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @functools.wraps(method)"},{"line_number":35,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":36,"context_line":"        first_arg \u003d args[0]"},{"line_number":37,"context_line":"        cls \u003d first_arg if isinstance(first_arg, type) else first_arg.__class__"},{"line_number":38,"context_line":"        data \u003d {\u0027class_name\u0027: _get_full_class_name(cls),"},{"line_number":39,"context_line":"                \u0027method_name\u0027: method.__name__,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_8dbd9d6a","line":36,"in_reply_to":"5a890539_ef467e7a","updated":"2014-12-04 12:22:22.000000000","message":"It\u0027s not intended for those types of objects (I\u0027ll add an explicit notion of this in docstring).","commit_id":"928b6e219dfcc8f66029334c7ec87e2b42c7c239"}],"oslo/log/util.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"7765601f0361fa54146ccd83a54b1357b9bc678a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo.log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def log(method):"},{"line_number":22,"context_line":"    \"\"\"Decorator helping to log method calls.\"\"\""},{"line_number":23,"context_line":"    LOG \u003d logging.getLogger(method.__module__)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_617b628c","line":21,"updated":"2014-11-14 13:59:02.000000000","message":"The implementation assumes that the decorated method is in a class.  However, the name of the decorator or docs don\u0027t really make that clear.  I can\u0027t think of a good name though.  :-)","commit_id":"62952ded78758d9a973c402ee6195d496736b981"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a8aee01036932636a7dc79c09d2746fae818df87","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\"\"\"Log helper functions.\"\"\""},{"line_number":16,"context_line":"import functools"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo.log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def log(method):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_c6c0c852","line":18,"updated":"2014-11-21 17:37:38.000000000","message":"This should just use Python\u0027s logging module. We are deprecating the getLogger() API and don\u0027t intend to use it in Oslo libraries.","commit_id":"4d1ace46fa604e669a57f12e10e424d6bf71c756"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"724c0e7dd51cc66c7649debec6f810196bd19b99","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\"\"\"Log helper functions.\"\"\""},{"line_number":16,"context_line":"import functools"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo.log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def log(method):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_2ec28353","line":18,"in_reply_to":"5a890539_c6c0c852","updated":"2014-11-29 13:38:00.000000000","message":"Done","commit_id":"4d1ace46fa604e669a57f12e10e424d6bf71c756"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a8aee01036932636a7dc79c09d2746fae818df87","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo.log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def log(method):"},{"line_number":22,"context_line":"    \"\"\"Decorator helping to log method calls.\"\"\""},{"line_number":23,"context_line":"    LOG \u003d logging.getLogger(method.__module__)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_8666c0b9","line":21,"updated":"2014-11-21 17:37:38.000000000","message":"As Russell points out, this name doesn\u0027t really tell the caller that it\u0027s meant to be used only with methods. Does it work with both instance and class methods? How about calling it log_method_call?","commit_id":"4d1ace46fa604e669a57f12e10e424d6bf71c756"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"724c0e7dd51cc66c7649debec6f810196bd19b99","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo.log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def log(method):"},{"line_number":22,"context_line":"    \"\"\"Decorator helping to log method calls.\"\"\""},{"line_number":23,"context_line":"    LOG \u003d logging.getLogger(method.__module__)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_2e4363b0","line":21,"in_reply_to":"5a890539_8666c0b9","updated":"2014-11-29 13:38:00.000000000","message":"Done","commit_id":"4d1ace46fa604e669a57f12e10e424d6bf71c756"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a8aee01036932636a7dc79c09d2746fae818df87","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def log(method):"},{"line_number":22,"context_line":"    \"\"\"Decorator helping to log method calls.\"\"\""},{"line_number":23,"context_line":"    LOG \u003d logging.getLogger(method.__module__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @functools.wraps(method)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_c63288a6","line":22,"updated":"2014-11-21 17:37:38.000000000","message":"The docstring should have a section describing the parameters. For example:\n\n :param method: Method to decorate to be logged.\n :type method: method definition","commit_id":"4d1ace46fa604e669a57f12e10e424d6bf71c756"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"724c0e7dd51cc66c7649debec6f810196bd19b99","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def log(method):"},{"line_number":22,"context_line":"    \"\"\"Decorator helping to log method calls.\"\"\""},{"line_number":23,"context_line":"    LOG \u003d logging.getLogger(method.__module__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @functools.wraps(method)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_0e4867cb","line":22,"in_reply_to":"5a890539_c63288a6","updated":"2014-11-29 13:38:00.000000000","message":"Done","commit_id":"4d1ace46fa604e669a57f12e10e424d6bf71c756"}]}
