)]}'
{"oslo_log/log.py":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"d3983c09accb3bbaa91c0391d0e92a6b19eb488f","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            logging_context_format_string\u003dlogging_context_format_string)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def tempest_set_log_file(filename):"},{"line_number":250,"context_line":"    \"\"\"Provide an API for tempest to set the logging filename."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    .. warning:: Only Tempest should use this function."}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_28289de1","line":249,"range":{"start_line":249,"start_character":4,"end_line":249,"end_character":24},"updated":"2015-04-15 01:20:28.000000000","message":"Doug, is it better to do a _set_log_file and let tempest call a private method rather than name a public method with tempest_? (thinking aloud, not leaning one way or another)","commit_id":"64727772701cc639245bc83fb5846c2dec2b55df"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6ec85896f899f3c8f79626e98a64a505a61c09dd","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            logging_context_format_string\u003dlogging_context_format_string)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def tempest_set_log_file(filename):"},{"line_number":250,"context_line":"    \"\"\"Provide an API for tempest to set the logging filename."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    .. warning:: Only Tempest should use this function."}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_03ae342e","line":249,"in_reply_to":"5aa745d1_ec4eb395","updated":"2015-04-23 13:23:56.000000000","message":"I agree it\u0027s better to hide functions that are not really meant for public consumption.","commit_id":"64727772701cc639245bc83fb5846c2dec2b55df"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"15f2daa3bfb7b82dc70758fa9a8acd44e493a097","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            logging_context_format_string\u003dlogging_context_format_string)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def tempest_set_log_file(filename):"},{"line_number":250,"context_line":"    \"\"\"Provide an API for tempest to set the logging filename."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    .. warning:: Only Tempest should use this function."}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_ec4eb395","line":249,"range":{"start_line":249,"start_character":4,"end_line":249,"end_character":24},"in_reply_to":"7aaa499b_28289de1","updated":"2015-04-15 21:12:24.000000000","message":"I did think about that, but decided it was safer to use an ugly but obviously public name than to make a semi-private API. It seemed less confusing for reviewers, and for anyone coming in here to change this function later.","commit_id":"64727772701cc639245bc83fb5846c2dec2b55df"}]}