)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a4a08e8b95870fdced81a8deb674c21ca15913bb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  \u0027%(asctime)s.%(msecs)03d %(process)d %(levelname)s \u0027"},{"line_number":14,"context_line":"  \u0027%(name)s [%(request_id)s %(user_identity)s] \u0027"},{"line_number":15,"context_line":"  \u0027%(instance)s%(message)s\u0027,"},{"line_number":16,"context_line":"which is defined in oslo_context/context.py, or config file."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"And default of \"%(user_identity)s\" field format is followings,"},{"line_number":19,"context_line":" user_idt_format \u003d \u0027{user} {tenant} {domain} {user_domain} {p_domain}\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_715eae77","line":16,"updated":"2015-08-28 12:54:46.000000000","message":"I believe the string is NOT defined in oslo_context.","commit_id":"756d8415f9174cc775e80ab04382c4b52ccccfa3"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"87d070b0ce6c08bfb2aa393efde4af9c705f52b4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  \u0027%(asctime)s.%(msecs)03d %(process)d %(levelname)s \u0027"},{"line_number":14,"context_line":"  \u0027%(name)s [%(request_id)s %(user_identity)s] \u0027"},{"line_number":15,"context_line":"  \u0027%(instance)s%(message)s\u0027,"},{"line_number":16,"context_line":"which is defined in oslo_context/context.py, or config file."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"And default of \"%(user_identity)s\" field format is followings,"},{"line_number":19,"context_line":" user_idt_format \u003d \u0027{user} {tenant} {domain} {user_domain} {p_domain}\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_54d278d3","line":16,"in_reply_to":"da20952f_715eae77","updated":"2015-08-28 13:50:09.000000000","message":"Oops! I have made a big mistake.\n\nI\u0027ll correct it.","commit_id":"756d8415f9174cc775e80ab04382c4b52ccccfa3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a4a08e8b95870fdced81a8deb674c21ca15913bb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"For example, add following line to config file."},{"line_number":26,"context_line":" logging_user_identity_format \u003d %(user_name)s %(project_name)s"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I249ef7a8d144a4d5a34c3f80113f96fa4730ce28"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_f14abeab","line":28,"updated":"2015-08-28 12:54:46.000000000","message":"add \u0027Implements: blueprint ...\u0027","commit_id":"756d8415f9174cc775e80ab04382c4b52ccccfa3"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"87d070b0ce6c08bfb2aa393efde4af9c705f52b4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"For example, add following line to config file."},{"line_number":26,"context_line":" logging_user_identity_format \u003d %(user_name)s %(project_name)s"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I249ef7a8d144a4d5a34c3f80113f96fa4730ce28"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_b4c0b4e1","line":28,"in_reply_to":"da20952f_f14abeab","updated":"2015-08-28 13:50:09.000000000","message":"I\u0027ll add it.","commit_id":"756d8415f9174cc775e80ab04382c4b52ccccfa3"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"39ec7a90e86d51cc59b75b81404a05cdfa04d963","unresolved":false,"context_lines":[{"line_number":23,"context_line":"we are able to control the user_identity format."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"For example, add following line to config file."},{"line_number":26,"context_line":" logging_user_identity_format \u003d %(user_name)s %(project_name)s"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I249ef7a8d144a4d5a34c3f80113f96fa4730ce28"},{"line_number":29,"context_line":"Implements: blueprint user-identity-format-flexibility"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da85f559_730d6f36","line":26,"updated":"2015-11-10 13:26:23.000000000","message":"Maybe you can add the prefix suggested in previous comments (Patch Set 2):\n\n  logging_user_identity_format \u003d U:%(user)s T:%(tenant)s","commit_id":"c69dbdf53fd2b51a0b7d0a4f09b9e76c9f5ceacc"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"21a658a261671f9266aa417275b9872ad50f6cc6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"we are able to control the user_identity format."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"For example, add following line to config file."},{"line_number":26,"context_line":" logging_user_identity_format \u003d %(user_name)s %(project_name)s"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I249ef7a8d144a4d5a34c3f80113f96fa4730ce28"},{"line_number":29,"context_line":"Implements: blueprint user-identity-format-flexibility"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da85f559_87314c5c","line":26,"in_reply_to":"da85f559_730d6f36","updated":"2015-11-12 05:11:26.000000000","message":"I see. It is free that the user adds the prefix in the config-file.\n\nI update this line.","commit_id":"c69dbdf53fd2b51a0b7d0a4f09b9e76c9f5ceacc"}],"oslo_log/_options.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"2aa53f020ca89450aca59562e9e76320f9add423","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                    \u0027log message.\u0027),"},{"line_number":135,"context_line":"    cfg.StrOpt(\u0027logging_user_identity_format\u0027,"},{"line_number":136,"context_line":"               default\u003d\u0027%(user)s %(tenant)s \u0027"},{"line_number":137,"context_line":"                       \u0027%(domain)s %(user_domain)s %(project_domain)s\u0027,"},{"line_number":138,"context_line":"               help\u003d\u0027Format string for user_identity field of \u0027"},{"line_number":139,"context_line":"                    \u0027the logging_context_format_string\u0027),"},{"line_number":140,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_ce86fc64","line":137,"updated":"2015-10-07 16:08:18.000000000","message":"This is a lot of UUIDs to string together without any context for someone reading the log. I\u0027m not familiar with how \"domain\" fits into the authentication/identity hierarchy. Are the values listed in order from most specific to least specific scope? Should we include some literal values to make it clear what each value is? Like\n  U:%(user)s T:%(tenant)s D:%(domain)s UD:%(user_domain)s TD:%(tenant_domain)s\n\nI also wonder why it is \"project_domain\" and not \"tenant_domain\"? What does keystone call it?","commit_id":"1cf54f0a968fb85744b39175f043b767960d811f"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"27be1904d72cdf0278f67c16b54e302bf3cb4611","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                    \u0027log message.\u0027),"},{"line_number":135,"context_line":"    cfg.StrOpt(\u0027logging_user_identity_format\u0027,"},{"line_number":136,"context_line":"               default\u003d\u0027%(user)s %(tenant)s \u0027"},{"line_number":137,"context_line":"                       \u0027%(domain)s %(user_domain)s %(project_domain)s\u0027,"},{"line_number":138,"context_line":"               help\u003d\u0027Format string for user_identity field of \u0027"},{"line_number":139,"context_line":"                    \u0027the logging_context_format_string\u0027),"},{"line_number":140,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_667de5e6","line":137,"in_reply_to":"3a29b11f_8c00b467","updated":"2015-10-25 08:01:10.000000000","message":"OK, I will not touch the default log format in this patch.","commit_id":"1cf54f0a968fb85744b39175f043b767960d811f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f9fd6c00b07a374af551b4231d51d070bcdf5b29","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                    \u0027log message.\u0027),"},{"line_number":135,"context_line":"    cfg.StrOpt(\u0027logging_user_identity_format\u0027,"},{"line_number":136,"context_line":"               default\u003d\u0027%(user)s %(tenant)s \u0027"},{"line_number":137,"context_line":"                       \u0027%(domain)s %(user_domain)s %(project_domain)s\u0027,"},{"line_number":138,"context_line":"               help\u003d\u0027Format string for user_identity field of \u0027"},{"line_number":139,"context_line":"                    \u0027the logging_context_format_string\u0027),"},{"line_number":140,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_5ac847a8","line":137,"in_reply_to":"7a2fa921_3c422e69","updated":"2015-10-08 10:04:22.000000000","message":"I don\u0027t believe oslo.context should be touched for compatibility reasons.\n\nAs for prefixes, I am not sure it\u0027s a good idea because it changes log format, something that folks may rely upon.","commit_id":"1cf54f0a968fb85744b39175f043b767960d811f"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"a01767fb593e8aeba8f7e52d127197d82827032e","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                    \u0027log message.\u0027),"},{"line_number":135,"context_line":"    cfg.StrOpt(\u0027logging_user_identity_format\u0027,"},{"line_number":136,"context_line":"               default\u003d\u0027%(user)s %(tenant)s \u0027"},{"line_number":137,"context_line":"                       \u0027%(domain)s %(user_domain)s %(project_domain)s\u0027,"},{"line_number":138,"context_line":"               help\u003d\u0027Format string for user_identity field of \u0027"},{"line_number":139,"context_line":"                    \u0027the logging_context_format_string\u0027),"},{"line_number":140,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_8c00b467","line":137,"in_reply_to":"7a2fa921_5ac847a8","updated":"2015-10-22 10:26:38.000000000","message":"\u003e As for prefixes, I am not sure it\u0027s a good idea because it changes log format, something that folks may rely upon.\n\nAgreed, please focus on making the log configurable, but don\u0027t touch the *default* log format.","commit_id":"1cf54f0a968fb85744b39175f043b767960d811f"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"a563c30a5a1a55ce7d6730e14f47139c4ec4baab","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                    \u0027log message.\u0027),"},{"line_number":135,"context_line":"    cfg.StrOpt(\u0027logging_user_identity_format\u0027,"},{"line_number":136,"context_line":"               default\u003d\u0027%(user)s %(tenant)s \u0027"},{"line_number":137,"context_line":"                       \u0027%(domain)s %(user_domain)s %(project_domain)s\u0027,"},{"line_number":138,"context_line":"               help\u003d\u0027Format string for user_identity field of \u0027"},{"line_number":139,"context_line":"                    \u0027the logging_context_format_string\u0027),"},{"line_number":140,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_3c422e69","line":137,"in_reply_to":"7a2fa921_ce86fc64","updated":"2015-10-08 08:40:55.000000000","message":"Adding the strings(\"U:\", \"T:\", etc) is a great idea! I\u0027d like to update this patch, like you pointed.\n\n***\n\nBecause \"oslo_log/formatters.py\" imported \"oslo_context/context.py[1]\", I selected \"project_domain\".\n\nIf we use the \"tenant_domain\", I think \"oslo_context/context.py\" should be modified(only add \"tenant_domain\") before this patch is merged.\n\nIs it better to modify oslo_context and oslo_log?\n\nIf yes, I\u0027ll make another patch as oslo_context ASAP.\n\n[1]\n\nhttp://git.openstack.org/cgit/openstack/oslo.context/tree/oslo_context/context.py\n\n*The \"tenant_domain\" is not defined in oslo_context/context.py.\n\n*The \"project_domain\" has been already defined in oslo_context/context.py.","commit_id":"1cf54f0a968fb85744b39175f043b767960d811f"}],"oslo_log/formatters.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"a01767fb593e8aeba8f7e52d127197d82827032e","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        # \"to_dict()\" of oslo.context."},{"line_number":222,"context_line":"        if context:"},{"line_number":223,"context_line":"            record.__dict__[\u0027user_identity\u0027] \u003d ("},{"line_number":224,"context_line":"                self.conf.logging_user_identity_format % record.__dict__"},{"line_number":225,"context_line":"            )"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if record.__dict__.get(\u0027request_id\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_4c5dbc45","line":224,"updated":"2015-10-22 10:26:38.000000000","message":"The code in oslo.context is different. It replaces false values with \"-\":\n\n        user_idt \u003d (\n            self.user_idt_format.format(user\u003dself.user or \u0027-\u0027,\n                                        tenant\u003dself.tenant or \u0027-\u0027,\n                                        domain\u003dself.domain or \u0027-\u0027,\n                                        user_domain\u003dself.user_domain or \u0027-\u0027,\n                                        p_domain\u003dself.project_domain or \u0027-\u0027))\n\nYou should use:\n\nargs \u003d (user\u003dself.user or \u0027-\u0027,\n                                        tenant\u003dself.tenant or \u0027-\u0027,\n                                        domain\u003dself.domain or \u0027-\u0027,\n                                        user_domain\u003dself.user_domain or \u0027-\u0027,\n                                        p_domain\u003dself.project_domain or \u0027-\u0027)\nself.conf.logging_user_identity_format % args\n\nOr even create a custom dict-like object which replaces false values with \u0027-\u0027 on demand (if you plan to support more fields in user_identify format).","commit_id":"1cf54f0a968fb85744b39175f043b767960d811f"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"27be1904d72cdf0278f67c16b54e302bf3cb4611","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        # \"to_dict()\" of oslo.context."},{"line_number":222,"context_line":"        if context:"},{"line_number":223,"context_line":"            record.__dict__[\u0027user_identity\u0027] \u003d ("},{"line_number":224,"context_line":"                self.conf.logging_user_identity_format % record.__dict__"},{"line_number":225,"context_line":"            )"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if record.__dict__.get(\u0027request_id\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_a61c5dc2","line":224,"in_reply_to":"3a29b11f_4c5dbc45","updated":"2015-10-25 08:01:10.000000000","message":"\u003e Or even create a custom dict-like object which replaces false values with \u0027-\u0027 on demand (if you plan to support more fields in user_identify format).\n\nI will update here with like this.","commit_id":"1cf54f0a968fb85744b39175f043b767960d811f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"5006336a87a56fa944eebe84b58d6cc166539e4c","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        # by using \"logging_user_identity_format\" and"},{"line_number":221,"context_line":"        # \"to_dict()\" of oslo.context."},{"line_number":222,"context_line":"        if context:"},{"line_number":223,"context_line":"            record.__dict__[\u0027user_identity\u0027] \u003d ("},{"line_number":224,"context_line":"                self.conf.logging_user_identity_format % record.__dict__"},{"line_number":225,"context_line":"            ).replace(\u0027None\u0027, \u0027-\u0027)"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_07b401cf","line":223,"updated":"2015-11-04 19:59:12.000000000","message":"I think this is probably copying the pattern from line 217, but in this case since the name is static it can be simplified to\n\n  record.user_identity \u003d ...","commit_id":"49dfdea4992373c266d7cef2bd04d92200d10029"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"d1ceeecb75589d29413185223112a2de390c1eca","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        # by using \"logging_user_identity_format\" and"},{"line_number":221,"context_line":"        # \"to_dict()\" of oslo.context."},{"line_number":222,"context_line":"        if context:"},{"line_number":223,"context_line":"            record.__dict__[\u0027user_identity\u0027] \u003d ("},{"line_number":224,"context_line":"                self.conf.logging_user_identity_format % record.__dict__"},{"line_number":225,"context_line":"            ).replace(\u0027None\u0027, \u0027-\u0027)"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_20eeb2ec","line":223,"in_reply_to":"fa80f949_07b401cf","updated":"2015-11-05 12:36:15.000000000","message":"\u003e I think this is probably copying the pattern from line 217\n\noops, i didn\u0027t notice the existing code. setattr() would be better, but it\u0027s unrelated to this change.","commit_id":"49dfdea4992373c266d7cef2bd04d92200d10029"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"ca113a4815f79dc4c341bc49c84af1a35dcde49b","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        # by using \"logging_user_identity_format\" and"},{"line_number":221,"context_line":"        # \"to_dict()\" of oslo.context."},{"line_number":222,"context_line":"        if context:"},{"line_number":223,"context_line":"            record.__dict__[\u0027user_identity\u0027] \u003d ("},{"line_number":224,"context_line":"                self.conf.logging_user_identity_format % record.__dict__"},{"line_number":225,"context_line":"            ).replace(\u0027None\u0027, \u0027-\u0027)"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_e772fd48","line":223,"in_reply_to":"fa80f949_20eeb2ec","updated":"2015-11-10 12:16:01.000000000","message":"@Doug, It\u0027s simply. I\u0027d like to update this line like you pointed out.\n\n@Victor, Thank you for your comment :)","commit_id":"49dfdea4992373c266d7cef2bd04d92200d10029"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"5006336a87a56fa944eebe84b58d6cc166539e4c","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        # \"to_dict()\" of oslo.context."},{"line_number":222,"context_line":"        if context:"},{"line_number":223,"context_line":"            record.__dict__[\u0027user_identity\u0027] \u003d ("},{"line_number":224,"context_line":"                self.conf.logging_user_identity_format % record.__dict__"},{"line_number":225,"context_line":"            ).replace(\u0027None\u0027, \u0027-\u0027)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if record.__dict__.get(\u0027request_id\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_27dee511","line":224,"updated":"2015-11-04 19:59:12.000000000","message":"Should we pull values from the log record, or from the context? It seems like we want to use the context since we control that class.","commit_id":"49dfdea4992373c266d7cef2bd04d92200d10029"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"ca113a4815f79dc4c341bc49c84af1a35dcde49b","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        # \"to_dict()\" of oslo.context."},{"line_number":222,"context_line":"        if context:"},{"line_number":223,"context_line":"            record.__dict__[\u0027user_identity\u0027] \u003d ("},{"line_number":224,"context_line":"                self.conf.logging_user_identity_format % record.__dict__"},{"line_number":225,"context_line":"            ).replace(\u0027None\u0027, \u0027-\u0027)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if record.__dict__.get(\u0027request_id\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_a793954e","line":224,"in_reply_to":"fa80f949_27dee511","updated":"2015-11-10 12:16:01.000000000","message":"You\u0027re right, I\u0027d like to update this line to using the context.","commit_id":"49dfdea4992373c266d7cef2bd04d92200d10029"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"39ec7a90e86d51cc59b75b81404a05cdfa04d963","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        if context:"},{"line_number":223,"context_line":"            record.user_identity \u003d ("},{"line_number":224,"context_line":"                self.conf.logging_user_identity_format % context.__dict__"},{"line_number":225,"context_line":"            ).replace(\u0027None\u0027, \u0027-\u0027)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if record.__dict__.get(\u0027request_id\u0027):"},{"line_number":228,"context_line":"            fmt \u003d self.conf.logging_context_format_string"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_b8089492","line":225,"updated":"2015-11-10 13:26:23.000000000","message":".replace(\u0027None\u0027, \u0027-\u0027) is simple and future-proof, but there is a minor risk of replacing a legit log with \u0027-\u0027. In a previous comment, I proposed to implement something like this:\n\n class ReplaceNoneDict(dict):\n     def __getitem__(self, key):\n         value \u003d dict.get(self, key, None)\n         return (value or \u0027-\u0027)\n\n ns \u003d ReplaceNoneDict(name\u003d\u0027victor\u0027, key\u003d\u0027\u0027)\n print(\"name\u003d%(name)s key\u003d%(key)s other\u003d%(other)s\" % ns)\n\nOutput:\n\n name\u003dvictor key\u003d- other\u003d-\n\nWhat do you think?","commit_id":"c69dbdf53fd2b51a0b7d0a4f09b9e76c9f5ceacc"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"185a5638209b2c2798412ab00c29c9d37d713fd2","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        if context:"},{"line_number":223,"context_line":"            record.user_identity \u003d ("},{"line_number":224,"context_line":"                self.conf.logging_user_identity_format % context.__dict__"},{"line_number":225,"context_line":"            ).replace(\u0027None\u0027, \u0027-\u0027)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if record.__dict__.get(\u0027request_id\u0027):"},{"line_number":228,"context_line":"            fmt \u003d self.conf.logging_context_format_string"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_89663628","line":225,"in_reply_to":"da85f559_49812efa","updated":"2015-11-12 09:51:10.000000000","message":"Wait, I don\u0027t suggest to write a regex in your code. I\u0027m just saying that sys admins who want to parse logs usually use regex.","commit_id":"c69dbdf53fd2b51a0b7d0a4f09b9e76c9f5ceacc"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"6b3896742348d5b3710ef031b2a9d9a11d174c21","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        if context:"},{"line_number":223,"context_line":"            record.user_identity \u003d ("},{"line_number":224,"context_line":"                self.conf.logging_user_identity_format % context.__dict__"},{"line_number":225,"context_line":"            ).replace(\u0027None\u0027, \u0027-\u0027)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if record.__dict__.get(\u0027request_id\u0027):"},{"line_number":228,"context_line":"            fmt \u003d self.conf.logging_context_format_string"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_49812efa","line":225,"in_reply_to":"da85f559_70709ba4","updated":"2015-11-12 09:47:56.000000000","message":"Thank you for your comment. It\u0027s very kind of you.\n\nI\u0027d like to update this with adding private class and using regex.","commit_id":"c69dbdf53fd2b51a0b7d0a4f09b9e76c9f5ceacc"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"73b09d3e50ac28accd44fa7e79820396feb9e5b2","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        if context:"},{"line_number":223,"context_line":"            record.user_identity \u003d ("},{"line_number":224,"context_line":"                self.conf.logging_user_identity_format % context.__dict__"},{"line_number":225,"context_line":"            ).replace(\u0027None\u0027, \u0027-\u0027)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if record.__dict__.get(\u0027request_id\u0027):"},{"line_number":228,"context_line":"            fmt \u003d self.conf.logging_context_format_string"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_bef6c48c","line":225,"in_reply_to":"da85f559_89663628","updated":"2015-11-12 13:19:38.000000000","message":"Oh, I understand.\n\nI\u0027ll upload new patch sets.","commit_id":"c69dbdf53fd2b51a0b7d0a4f09b9e76c9f5ceacc"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"6a95ff731cf88febd6a3459e32bf8ad1922bdabf","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        if context:"},{"line_number":223,"context_line":"            record.user_identity \u003d ("},{"line_number":224,"context_line":"                self.conf.logging_user_identity_format % context.__dict__"},{"line_number":225,"context_line":"            ).replace(\u0027None\u0027, \u0027-\u0027)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if record.__dict__.get(\u0027request_id\u0027):"},{"line_number":228,"context_line":"            fmt \u003d self.conf.logging_context_format_string"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_70709ba4","line":225,"in_reply_to":"da85f559_aa5455c9","updated":"2015-11-12 08:37:05.000000000","message":"Oh wait, I read again my code and I realized that there is a bug in your code. oslo.context doesn\u0027t replace None, but any value with bool(value) equals to False: empty string, zero, etc. I would prefer to reproduce the same behaviour than oslo.context in oslo.log to get consistent logs.\n\nIt would be much harder to parse logs (ex: with a regex) where some fields are completly missing. It\u0027s much easier to have a \"-\" for missing values, it\u0027s easy to write \"(pattern|-)\" in a regex;\n\n\"May I add a new class in this file, like you pointed out?\"\n\nYeah, but make it private (add a _ prefix in this name). And define it a top level, not inside this function.","commit_id":"c69dbdf53fd2b51a0b7d0a4f09b9e76c9f5ceacc"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"21a658a261671f9266aa417275b9872ad50f6cc6","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        if context:"},{"line_number":223,"context_line":"            record.user_identity \u003d ("},{"line_number":224,"context_line":"                self.conf.logging_user_identity_format % context.__dict__"},{"line_number":225,"context_line":"            ).replace(\u0027None\u0027, \u0027-\u0027)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if record.__dict__.get(\u0027request_id\u0027):"},{"line_number":228,"context_line":"            fmt \u003d self.conf.logging_context_format_string"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_aa5455c9","line":225,"in_reply_to":"da85f559_b8089492","updated":"2015-11-12 05:11:26.000000000","message":"That make sense.\n\nI think that replacing value(None) with string(\"-\") is better than replacing string(\"None\") with string(\"-\") using .replace().\n\nMay I add a new class in this file, like you pointed out?","commit_id":"c69dbdf53fd2b51a0b7d0a4f09b9e76c9f5ceacc"}],"oslo_log/tests/unit/test_log.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a4a08e8b95870fdced81a8deb674c21ca15913bb","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        self.assertEqual(expected, self.stream.getvalue())"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"class UserIdentityTestCase(LogTestBase):"},{"line_number":427,"context_line":"    def setUp(self):"},{"line_number":428,"context_line":"        super(UserIdentityTestCase, self).setUp()"},{"line_number":429,"context_line":"        self.config(logging_context_format_string\u003d\"HAS CONTEXT \""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_b14e8694","line":426,"updated":"2015-08-28 12:54:46.000000000","message":"Any reason not to make the tests part of ContextFormatterTestCase and reuse its setUp()?","commit_id":"756d8415f9174cc775e80ab04382c4b52ccccfa3"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"87d070b0ce6c08bfb2aa393efde4af9c705f52b4","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        self.assertEqual(expected, self.stream.getvalue())"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"class UserIdentityTestCase(LogTestBase):"},{"line_number":427,"context_line":"    def setUp(self):"},{"line_number":428,"context_line":"        super(UserIdentityTestCase, self).setUp()"},{"line_number":429,"context_line":"        self.config(logging_context_format_string\u003d\"HAS CONTEXT \""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_5ab4dfcf","line":426,"in_reply_to":"da20952f_b14e8694","updated":"2015-08-28 13:50:09.000000000","message":"Because it seems that the \"user_identity\" is not defined in  ContextFormatterTestCase, I added new TestCase.\n\nBut, it seems that is not necessary.\n\nI\u0027ll add these to the \"ContextFormatterTestCase\".","commit_id":"756d8415f9174cc775e80ab04382c4b52ccccfa3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a4a08e8b95870fdced81a8deb674c21ca15913bb","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        ctxt.request_id \u003d six.text_type(\u0027100\u0027)"},{"line_number":465,"context_line":"        ctxt.user \u003d \"myuser\""},{"line_number":466,"context_line":"        ctxt.tenant \u003d \"mytenant\""},{"line_number":467,"context_line":"        ctxt.user_identity \u003d ctxt.user + \u0027 \u0027 + ctxt.tenant"},{"line_number":468,"context_line":"        message \u003d self.trans_fixture.lazy(\u0027test \u0027 + six.unichr(128))"},{"line_number":469,"context_line":"        self.log.info(message, context\u003dctxt)"},{"line_number":470,"context_line":"        expected \u003d \"HAS CONTEXT [%s %s]: %s\\n\" % (ctxt.request_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_740d3c36","line":467,"updated":"2015-08-28 12:54:46.000000000","message":"You should not set it on the context object here to make sure the format string is applied, and not f.e. the value from the context object.","commit_id":"756d8415f9174cc775e80ab04382c4b52ccccfa3"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"87d070b0ce6c08bfb2aa393efde4af9c705f52b4","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        ctxt.request_id \u003d six.text_type(\u0027100\u0027)"},{"line_number":465,"context_line":"        ctxt.user \u003d \"myuser\""},{"line_number":466,"context_line":"        ctxt.tenant \u003d \"mytenant\""},{"line_number":467,"context_line":"        ctxt.user_identity \u003d ctxt.user + \u0027 \u0027 + ctxt.tenant"},{"line_number":468,"context_line":"        message \u003d self.trans_fixture.lazy(\u0027test \u0027 + six.unichr(128))"},{"line_number":469,"context_line":"        self.log.info(message, context\u003dctxt)"},{"line_number":470,"context_line":"        expected \u003d \"HAS CONTEXT [%s %s]: %s\\n\" % (ctxt.request_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_5a713fdf","line":467,"in_reply_to":"da20952f_740d3c36","updated":"2015-08-28 13:50:09.000000000","message":"It is very kind of you.\n\nI\u0027d like to modify this line.","commit_id":"756d8415f9174cc775e80ab04382c4b52ccccfa3"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"a01767fb593e8aeba8f7e52d127197d82827032e","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                                                  \"%(user_identity)s]: \""},{"line_number":429,"context_line":"                                                  \"%(message)s\")"},{"line_number":430,"context_line":"        ctxt \u003d _fake_context()"},{"line_number":431,"context_line":"        ctxt.request_id \u003d six.text_type(\u002799\u0027)"},{"line_number":432,"context_line":"        ctxt.user \u003d \"myuser\""},{"line_number":433,"context_line":"        ctxt.tenant \u003d \"mytenant\""},{"line_number":434,"context_line":"        ctxt.domain \u003d \"mydomain\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_8c37544c","line":431,"updated":"2015-10-22 10:26:38.000000000","message":"write directly: u\u002799\u0027","commit_id":"1cf54f0a968fb85744b39175f043b767960d811f"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"27be1904d72cdf0278f67c16b54e302bf3cb4611","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                                                  \"%(user_identity)s]: \""},{"line_number":429,"context_line":"                                                  \"%(message)s\")"},{"line_number":430,"context_line":"        ctxt \u003d _fake_context()"},{"line_number":431,"context_line":"        ctxt.request_id \u003d six.text_type(\u002799\u0027)"},{"line_number":432,"context_line":"        ctxt.user \u003d \"myuser\""},{"line_number":433,"context_line":"        ctxt.tenant \u003d \"mytenant\""},{"line_number":434,"context_line":"        ctxt.domain \u003d \"mydomain\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_e6cd755e","line":431,"in_reply_to":"3a29b11f_8c37544c","updated":"2015-10-25 08:01:10.000000000","message":"Done","commit_id":"1cf54f0a968fb85744b39175f043b767960d811f"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"a01767fb593e8aeba8f7e52d127197d82827032e","unresolved":false,"context_lines":[{"line_number":434,"context_line":"        ctxt.domain \u003d \"mydomain\""},{"line_number":435,"context_line":"        ctxt.user_domain \u003d \"myuserdomain\""},{"line_number":436,"context_line":"        ctxt.project_domain \u003d \"myprojectdomain\""},{"line_number":437,"context_line":"        message \u003d self.trans_fixture.lazy(\u0027test \u0027 + six.unichr(128))"},{"line_number":438,"context_line":"        self.log.info(message, context\u003dctxt)"},{"line_number":439,"context_line":"        expected \u003d (\"HAS CONTEXT [%s %s %s %s %s %s]: %s\\n\" %"},{"line_number":440,"context_line":"                    (ctxt.request_id, ctxt.user, ctxt.tenant, ctxt.domain,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_cc31cc5b","line":437,"updated":"2015-10-22 10:26:38.000000000","message":"If you want to test non-ascii message, use something like:\n\nu\u0027test \\xe9\u0027\n\nDo we really need to translate in this unit test?","commit_id":"1cf54f0a968fb85744b39175f043b767960d811f"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"27be1904d72cdf0278f67c16b54e302bf3cb4611","unresolved":false,"context_lines":[{"line_number":434,"context_line":"        ctxt.domain \u003d \"mydomain\""},{"line_number":435,"context_line":"        ctxt.user_domain \u003d \"myuserdomain\""},{"line_number":436,"context_line":"        ctxt.project_domain \u003d \"myprojectdomain\""},{"line_number":437,"context_line":"        message \u003d self.trans_fixture.lazy(\u0027test \u0027 + six.unichr(128))"},{"line_number":438,"context_line":"        self.log.info(message, context\u003dctxt)"},{"line_number":439,"context_line":"        expected \u003d (\"HAS CONTEXT [%s %s %s %s %s %s]: %s\\n\" %"},{"line_number":440,"context_line":"                    (ctxt.request_id, ctxt.user, ctxt.tenant, ctxt.domain,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_86acc18d","line":437,"in_reply_to":"3a29b11f_cc31cc5b","updated":"2015-10-25 08:01:10.000000000","message":"\u003eDo we really need to translate in this unit test?\n\nIt does not seem to be necessary to translate it. I remove this.","commit_id":"1cf54f0a968fb85744b39175f043b767960d811f"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"a01767fb593e8aeba8f7e52d127197d82827032e","unresolved":false,"context_lines":[{"line_number":632,"context_line":"    def test_domain_in_log_msg(self):"},{"line_number":633,"context_line":"        ctxt \u003d _fake_context()"},{"line_number":634,"context_line":"        ctxt.user \u003d \"None\""},{"line_number":635,"context_line":"        ctxt.tenant \u003d \"None\""},{"line_number":636,"context_line":"        ctxt.domain \u003d \u0027mydomain\u0027"},{"line_number":637,"context_line":"        ctxt.project_domain \u003d \u0027myprojectdomain\u0027"},{"line_number":638,"context_line":"        ctxt.user_domain \u003d \u0027myuserdomain\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_8c5c347e","line":635,"updated":"2015-10-22 10:26:38.000000000","message":"You may move these assignments to _fake_context() instead (and use \"myuser\" and \"mytenant\" for user \u0026 tenant).","commit_id":"1cf54f0a968fb85744b39175f043b767960d811f"},{"author":{"_account_id":14162,"name":"Daisuke Fujita","email":"fuzita.daisuke@jp.fujitsu.com","username":"daisukefujita"},"change_message_id":"27be1904d72cdf0278f67c16b54e302bf3cb4611","unresolved":false,"context_lines":[{"line_number":632,"context_line":"    def test_domain_in_log_msg(self):"},{"line_number":633,"context_line":"        ctxt \u003d _fake_context()"},{"line_number":634,"context_line":"        ctxt.user \u003d \"None\""},{"line_number":635,"context_line":"        ctxt.tenant \u003d \"None\""},{"line_number":636,"context_line":"        ctxt.domain \u003d \u0027mydomain\u0027"},{"line_number":637,"context_line":"        ctxt.project_domain \u003d \u0027myprojectdomain\u0027"},{"line_number":638,"context_line":"        ctxt.user_domain \u003d \u0027myuserdomain\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_c625d90a","line":635,"in_reply_to":"3a29b11f_8c5c347e","updated":"2015-10-25 08:01:10.000000000","message":"I\u0027d like to move these assignments to _fake_context().","commit_id":"1cf54f0a968fb85744b39175f043b767960d811f"}]}
