)]}'
{"oslo_log/formatters.py":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"c578df9008dbd9cdd5d7b293826881da9ecf6bac","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        # NOTE(jkoelker) we ignore the fmt argument, but its still there"},{"line_number":68,"context_line":"        #                since logging.config.fileConfig passes it."},{"line_number":69,"context_line":"        self.datefmt \u003d datefmt"},{"line_number":70,"context_line":"        self.hostname \u003d gethostname()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def formatException(self, ei, strip_newlines\u003dTrue):"},{"line_number":73,"context_line":"        lines \u003d traceback.format_exception(*ei)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_bb2e0af9","line":70,"updated":"2015-09-30 10:18:31.000000000","message":"Can you please add some defensive code?\n\n        try:\n            hostname \u003d socket.gethostname()\n        except socket.error:\n            hostname \u003d None","commit_id":"433c7c1b1be8028e2fe85f818cd99ea941a45722"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"8d3ddcd58405b54356fa13bf90d3f1619bb2539f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        # NOTE(jkoelker) we ignore the fmt argument, but its still there"},{"line_number":68,"context_line":"        #                since logging.config.fileConfig passes it."},{"line_number":69,"context_line":"        self.datefmt \u003d datefmt"},{"line_number":70,"context_line":"        self.hostname \u003d gethostname()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def formatException(self, ei, strip_newlines\u003dTrue):"},{"line_number":73,"context_line":"        lines \u003d traceback.format_exception(*ei)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_eec36236","line":70,"in_reply_to":"9a1a9d01_bb2e0af9","updated":"2015-09-30 10:44:01.000000000","message":"I will. Thank you for pointing out.","commit_id":"433c7c1b1be8028e2fe85f818cd99ea941a45722"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"7c7635dbab830617aa8259a944a989c193d8d529","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        #                since logging.config.fileConfig passes it."},{"line_number":69,"context_line":"        self.datefmt \u003d datefmt"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            self.hostname \u003d socket.gethostname()"},{"line_number":72,"context_line":"        except socket.error:"},{"line_number":73,"context_line":"            self.hostname \u003d None"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_8cbf69a9","line":71,"updated":"2015-10-08 20:40:05.000000000","message":"Would it be more useful to use getfqdn()?\n\nhttps://docs.python.org/2.7/library/socket.html#socket.getfqdn","commit_id":"7d190970e33fe964673c61afe4b7d837dadca5cb"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"f07682fa539ebe874ab11a5e0652d0449a5c1ea0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        #                since logging.config.fileConfig passes it."},{"line_number":69,"context_line":"        self.datefmt \u003d datefmt"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            self.hostname \u003d socket.gethostname()"},{"line_number":72,"context_line":"        except socket.error:"},{"line_number":73,"context_line":"            self.hostname \u003d None"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_addfbf67","line":71,"in_reply_to":"7a2fa921_8cbf69a9","updated":"2015-10-08 21:44:15.000000000","message":"+1 for using fqdn vs just hostname.","commit_id":"7d190970e33fe964673c61afe4b7d837dadca5cb"}]}