)]}'
{"oslo_log/formatters.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"1648e854396ad5c75ea3e5199c24f6e3df64126a","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                self.conf.logging_debug_format_suffix):"},{"line_number":255,"context_line":"            fmt +\u003d \" \" + self.conf.logging_debug_format_suffix"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        # set iso8601 timestamp"},{"line_number":258,"context_line":"        localtz \u003d tz.tzlocal()"},{"line_number":259,"context_line":"        record.isotime \u003d datetime.datetime.fromtimestamp("},{"line_number":260,"context_line":"            record.created).replace(tzinfo\u003dlocaltz).isoformat()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_65549352","line":257,"updated":"2015-12-28 16:01:10.000000000","message":"Log message formatting happens *a lot*, so I\u0027m a little worried about performance here. I see in the logging docs [1] that the timestamp for a message is only constructed if \u0027(asctime)\u0027 appears in the format string. We do something similar for \u0027(isotime)\u0027 by checking for the substring once when the formatter is created, then use the results to add isotime to the record only when it\u0027s going to be used.\n\nWhat do you think?\n\n[1] https://docs.python.org/2/library/logging.html#logging.Formatter.format","commit_id":"be6478384df572e15e719c92aa833f23712ed713"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"dd943de43bf561eab37287b45009787ff5b55a9d","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                self.conf.logging_debug_format_suffix):"},{"line_number":255,"context_line":"            fmt +\u003d \" \" + self.conf.logging_debug_format_suffix"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        # set iso8601 timestamp"},{"line_number":258,"context_line":"        localtz \u003d tz.tzlocal()"},{"line_number":259,"context_line":"        record.isotime \u003d datetime.datetime.fromtimestamp("},{"line_number":260,"context_line":"            record.created).replace(tzinfo\u003dlocaltz).isoformat()"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_02bb7e28","line":257,"in_reply_to":"1a7b0d38_65549352","updated":"2016-01-04 11:25:10.000000000","message":"Makes a lot of sense to me","commit_id":"be6478384df572e15e719c92aa833f23712ed713"}]}