)]}'
{"oslo_log/formatters.py":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"aff7726fad71f62356874b306ca90657cdeb83c0","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        self.project \u003d kwargs.pop(\u0027project\u0027, \u0027unknown\u0027)"},{"line_number":174,"context_line":"        self.version \u003d kwargs.pop(\u0027version\u0027, \u0027unknown\u0027)"},{"line_number":175,"context_line":"        self.conf \u003d kwargs.pop(\u0027config\u0027, _CONF)"},{"line_number":176,"context_line":"        self._add_isotime_cache \u003d None"},{"line_number":177,"context_line":"        logging.Formatter.__init__(self, *args, **kwargs)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_d2be6364","line":176,"updated":"2016-01-05 11:49:07.000000000","message":"I\u0027d rather not cache this, if the logging_context_format_string becomes mutable we\u0027ll need to invalidate the cache. logging.Formatter checks the format for asctime every time, I think that\u0027s acceptable for us as well.","commit_id":"6959a373f707e18390b217e6178ca16879d03b07"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"a7459acf1793b3ccaf4b265d2ea12d871d7eb7b1","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        self.project \u003d kwargs.pop(\u0027project\u0027, \u0027unknown\u0027)"},{"line_number":174,"context_line":"        self.version \u003d kwargs.pop(\u0027version\u0027, \u0027unknown\u0027)"},{"line_number":175,"context_line":"        self.conf \u003d kwargs.pop(\u0027config\u0027, _CONF)"},{"line_number":176,"context_line":"        self._add_isotime_cache \u003d None"},{"line_number":177,"context_line":"        logging.Formatter.__init__(self, *args, **kwargs)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_f97907fd","line":176,"in_reply_to":"fa69d971_2053d7e3","updated":"2016-01-11 11:04:15.000000000","message":"So what are we going to do? We might get slightly better performance by scanning the format string just once for asctime, isotime and whatever the 3rd thing is. There\u0027s an overridable method on logging.Formatter which will allow that. I think that\u0027s the best we can do without caching.","commit_id":"6959a373f707e18390b217e6178ca16879d03b07"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"830fdd6be154c5e7faa2b335224e92d755f2d3c7","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        self.project \u003d kwargs.pop(\u0027project\u0027, \u0027unknown\u0027)"},{"line_number":174,"context_line":"        self.version \u003d kwargs.pop(\u0027version\u0027, \u0027unknown\u0027)"},{"line_number":175,"context_line":"        self.conf \u003d kwargs.pop(\u0027config\u0027, _CONF)"},{"line_number":176,"context_line":"        self._add_isotime_cache \u003d None"},{"line_number":177,"context_line":"        logging.Formatter.__init__(self, *args, **kwargs)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_2053d7e3","line":176,"in_reply_to":"fa69d971_d2be6364","updated":"2016-01-05 16:59:23.000000000","message":"There are going to be all sorts of complexity involved in resetting logging when anything changes, but I see your point. I was worried about the performance of the 3 string checks on each log call, though I don\u0027t know if that\u0027s better or worse than the method call to access the property value.","commit_id":"6959a373f707e18390b217e6178ca16879d03b07"}]}