)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"35a5c665d9430f64518ab9b28ad55d4350d4e3a7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Unit test cleanup and validation improvements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Refactor duplicated hard-coded strings to variables for validation"},{"line_number":10,"context_line":"* Standardized on single quotes for string values"},{"line_number":11,"context_line":"* Ensure order of parameters for assertEqual is (expected, actual)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I96f61ae9a3d3a7ec313f22cd19efe58c00d26856"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aed3d3a_aab7a5f3","line":10,"updated":"2016-02-29 11:32:03.000000000","message":"This change is causing a lot of churn for no benefit I can discern, I\u0027d prefer it wasn\u0027t made","commit_id":"81119b9b9e1a9120d81cd86fb1fa21476efb5a59"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"ea1b7b2988ade6df0d945e512baa0d055c18094d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Unit test cleanup and validation improvements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Refactor duplicated hard-coded strings to variables for validation"},{"line_number":10,"context_line":"* Standardized on single quotes for string values"},{"line_number":11,"context_line":"* Ensure order of parameters for assertEqual is (expected, actual)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I96f61ae9a3d3a7ec313f22cd19efe58c00d26856"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aed3d3a_e5c8ae24","line":10,"in_reply_to":"9aed3d3a_5f8b27c3","updated":"2016-02-29 16:21:10.000000000","message":"Thanks for the reference Alexis, I was not aware of it.\n\nI am not proposing to fix this across OpenStack, however there is nothing wrong with improving the little part of the world I work in.  As for time,  FWIW, I spent a little bit of time on a Friday (so lets say \u003c10% of my week) on these improvements. It was a way to take the edge of the week, do something while we are in a freeze and still read and write  code and add value to OpenStack.  \n\nI do not consider this a large change. I will let the team decide.","commit_id":"81119b9b9e1a9120d81cd86fb1fa21476efb5a59"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"b7e600621fdc625df6787cb74d99d3d4abb3ada7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Unit test cleanup and validation improvements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Refactor duplicated hard-coded strings to variables for validation"},{"line_number":10,"context_line":"* Standardized on single quotes for string values"},{"line_number":11,"context_line":"* Ensure order of parameters for assertEqual is (expected, actual)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I96f61ae9a3d3a7ec313f22cd19efe58c00d26856"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aed3d3a_f004fc4a","line":10,"in_reply_to":"9aed3d3a_aab7a5f3","updated":"2016-02-29 12:18:27.000000000","message":"yeah, make it difficult to blame :-)","commit_id":"81119b9b9e1a9120d81cd86fb1fa21476efb5a59"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"d62d309e0fc50fd0e0b5435c9f10602ba5f4f244","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Unit test cleanup and validation improvements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Refactor duplicated hard-coded strings to variables for validation"},{"line_number":10,"context_line":"* Standardized on single quotes for string values"},{"line_number":11,"context_line":"* Ensure order of parameters for assertEqual is (expected, actual)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I96f61ae9a3d3a7ec313f22cd19efe58c00d26856"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aed3d3a_5f8b27c3","line":10,"in_reply_to":"9aed3d3a_ae884b72","updated":"2016-02-29 15:57:47.000000000","message":"PEP8 does say \"pick a style and stick to it\" re: quotes. It also says \"A Foolish Consistency is the Hobgoblin of Little Minds\". Are you proposing to fix this across OpenStack? Would that be a good use of your time and core reviewers\u0027?\n\nWe all like readable code, quality, consistency etc. You may find mixed quoting bothersome, I don\u0027t. I don\u0027t care if you choose to be quote-consistent but I object to a very large change to make it so.","commit_id":"81119b9b9e1a9120d81cd86fb1fa21476efb5a59"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"26e575f22268d1b706cb9d8757e44409f4842702","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Unit test cleanup and validation improvements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Refactor duplicated hard-coded strings to variables for validation"},{"line_number":10,"context_line":"* Standardized on single quotes for string values"},{"line_number":11,"context_line":"* Ensure order of parameters for assertEqual is (expected, actual)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I96f61ae9a3d3a7ec313f22cd19efe58c00d26856"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aed3d3a_ae884b72","line":10,"in_reply_to":"9aed3d3a_f004fc4a","updated":"2016-02-29 15:10:06.000000000","message":"As with any change there can be at least two sides of the discussion, and so here is my rationale, and I welcome further discussion.\n\nThe first side as I propose in this change is it would be nice to be more consistent.  Being consistently inconsistent is a by product of the past. I do not want to just contribute code to OpenStack, I want to also improve the quality, the readability and consistency of the code that will live on. \n\nThis file has a mixture of single and double quoted strings. I could just leave it, (annoying as it is), or as this is code and associated tests I regularly look at, and what to also improve I could make it more readable.\n\nThe second side as proposed is this has caused some churn.  A lot would be the majority of the file, so I would like to say this is a moderate amount. I also would like to say there is a benefit to the comment of no benefit, and while true the default git blame may show the last person that modified a line, there are multiple means to identify the origin of the line in code, if not when the most simple method of a command now does not produce the original author.  In more complex code it regularly does not show the history, just the last occurrence.  I would argue that if my changes made it impossible to identify the origin then that would be a problem.\n\nIt is a debate that there is no right answer in absence of a documented standard.\n\nIt is quoted that code is \"read\" a 100 times to the 1 time it is \"written\". As I continue to improve these tests of an integral part of many OpenStack projects, I wish to contribute not just improved tests and coverage, but to the readability of myself and hopefully many others.","commit_id":"81119b9b9e1a9120d81cd86fb1fa21476efb5a59"}],"oslo_log/tests/unit/test_log.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cd08cdc54cd41c19b1b2aad7f909597380570e04","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def test_log_path_logfile(self):"},{"line_number":191,"context_line":"        path \u003d \u0027/some/path\u0027"},{"line_number":192,"context_line":"        prefix \u003d \u0027foo-bar\u0027"},{"line_number":193,"context_line":"        expected \u003d \u0027%s/%s.log\u0027 % (path, prefix)"},{"line_number":194,"context_line":"        self.config(log_file\u003dexpected)"},{"line_number":195,"context_line":"        self.assertEqual(log._get_log_file_path(self.config_fixture.conf,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_80511ddb","line":192,"updated":"2016-03-08 17:10:03.000000000","message":"why prefix? the argument is called binary and this isn\u0027t prefixed?\n\nThis applies to other changes, too.","commit_id":"983164ed79e1709d1ad20b37f5ba778eebf8c676"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cd08cdc54cd41c19b1b2aad7f909597380570e04","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        sys.stderr \u003d error"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"    def _validate_keys(self, ctxt, keyed_log_string):"},{"line_number":613,"context_line":"        infocolor \u003d handlers.ColorHandler.LEVEL_COLORS[logging.INFO]"},{"line_number":614,"context_line":"        warncolor \u003d handlers.ColorHandler.LEVEL_COLORS[logging.WARN]"},{"line_number":615,"context_line":"        info_msg \u003d \u0027info\u0027"},{"line_number":616,"context_line":"        warn_msg \u003d \u0027warn\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_00b86de4","line":613,"updated":"2016-03-08 17:10:03.000000000","message":"there should be a test that validates that handlers.ColorHandler.LEVEL_COLORS[logging.INFO] is \u0027\\033[00;36m\u0027 (same for the other colors)","commit_id":"983164ed79e1709d1ad20b37f5ba778eebf8c676"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cd08cdc54cd41c19b1b2aad7f909597380570e04","unresolved":false,"context_lines":[{"line_number":649,"context_line":"    def test_resource_key_dict_in_log_msg(self):"},{"line_number":650,"context_line":"        infocolor \u003d handlers.ColorHandler.LEVEL_COLORS[logging.INFO]"},{"line_number":651,"context_line":"        ctxt \u003d _fake_context()"},{"line_number":652,"context_line":"        resource_type \u003d \u0027fake_resource\u0027"},{"line_number":653,"context_line":"        resource_id \u003d \u0027202260f9-1224-490d-afaf-6a744c13141f\u0027"},{"line_number":654,"context_line":"        fake_resource \u003d {\u0027type\u0027: \u0027fake_resource\u0027,"},{"line_number":655,"context_line":"                         \u0027id\u0027: resource_id}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_a0c5393d","line":652,"updated":"2016-03-08 17:10:03.000000000","message":"it would be great if these marker strings were switched to random strings rather than hardcoded, for example use mock.sentinel.resource_type or self.getUniqueString()","commit_id":"983164ed79e1709d1ad20b37f5ba778eebf8c676"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"4a7c299c2c72a9a28d2b5b09a0cc5bbc1ddd5f0c","unresolved":false,"context_lines":[{"line_number":649,"context_line":"    def test_resource_key_dict_in_log_msg(self):"},{"line_number":650,"context_line":"        infocolor \u003d handlers.ColorHandler.LEVEL_COLORS[logging.INFO]"},{"line_number":651,"context_line":"        ctxt \u003d _fake_context()"},{"line_number":652,"context_line":"        resource_type \u003d \u0027fake_resource\u0027"},{"line_number":653,"context_line":"        resource_id \u003d \u0027202260f9-1224-490d-afaf-6a744c13141f\u0027"},{"line_number":654,"context_line":"        fake_resource \u003d {\u0027type\u0027: \u0027fake_resource\u0027,"},{"line_number":655,"context_line":"                         \u0027id\u0027: resource_id}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_19d3c705","line":652,"in_reply_to":"5aef4532_a0c5393d","updated":"2016-03-08 18:25:50.000000000","message":"While I do not disagree these strings could be more randomized, the same argument could be said for many variables in these tests. \nThis would constitute a more larger change here and I feel is warranted in a separate review for this improvement.","commit_id":"983164ed79e1709d1ad20b37f5ba778eebf8c676"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cd08cdc54cd41c19b1b2aad7f909597380570e04","unresolved":false,"context_lines":[{"line_number":865,"context_line":"        self.CONF([])"},{"line_number":866,"context_line":"        self.CONF.print_help(file\u003df)"},{"line_number":867,"context_line":"        for option in [\u0027debug\u0027, \u0027verbose\u0027, \u0027log-config\u0027, \u0027watch-log-file\u0027]:"},{"line_number":868,"context_line":"            self.assertTrue(option in f.getvalue())"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"    def test_debug_verbose(self):"},{"line_number":871,"context_line":"        self.CONF([\u0027--debug\u0027, \u0027--verbose\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_00398d41","line":868,"updated":"2016-03-08 17:10:03.000000000","message":"(unrelated) use assertIn()","commit_id":"983164ed79e1709d1ad20b37f5ba778eebf8c676"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cd08cdc54cd41c19b1b2aad7f909597380570e04","unresolved":false,"context_lines":[{"line_number":1026,"context_line":"    def test_include_constructor_extras(self):"},{"line_number":1027,"context_line":"        d \u003d {\u0027foo\u0027: \u0027blah\u0027}"},{"line_number":1028,"context_line":"        key \u003d list(d.keys())[0]"},{"line_number":1029,"context_line":"        val \u003d list(d.values())[0]"},{"line_number":1030,"context_line":"        a \u003d log.KeywordArgumentAdapter(self.mock_log, d)"},{"line_number":1031,"context_line":"        msg, kwargs \u003d a.process(\u0027message\u0027, {})"},{"line_number":1032,"context_line":"        self.assertEqual(kwargs,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_801c7dc2","line":1029,"updated":"2016-03-08 17:10:03.000000000","message":"this would be easier to follow if it was\n\n key \u003d \u0027foo\u0027\n val \u003d \u0027blah\u0027\n d \u003d {key : val}\n\nThis applies in other places, too, like test_pass_args_to_log","commit_id":"983164ed79e1709d1ad20b37f5ba778eebf8c676"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cd08cdc54cd41c19b1b2aad7f909597380570e04","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"             \u0027instance\u0027: \u0027instance identifier\u0027,"},{"line_number":1048,"context_line":"             \u0027resource_uuid\u0027: \u0027UUID for instance\u0027,"},{"line_number":1049,"context_line":"             \u0027anything\u0027: \u0027goes\u0027}"},{"line_number":1050,"context_line":"        e \u003d copy.copy(d)"},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"        msg, kwargs \u003d a.process(\u0027message\u0027, d)"},{"line_number":1053,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_208489d2","line":1050,"updated":"2016-03-08 17:10:03.000000000","message":"this needs a more descriptive name than \"e\". is it short for exception?","commit_id":"983164ed79e1709d1ad20b37f5ba778eebf8c676"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cd08cdc54cd41c19b1b2aad7f909597380570e04","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"    _MSG \u003d u\u0027Message with unicode char \\ua000 in the middle\u0027"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"    def test_ascii_to_unicode(self):"},{"line_number":1117,"context_line":"        msg \u003d UnicodeConversionTestCase._MSG"},{"line_number":1118,"context_line":"        enc_msg \u003d msg.encode(\u0027utf-8\u0027)"},{"line_number":1119,"context_line":"        result \u003d log._ensure_unicode(enc_msg)"},{"line_number":1120,"context_line":"        self.assertEqual(msg, result)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_60dcd1e4","line":1117,"updated":"2016-03-08 17:10:03.000000000","message":"use self._MSG","commit_id":"983164ed79e1709d1ad20b37f5ba778eebf8c676"}]}
