)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"ef9bfcc062d94a74cc68e45b12272a9e9c0018f7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of tests use different method of"},{"line_number":10,"context_line":"assertTrue(isinstance(A, B)) or assertEqual(type(A), B)."},{"line_number":11,"context_line":"The correct way is to use assertIsInstance(A, B) provided"},{"line_number":12,"context_line":"by testtools"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I85a3ffe7fb29b0c5cd0d298d314172440feae96e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a98d1f4_799ad564","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":12},"updated":"2016-09-30 07:51:51.000000000","message":"Both ways are correct... \n\nFor the story, assertIsInstance/assertIsNone/assertIn wasn\u0027t exiting on py26 that why openstack have ton of that ! This new methods just reduce the line length that\u0027s all, but anyways ...","commit_id":"553fedc0b0f397f56256183cdf8d3b4d53d4db2b"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"bfce0ca6d821f9d1ab583c832ad50d8d769703c0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of tests use different method of"},{"line_number":10,"context_line":"assertTrue(isinstance(A, B)) or assertEqual(type(A), B)."},{"line_number":11,"context_line":"The correct way is to use assertIsInstance(A, B) provided"},{"line_number":12,"context_line":"by testtools"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I85a3ffe7fb29b0c5cd0d298d314172440feae96e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a98d1f4_72672e4d","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":12},"in_reply_to":"3a98d1f4_799ad564","updated":"2016-09-30 15:26:57.000000000","message":"The other benefit of doing specific asserts instead of assertTrue is that you will generally get a more useful error message if they fail.  assertTrue just says \"False is not True\" where assertIsInstance will presumably say \"Foo is not an instance of Bar\" or something like that.","commit_id":"553fedc0b0f397f56256183cdf8d3b4d53d4db2b"}]}
