)]}'
{"oslo_log/cmds/convert_json.py":[{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"9f113aaa23e6210ba023fae3d1cadffb983605cf","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"termcolor \u003d importutils.try_import(\u0027termcolor\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from oslo_log import log"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_USE_COLOR \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_75b871e6","side":"PARENT","line":26,"range":{"start_line":26,"start_character":21,"end_line":26,"end_character":24},"updated":"2016-11-14 12:19:28.000000000","message":"If there were any problems with this import, the tox pep8 tests would always fail. You are right, that import statements should be sorted alphabetically, but there may be several separated groups of them. As I know, it is a good practice to have 3 groups for: built-in modules, third-party libraries and local modules within the same project (exactly in this order). And in this case everything is correct. So this patch doesn\u0027t fix anything, it only breaks another code convention.","commit_id":"eca5c587a8daf6f2716ebde46490e1651d8c3c12"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0f3daa750e8960b5ecfbe1d1acac2c84e77e5947","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"termcolor \u003d importutils.try_import(\u0027termcolor\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from oslo_log import log"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_USE_COLOR \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_dc76b805","side":"PARENT","line":26,"range":{"start_line":26,"start_character":21,"end_line":26,"end_character":24},"in_reply_to":"9a629dbe_75b871e6","updated":"2016-11-14 17:03:52.000000000","message":"FTR, pep8 doesn\u0027t test import grouping.  I know this because I tried very hard to write that test and it turns out to be nearly impossible, unless you\u0027re willing to accept some false positives (which we\u0027re not).\n\nThat said, I agree this change is wrong.  oslo_log is the local project here so the import should be in the final group, not the third-party group.","commit_id":"eca5c587a8daf6f2716ebde46490e1651d8c3c12"}]}