)]}'
{"oslo_log/cmds/convert_json.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"ecab4f6ccf87129e15f4ed0873fc720ac47e9b64","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    record \u003d collections.defaultdict(str, record)"},{"line_number":151,"context_line":"    # skip if the record doesn\u0027t match a logger we are looking at"},{"line_number":152,"context_line":"    if len(loggers) \u003e 0:"},{"line_number":153,"context_line":"        name \u003d record.get(\u0027name\u0027)"},{"line_number":154,"context_line":"        if name not in loggers:"},{"line_number":155,"context_line":"            return"},{"line_number":156,"context_line":"    if len(levels) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_0508fd27","line":153,"updated":"2017-01-24 21:46:37.000000000","message":"Should this be the following?\n\n    name \u003d record.get(\u0027name\u0027)\n    if not any(n.startswith(name) for n in loggers):\n        return\n\nI\u0027d asssume u\u0027d want prefix match, and not equalite match which seems to match more of what people doing logging want.\n\nThat way you could say provide --loggers nova\n\nAnd you\u0027d also get/see messages emitted by the nova.virt logger (for example).","commit_id":"098b5ab4aa29e0d542d36478dd0da6d770519a73"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"1ff135b5a51758150c0e6de12e93f3e6d003a7dc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    parser.add_argument(\"-n\", \"--lines\","},{"line_number":85,"context_line":"                        required\u003dFalse, type\u003dint,"},{"line_number":86,"context_line":"                        help\u003d\"Last N number of records to view.\""},{"line_number":87,"context_line":"                             \" (Not Compatable with --loggers or --levels)\")"},{"line_number":88,"context_line":"    parser.add_argument(\"--loggers\","},{"line_number":89,"context_line":"                        nargs\u003d\u0027*\u0027, default\u003d[],"},{"line_number":90,"context_line":"                        help\u003d\"only return results matching given logger(s)\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_8b5785c9","line":87,"range":{"start_line":87,"start_character":36,"end_line":87,"end_character":46},"updated":"2017-01-25 10:35:22.000000000","message":"nit: compatible (lowercase + with an I)\n\nMight be clearer to say (If you limit loggers or levels, you may see less than N past records)","commit_id":"d116b011102966ad346496427617ea40cb462c1b"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"1ff135b5a51758150c0e6de12e93f3e6d003a7dc","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    # specifiers."},{"line_number":150,"context_line":"    record \u003d collections.defaultdict(str, record)"},{"line_number":151,"context_line":"    # skip if the record doesn\u0027t match a logger we are looking at"},{"line_number":152,"context_line":"    if len(loggers) \u003e 0:"},{"line_number":153,"context_line":"        name \u003d record.get(\u0027name\u0027)"},{"line_number":154,"context_line":"        if not any(n.startswith(name) for n in loggers):"},{"line_number":155,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_eb9f294e","line":152,"range":{"start_line":152,"start_character":7,"end_line":152,"end_character":23},"updated":"2017-01-25 10:35:22.000000000","message":"any reason we\u0027re not simply using \"if loggers:\"?","commit_id":"d116b011102966ad346496427617ea40cb462c1b"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"1ff135b5a51758150c0e6de12e93f3e6d003a7dc","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    # skip if the record doesn\u0027t match a logger we are looking at"},{"line_number":152,"context_line":"    if len(loggers) \u003e 0:"},{"line_number":153,"context_line":"        name \u003d record.get(\u0027name\u0027)"},{"line_number":154,"context_line":"        if not any(n.startswith(name) for n in loggers):"},{"line_number":155,"context_line":"            return"},{"line_number":156,"context_line":"    if len(levels) \u003e 0:"},{"line_number":157,"context_line":"        if record.get(\u0027levelname\u0027) not in levels:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_eb91e953","line":154,"range":{"start_line":154,"start_character":19,"end_line":154,"end_character":37},"updated":"2017-01-25 10:35:22.000000000","message":"I could be muddled but - shouldn\u0027t this be name.startswith(n)?\n\nIf I specify logger \"foo\", I want name \"foo.abc\" to match, right? Currently that would fill in as \"foo\".startswith(\"foo.abc\") which is false.","commit_id":"d116b011102966ad346496427617ea40cb462c1b"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"6433c520e197389af331ad0a78c407fb0caa8527","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                        required\u003dFalse, type\u003dint,"},{"line_number":86,"context_line":"                        help\u003d\"Last N number of records to view.\""},{"line_number":87,"context_line":"                             \" (May show less than N records when used\""},{"line_number":88,"context_line":"                             \" in conjuction with --loggers or --levels)\")"},{"line_number":89,"context_line":"    parser.add_argument(\"--loggers\","},{"line_number":90,"context_line":"                        nargs\u003d\u0027*\u0027, default\u003d[],"},{"line_number":91,"context_line":"                        help\u003d\"only return results matching given logger(s)\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_af5db116","line":88,"range":{"start_line":88,"start_character":34,"end_line":88,"end_character":44},"updated":"2017-01-30 11:52:48.000000000","message":"nit conjunction","commit_id":"c6379afce0b6a37b385e7f2732a7271aabf82032"}]}