)]}'
{"oslo_log/formatters.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7800a8d5b4ed4bc0ce28a03cb44ec062e3a073d7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        # Save the exception we were given so we can include the"},{"line_number":114,"context_line":"        # summary in the log line."},{"line_number":115,"context_line":"        exc_info \u003d record.exc_info"},{"line_number":116,"context_line":"    else:"},{"line_number":117,"context_line":"        # Check to see if there is an active exception that was"},{"line_number":118,"context_line":"        # not given to us explicitly. If so, save it so we can"},{"line_number":119,"context_line":"        # include the summary in the log line."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_badd6771","line":116,"updated":"2017-11-02 15:38:44.000000000","message":"If we pass in exc_info\u003dFalse, even if there is an active exception, we shouldn\u0027t be dumping an exception summary:\n\nhttps://review.openstack.org/#/c/517102/\n\nThe trace is really annoying - maybe what you\u0027re saying is, these shouldn\u0027t be warnings, they should be INFO messages?","commit_id":"97e9a79fe2c321db4f3a0926d03de08cea4af0c4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"176b7f999cb13edfdd93ecf0c118525378fec2e8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        # Save the exception we were given so we can include the"},{"line_number":114,"context_line":"        # summary in the log line."},{"line_number":115,"context_line":"        exc_info \u003d record.exc_info"},{"line_number":116,"context_line":"    else:"},{"line_number":117,"context_line":"        # Check to see if there is an active exception that was"},{"line_number":118,"context_line":"        # not given to us explicitly. If so, save it so we can"},{"line_number":119,"context_line":"        # include the summary in the log line."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_031065ff","line":116,"in_reply_to":"3f4b6375_27c37b8b","updated":"2017-11-05 23:26:53.000000000","message":"https://bugs.launchpad.net/oslo.log/+bug/1729475 is the bug for this ignoring exc_info\u003dFalse passed explicitly.\n\nAs for the nova stuff where this happens:\n\nhttps://review.openstack.org/#/c/517102/\n\nSome of those could arguably be INFO level logging but not all of them, so we\u0027d still need a fix for this I think.","commit_id":"97e9a79fe2c321db4f3a0926d03de08cea4af0c4"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0c6893ee1a60d98d643b7982ca28b492761df12b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        # Save the exception we were given so we can include the"},{"line_number":114,"context_line":"        # summary in the log line."},{"line_number":115,"context_line":"        exc_info \u003d record.exc_info"},{"line_number":116,"context_line":"    else:"},{"line_number":117,"context_line":"        # Check to see if there is an active exception that was"},{"line_number":118,"context_line":"        # not given to us explicitly. If so, save it so we can"},{"line_number":119,"context_line":"        # include the summary in the log line."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_27c37b8b","line":116,"in_reply_to":"3f4b6375_badd6771","updated":"2017-11-03 19:41:14.000000000","message":"I think I agree that if the logging caller explicitly passes a false exc_info we should treat that as no exception (or at least an instruction to leave the exception out of the output). Operators wanted identifiers for every error or warning message, but maybe it doesn\u0027t make sense to include it for some of them.\n\nAs far as the log level, I\u0027m not sure what triggers the particular messages in the patch you link to. Maybe you\u0027re right and they should use info instead of warning?","commit_id":"97e9a79fe2c321db4f3a0926d03de08cea4af0c4"}]}