)]}'
{"oslo_log/handlers.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"cbc28cf5fe060bfbf6a85d85b2d82f5a635cf070","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def format(self, record):"},{"line_number":166,"context_line":"        record.color \u003d self.LEVEL_COLORS[record.levelno]"},{"line_number":167,"context_line":"        record.reset_color \u003d \u0027\\033[00m\u0027"},{"line_number":168,"context_line":"        return logging.StreamHandler.format(self, record)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_45fde86b","line":167,"updated":"2018-06-01 18:20:02.000000000","message":"Is there any reason for us not to add the reset code to the end of every message automatically?","commit_id":"9da1f158b233b7212f010d726cca4f6230bd2e5f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"bddd61ecf8e69d7d78545b25a2df1d0645b431f7","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def format(self, record):"},{"line_number":166,"context_line":"        record.color \u003d self.LEVEL_COLORS[record.levelno]"},{"line_number":167,"context_line":"        record.reset_color \u003d \u0027\\033[00m\u0027"},{"line_number":168,"context_line":"        return logging.StreamHandler.format(self, record)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d5bcef6d","line":167,"in_reply_to":"5f7c97a3_3357d6cc","updated":"2018-06-06 18:03:17.000000000","message":"Yep, I agree that giving users control over it makes sense. I think I would go ahead and add it to the message, too, if it\u0027s not there at the end of the format string already. That can be a separate patch.","commit_id":"9da1f158b233b7212f010d726cca4f6230bd2e5f"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"3ba99fa244a62da83a96858a231ef8c3ccb70c6a","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def format(self, record):"},{"line_number":166,"context_line":"        record.color \u003d self.LEVEL_COLORS[record.levelno]"},{"line_number":167,"context_line":"        record.reset_color \u003d \u0027\\033[00m\u0027"},{"line_number":168,"context_line":"        return logging.StreamHandler.format(self, record)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3357d6cc","line":167,"in_reply_to":"5f7c97a3_45fde86b","updated":"2018-06-06 17:05:37.000000000","message":"I wasn\u0027t sure if handlers were supposed to modify the message directly that way, but I agree it would be more intuitive.  I think the reset_color key is still potentially useful in case someone wants to color only a certain part of the message, but adding it to the end by default would be easier for the general case.","commit_id":"9da1f158b233b7212f010d726cca4f6230bd2e5f"}]}