)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"b6c635ea937f511a0a63527dd32293461eec73a9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Vincze \u003cdvincze@cloudbasesolutions.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-31 17:43:52 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Trivial: Add Windows Event Log handler"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Python built-in logging module already provides a Windows Event"},{"line_number":10,"context_line":"Log handler. This change ensures that oslo.log exposes it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_1ed07152","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2018-10-31 16:12:35.000000000","message":"I would dispute calling this trivial. It\u0027s adding a new feature, albeit a fairly simple one. Trivial patches are things like typo fixes and such.","commit_id":"1398fb7bdf068ef27f464a1eff1d337f94e6b842"},{"author":{"_account_id":29335,"name":"Daniel Vincze","email":"dvincze@cloudbasesolutions.com","username":"dvincze"},"change_message_id":"b679bf9ad087e418f391e4ff630ab923418bc6dc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Vincze \u003cdvincze@cloudbasesolutions.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-31 17:43:52 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Trivial: Add Windows Event Log handler"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Python built-in logging module already provides a Windows Event"},{"line_number":10,"context_line":"Log handler. This change ensures that oslo.log exposes it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_ed17ffee","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"in_reply_to":"3f79a3b5_1ed07152","updated":"2018-11-01 11:35:37.000000000","message":"Done","commit_id":"1398fb7bdf068ef27f464a1eff1d337f94e6b842"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"b6c635ea937f511a0a63527dd32293461eec73a9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Log handler. This change ensures that oslo.log exposes it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I287260b5046c88c433dfa66064da14faf15610e0"},{"line_number":13,"context_line":"Implements: blueprint windows-event-log"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_5eb58918","line":13,"updated":"2018-10-31 16:12:35.000000000","message":"Because this doesn\u0027t need a lot of design work, I probably would have gone with a wishlist bug instead. This is fine though since you already did it.","commit_id":"1398fb7bdf068ef27f464a1eff1d337f94e6b842"},{"author":{"_account_id":29335,"name":"Daniel Vincze","email":"dvincze@cloudbasesolutions.com","username":"dvincze"},"change_message_id":"b679bf9ad087e418f391e4ff630ab923418bc6dc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Log handler. This change ensures that oslo.log exposes it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I287260b5046c88c433dfa66064da14faf15610e0"},{"line_number":13,"context_line":"Implements: blueprint windows-event-log"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_8d144bec","line":13,"in_reply_to":"3f79a3b5_5eb58918","updated":"2018-11-01 11:35:37.000000000","message":"Done","commit_id":"1398fb7bdf068ef27f464a1eff1d337f94e6b842"}],"oslo_log/log.py":[{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"a226008f0b854fbbcfc47773650518fe2df1ee8f","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        log_root.addHandler(journal)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    if conf.use_eventlog and platform.system() \u003d\u003d \u0027Windows\u0027:"},{"line_number":365,"context_line":"            eventlog \u003d logging.handlers.NTEventLogHandler(project)"},{"line_number":366,"context_line":"            log_root.addHandler(eventlog)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    # if None of the above are True, then fall back to standard out"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5e2b497b","line":365,"range":{"start_line":365,"start_character":4,"end_line":365,"end_character":12},"updated":"2018-10-31 16:06:27.000000000","message":"You\u0027ll have to fix the indentation.","commit_id":"1398fb7bdf068ef27f464a1eff1d337f94e6b842"},{"author":{"_account_id":29335,"name":"Daniel Vincze","email":"dvincze@cloudbasesolutions.com","username":"dvincze"},"change_message_id":"e9507b4ca691dd4fabb4cd28c1a06bcb0e61723a","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        log_root.addHandler(journal)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    if conf.use_eventlog and platform.system() \u003d\u003d \u0027Windows\u0027:"},{"line_number":365,"context_line":"            eventlog \u003d logging.handlers.NTEventLogHandler(project)"},{"line_number":366,"context_line":"            log_root.addHandler(eventlog)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    # if None of the above are True, then fall back to standard out"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6a5e75e9","line":365,"range":{"start_line":365,"start_character":4,"end_line":365,"end_character":12},"in_reply_to":"3f79a3b5_5e2b497b","updated":"2018-11-01 11:34:23.000000000","message":"Done","commit_id":"1398fb7bdf068ef27f464a1eff1d337f94e6b842"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3c3d3c0a526ce784d136a3e4d30b418b453299af","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        log_root.addHandler(journal)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    if conf.use_eventlog and platform.system() \u003d\u003d \u0027Windows\u0027:"},{"line_number":365,"context_line":"            eventlog \u003d logging.handlers.NTEventLogHandler(project)"},{"line_number":366,"context_line":"            log_root.addHandler(eventlog)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    # if None of the above are True, then fall back to standard out"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e1e718ab","line":365,"range":{"start_line":365,"start_character":4,"end_line":365,"end_character":12},"in_reply_to":"3f79a3b5_5e2b497b","updated":"2018-10-31 17:18:48.000000000","message":"Should this throw an error if the platform is not Windows?","commit_id":"1398fb7bdf068ef27f464a1eff1d337f94e6b842"},{"author":{"_account_id":29335,"name":"Daniel Vincze","email":"dvincze@cloudbasesolutions.com","username":"dvincze"},"change_message_id":"e9507b4ca691dd4fabb4cd28c1a06bcb0e61723a","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        log_root.addHandler(journal)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    if conf.use_eventlog and platform.system() \u003d\u003d \u0027Windows\u0027:"},{"line_number":365,"context_line":"            eventlog \u003d logging.handlers.NTEventLogHandler(project)"},{"line_number":366,"context_line":"            log_root.addHandler(eventlog)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    # if None of the above are True, then fall back to standard out"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8a4d113e","line":365,"range":{"start_line":365,"start_character":4,"end_line":365,"end_character":12},"in_reply_to":"3f79a3b5_e1e718ab","updated":"2018-11-01 11:34:23.000000000","message":"Done","commit_id":"1398fb7bdf068ef27f464a1eff1d337f94e6b842"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68b6a0a293995c7c2d9300e58dcba9a793e58543","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        journal \u003d handlers.OSJournalHandler()"},{"line_number":362,"context_line":"        log_root.addHandler(journal)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    if conf.use_eventlog and platform.system() \u003d\u003d \u0027Windows\u0027:"},{"line_number":365,"context_line":"        eventlog \u003d logging.handlers.NTEventLogHandler(project)"},{"line_number":366,"context_line":"        log_root.addHandler(eventlog)"},{"line_number":367,"context_line":"    else:"},{"line_number":368,"context_line":"        raise RuntimeError(_(\"Windows Event Log is not available on this \""},{"line_number":369,"context_line":"                             \"platform.\"))"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    # if None of the above are True, then fall back to standard out"},{"line_number":372,"context_line":"    if not logpath and not conf.use_stderr and not conf.use_journal:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0de03bcb","line":369,"range":{"start_line":364,"start_character":0,"end_line":369,"end_character":42},"updated":"2018-11-01 11:50:13.000000000","message":"The logic for this is wrong. This will raise the error if conf.use_eventlog is False too. You\u0027re going to need to nest the statements (or ideally add another statement earlier just to check if the option is defined and the platform is not Windows. This also suggests we need a test for this.\n\nAs an aside though, I already see warnings if I try importing this on Windows. Perhaps that\u0027s good enough?\n\n  \u003e\u003e\u003e import logging.handlers\n  \u003e\u003e\u003e logging.handlers.NTEventLogHandler(\u0027test\u0027)\n  The Python Win32 extensions for NT (service, event logging) appear not to be available.\n  \u003clogging.handlers.NTEventLogHandler object at 0x7f606a9ba510\u003e","commit_id":"be0e7e13ce95d2962fa75b998fe5b8fa9b432e75"}]}
