)]}'
{"id":"openstack%2Foslo.log~676450","triplet_id":"openstack%2Foslo.log~master~Ifd1300d8e4280df1913f632e964f9458dbb2db55","project":"openstack/oslo.log","branch":"master","topic":"bug/1783630","hashtags":[],"change_id":"Ifd1300d8e4280df1913f632e964f9458dbb2db55","subject":"Use setLevel instead of setting logger.level directly","status":"MERGED","created":"2019-08-14 16:08:50.000000000","updated":"2019-08-15 07:16:03.000000000","submitted":"2019-08-15 07:16:03.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"676450-1565853363697-674d1078","meta_rev_id":"30461015522e234be8ea3f6d06ce20fda7679e68","_number":676450,"virtual_id_number":676450,"owner":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-08-15 07:16:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":0,"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"recommended":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-15 05:20:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":2,"date":"2019-08-15 05:44:26.000000000","_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},{"value":2,"date":"2019-08-14 17:34:13.000000000","_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":1,"date":"2019-08-15 05:44:26.000000000","_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":0,"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-14 17:34:13.000000000","updated_by":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"reviewer":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"state":"REVIEWER"},{"updated":"2019-08-15 05:20:35.000000000","updated_by":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"reviewer":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"state":"REVIEWER"},{"updated":"2019-08-15 05:44:26.000000000","updated_by":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"reviewer":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"state":"REVIEWER"},{"updated":"2019-08-15 07:16:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"dd16e96361ee4dd5bb816827391deb52195777d6","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2019-08-14 16:08:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e00ee4fdac4d1b8c872347a2b2ab2a2efd13bccf","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2019-08-14 17:34:13.000000000","message":"Patch Set 1: Code-Review+2\n\nWow.","accounts_in_message":[],"_revision_number":1},{"id":"63555ddf57d0e881d1bd2e4b1d737464578ba6b9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 17:48:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/52b0c435e15d46f4b45cd7b2641674c9 : SUCCESS in 1h 31m 45s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/6ff571f808ed4db1a2fc83be507b9052 : SUCCESS in 1h 23m 00s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6b9c2a63aa98468ab8b77f17a860bfc0 : SUCCESS in 3m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1eca947a67b841d9903d33a40dbac891 : SUCCESS in 3m 23s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/19ef80508f354387a2b34b60b159eb45 : SUCCESS in 3m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e132ae12247c4499905870676ff3b7c8 : SUCCESS in 3m 28s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/213111ab4fa64c53aade5b0b27a3b44b : SUCCESS in 4m 25s\n- oslo.log-src-grenade-devstack https://zuul.opendev.org/t/openstack/build/c4f93f1a77ba47e19a6354f6a5d87d89 : SUCCESS in 1h 08m 45s (non-voting)\n- oslo.log-jsonformatter https://zuul.opendev.org/t/openstack/build/c65008cac735485780571d02bb391817 : SUCCESS in 42m 08s","accounts_in_message":[],"_revision_number":1},{"id":"a832b2acdb3c08c9679dbedd3d3c956371797a1d","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2019-08-14 20:01:20.000000000","message":"Patch Set 1:\n\nI opened another bug to see if we can get this fixed at the source: https://bugs.python.org/issue37857","accounts_in_message":[],"_revision_number":1},{"id":"06be0e24913712e4edea984605b42f359035c934","author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"date":"2019-08-15 05:20:35.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"de7e1a47efa0298e0608cea9e94732a2ad5995d2","author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"date":"2019-08-15 05:44:26.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1d2ac7593066634c1de83d262ae32f9082585546","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-15 05:44:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ece21f12434cdc29d84b357f8d38b8df7f7559c9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-15 07:16:03.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/e05c8bc14392440082f885308283bbc3 : SUCCESS in 1h 30m 53s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/595f73cbfcc144638fa2171e5e8dc3b8 : SUCCESS in 1h 13m 05s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/170d518ad708432c8f59fc4018350583 : SUCCESS in 2m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cb13833196844b5eafec6a1c35af1b52 : SUCCESS in 2m 36s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d36746b3359e4b35922bce5499158580 : SUCCESS in 2m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9157b1db4b674c949690072b8cc86c57 : SUCCESS in 2m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5462d1c11af248bc88efc8a05cbc9aa4 : SUCCESS in 2m 38s\n- oslo.log-jsonformatter https://zuul.opendev.org/t/openstack/build/36cbd674810d4fe49acc2439008cbabb : SUCCESS in 39m 03s","accounts_in_message":[],"_revision_number":1},{"id":"c4d2d8937c384ce029c4c95c32a0ec2b330905bb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-15 07:16:03.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"500788981e1abcd5a495badac350285e39f993a4","revisions":{"500788981e1abcd5a495badac350285e39f993a4":{"kind":"REWORK","_number":1,"created":"2019-08-14 16:08:50.000000000","uploader":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"ref":"refs/changes/50/676450/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.log","ref":"refs/changes/50/676450/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.log refs/changes/50/676450/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.log refs/changes/50/676450/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.log refs/changes/50/676450/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.log refs/changes/50/676450/1"}}},"commit":{"parents":[{"commit":"9222660a461967c90341d6fd2aebfd4259753ebc","subject":"Bump the openstackdocstheme extension to 1.20","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.log/commit/9222660a461967c90341d6fd2aebfd4259753ebc"}]}],"author":{"name":"Ben Nemec","email":"bnemec@redhat.com","date":"2019-08-14 16:02:23.000000000","tz":0},"committer":{"name":"Ben Nemec","email":"bnemec@redhat.com","date":"2019-08-14 16:02:23.000000000","tz":0},"subject":"Use setLevel instead of setting logger.level directly","message":"Use setLevel instead of setting logger.level directly\n\nPython 3.7 added caching of the log level for calls to isEnabledFor\non a logger[0]. As a result, modifying the logger level directly\ncan cause a mismatch in behavior if a log call was made prior to\nthat modification. In our case, we were calling logger.info before\nthe info level was enabled, which meant the logger cached the fact\nthat it was not enabled for info-level logging. Even after setting\nthe level to NOTSET, it was still remembering that it shouldn\u0027t log\ninfo messages and that breaks our unit tests on py37. There is a\nrelated issue open against Python[1], but basically the answer there\nwas \"don\u0027t mess with logger internals\".\n\nThe simple fix is to use logger.setLevel for resetting the log level\ninstead of modifying the attribute directly.\n\nChange-Id: Ifd1300d8e4280df1913f632e964f9458dbb2db55\n0: https://github.com/python/cpython/commit/78c18a9b9a1445f7c755929917a790ba02b4a5e0#diff-5bd69232a06838f179312d3e48ccf506\n1: https://bugs.python.org/issue34269\nCloses-Bug: 1783630\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.log/commit/500788981e1abcd5a495badac350285e39f993a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.log/commit/500788981e1abcd5a495badac350285e39f993a4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}