)]}'
{"id":"openstack%2Foslo.log~705133","triplet_id":"openstack%2Foslo.log~master~Ib155ea3298d0467d8706da9c41c2326959b969e6","project":"openstack/oslo.log","branch":"master","topic":"feature/mypy","hashtags":[],"change_id":"Ib155ea3298d0467d8706da9c41c2326959b969e6","subject":"Add a \"mypy\" target to tox.ini.","status":"ABANDONED","created":"2020-01-30 23:51:33.000000000","updated":"2021-10-05 10:50:13.000000000","total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9c0131576c04a22e1d80d46bfcafe9c69110cf97","_number":705133,"virtual_id_number":705133,"owner":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-01-31 01:21:58.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-02-07 14:07:19.000000000","_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"date":"2020-02-07 15:56:48.000000000","_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":-1,"date":"2020-01-31 09:50:56.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-01-31 01:21:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-01-31 09:50:56.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-02-07 15:56:48.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"}],"messages":[{"id":"fac745bf47194b8adc439e7151803e3a33d91475","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2020-01-30 23:51:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8b27b7d416e930a627fb7ace5838762d7ab4ece4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-31 01:21:58.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/8f7f61669624488da4f703572edf8086 : SUCCESS in 1m 59s\n- requirements-check https://zuul.opendev.org/t/openstack/build/b3541c96bc8242a790af98122ebdc7ca : FAILURE in 2m 15s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/616bfebbae5a41cbb08a58706c94f84c : FAILURE in 1h 26m 05s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2945a4088d594253a78e1e9d09feddc5 : SUCCESS in 4m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/863834dddffa44de9be36fa07bada644 : FAILURE in 4m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/88146ca735534d9fbd443b5ec71b2cb8 : SUCCESS in 4m 26s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ad1af306587a4724beda9a37beaa33e7 : SUCCESS in 4m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6b31c9f9d39b4a0484f06ff8d2b305c5 : SUCCESS in 5m 05s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/04a322c180a4430bbbd3514017d6c8af : SUCCESS in 4m 08s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cb36389214fb4cc2b4545103a511f233 : SUCCESS in 5m 01s\n- oslo.log-src-grenade-devstack https://zuul.opendev.org/t/openstack/build/ce73aa52cb504ac2a0d96b6205e40759 : SUCCESS in 58m 33s (non-voting)\n- oslo.log-jsonformatter https://zuul.opendev.org/t/openstack/build/5db44d568d1c483aba28fd2cee2e02d4 : SUCCESS in 40m 01s","accounts_in_message":[],"_revision_number":1},{"id":"920ae20b5626cfe0a239346c1484bbd4488daa85","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-01-31 09:50:56.000000000","message":"Patch Set 1: Code-Review-1\n\nHello,\n\nSome comments.\n\nFirst you need to put mypy in lower-constraint to pass the requirements-check (this is why I -1 your patch set).\n\nSecond, do we want to run mypy checks during CI jobs? If yes in this I guess you need to design a zuul job related to this.","accounts_in_message":[],"_revision_number":1},{"id":"d4a8b0d96581ed5e61c1f4d56e097b87b6f7b7a4","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-01-31 09:53:35.000000000","message":"Patch Set 1:\n\nAlso it could be worth to put `.mypy_cache/` to `.gitignore`","accounts_in_message":[],"_revision_number":1},{"id":"2d95468178662f83b78e40f68caffea7dd3e22bc","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-01-31 10:03:24.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1a863659a3e1b342b21e0669c86d7d8c23dcbfff","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-01-31 10:32:33.000000000","message":"Patch Set 1:\n\n(3 comments)\n\nCouple of comments. On a related note, is there any reason to use mytype over pytype? The latter is looser and might  be able to handle the few issues you\u0027re seeing here.","accounts_in_message":[],"_revision_number":1},{"id":"61cc762d66ee23bbdde2aef6f362d2d258e87d2c","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2020-02-07 14:07:19.000000000","message":"Patch Set 1:\n\n(4 comments)\n\n@Stephen: So, there is mypy, pytype and pyright (and probably some others). I was under the impression that \"mypy\", being the oldest of the three, was the \"de facto\" standard, but I might be mistaken.","accounts_in_message":[],"_revision_number":1},{"id":"9d26b7064bd9d8da7205b91fd345ec6ba98775db","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-02-07 15:56:48.000000000","message":"Patch Set 1:\n\n\u003e @Stephen: So, there is mypy, pytype and pyright (and probably some\n \u003e others). I was under the impression that \"mypy\", being the oldest\n \u003e of the three, was the \"de facto\" standard, but I might be mistaken.\n\nNope, you\u0027re probably correct. Mostly asking to get your opinion because I\u0027m deliberating between the two in nova land at present :)","accounts_in_message":[],"_revision_number":1},{"id":"9c0131576c04a22e1d80d46bfcafe9c69110cf97","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-10-05 10:50:13.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"86fecc89ad69bf7dfb4344e7d7f847682a7f76ad","revisions":{"86fecc89ad69bf7dfb4344e7d7f847682a7f76ad":{"kind":"REWORK","_number":1,"created":"2020-01-30 23:51:33.000000000","uploader":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"ref":"refs/changes/33/705133/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.log","ref":"refs/changes/33/705133/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.log refs/changes/33/705133/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.log refs/changes/33/705133/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.log refs/changes/33/705133/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.log refs/changes/33/705133/1"}}},"commit":{"parents":[{"commit":"2dd526d1ed0f1f886fff0c2edfc2929dc6f58d1b","subject":"Drop python 2.7 support and testing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.log/commit/2dd526d1ed0f1f886fff0c2edfc2929dc6f58d1b"}]}],"author":{"name":"Cyril Roelandt","email":"cyril@redhat.com","date":"2020-01-28 18:33:59.000000000","tz":60},"committer":{"name":"Cyril Roelandt","email":"cyril@redhat.com","date":"2020-01-30 23:51:28.000000000","tz":60},"subject":"Add a \"mypy\" target to tox.ini.","message":"Add a \"mypy\" target to tox.ini.\n\nChange-Id: Ib155ea3298d0467d8706da9c41c2326959b969e6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.log/commit/86fecc89ad69bf7dfb4344e7d7f847682a7f76ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.log/commit/86fecc89ad69bf7dfb4344e7d7f847682a7f76ad"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}