)]}'
{"oslo_log/handlers.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"15fc7fd21fa35d56bd58a91c64f05e9be4a37442","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def __init__(self, facility\u003dNone):"},{"line_number":86,"context_line":"        # Default values always get evaluated, for which reason we avoid"},{"line_number":87,"context_line":"        # using \u0027syslog\u0027 directly, which may not be available."},{"line_number":88,"context_line":"        facility \u003d facility if facility is not None else syslog.LOG_USER"},{"line_number":89,"context_line":"        # Do not use super() unless type(logging.Handler) is \u0027type\u0027"},{"line_number":90,"context_line":"        # (i.e. \u003e\u003d Python 2.7)."},{"line_number":91,"context_line":"        if not journal:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_18cc4633","line":88,"updated":"2020-05-01 16:04:49.000000000","message":"You should fail here if facility is unset otherwise the call to syslog would fail","commit_id":"121b6196e5ba02137b8790ffd6560958aa5c4b40"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e2ec98ee20e3653d093ab37d2ab31d5b562be570","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \u0027request_id\u0027,"},{"line_number":83,"context_line":"    )"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def __init__(self, facility):"},{"line_number":86,"context_line":"        if not journal:"},{"line_number":87,"context_line":"            raise RuntimeError(\"Systemd bindings do not exist\")"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_26334aad","line":85,"updated":"2020-06-01 21:58:58.000000000","message":"This started breaking Neutron over the weekend, is there a reason this can\u0027t be facility\u003dNone like OSSyslogHandler?\n\nI started https://review.opendev.org/732457","commit_id":"5b12e66f6283962d96884e4aa3fa7db7d4e062fa"}],"oslo_log/log.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"15fc7fd21fa35d56bd58a91c64f05e9be4a37442","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        log_root.addHandler(streamlog)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    if conf.use_journal:"},{"line_number":390,"context_line":"        global syslog"},{"line_number":391,"context_line":"        if syslog is None:"},{"line_number":392,"context_line":"            raise RuntimeError(\"syslog is not available on this platform\")"},{"line_number":393,"context_line":"        facility \u003d _find_facility(conf.syslog_log_facility)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_b8571258","line":390,"range":{"start_line":390,"start_character":0,"end_line":390,"end_character":21},"updated":"2020-05-01 16:04:49.000000000","message":"You don\u0027t need this. global is only needed if you need to modify an attribute at global scope, not just read it. This is also the cause of your test failures due to syslog having already have been referenced previously in this function","commit_id":"121b6196e5ba02137b8790ffd6560958aa5c4b40"},{"author":{"_account_id":31823,"name":"Benjamin Reichel","email":"b.reichel@syseleven.de","username":"benj200"},"change_message_id":"56d4d4aa5942cdef78b33385501b11f64c1360f9","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        log_root.addHandler(handler)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    if conf.use_syslog:"},{"line_number":418,"context_line":"        global syslog"},{"line_number":419,"context_line":"        if syslog is None:"},{"line_number":420,"context_line":"            raise RuntimeError(\"syslog is not available on this platform\")"},{"line_number":421,"context_line":"        facility \u003d _find_facility(conf.syslog_log_facility)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_9762b3d7","line":418,"range":{"start_line":418,"start_character":8,"end_line":418,"end_character":21},"updated":"2020-05-05 12:40:58.000000000","message":"Tests are still failing but now because of this global syslog","commit_id":"f301dec70d2fa692b47999f2628bf1372b8eed5b"}]}