)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"883ac454f495fd8658b0c571631d7a5a84d3cb0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1e6612eb_a342955d","updated":"2024-03-26 13:06:55.000000000","message":"FYI, this morning I reported a new eventlet github issue, following a strange behavior we observed with our tests on devstack about switching to the eventlet\u0027s new asyncio hub:\n\nhttps://review.opendev.org/c/openstack/devstack/+/914108\n\nYou may find interest in joining the discussion:\n\nhttps://github.com/eventlet/eventlet/issues/948\n\nI\u0027d encourage you to open a new related oslo.log bug (launchpad). It would help to more describe the problem, and why/where/when you observe it, i.e you context.\n\nThanks in advance.","commit_id":"0fbaed9d39c93e59bab26f952896088f46bb1793"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"99486cd37fe6aa3f126400d5bc8c50418f395ec4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8d4b59ad_e93f8146","in_reply_to":"1e6612eb_a342955d","updated":"2024-03-26 13:07:43.000000000","message":"The github issue I opened seems also related to the bug you try to fix.","commit_id":"0fbaed9d39c93e59bab26f952896088f46bb1793"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"54cc8b14bcd33308db9f3872e850b865b2d0e326","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f7987c95_bca68e5c","in_reply_to":"8d4b59ad_e93f8146","updated":"2024-03-26 13:51:45.000000000","message":"I think the bug is already reported in octavia https://bugs.launchpad.net/octavia/+bug/2039346, the trace is actually looks similar in my case.","commit_id":"0fbaed9d39c93e59bab26f952896088f46bb1793"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c69fcebe32357a7f057a3fb04d087656096237a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b9745b4b_3a721e97","updated":"2024-03-26 13:59:25.000000000","message":"I think this patch make sense and should solve https://github.com/eventlet/eventlet/issues/948\n\nWe shouldn\u0027t based our condition on sys.module else, if eventlet is imported elsewhere in the stack, it will appear in the result get from sys.module, here meaning (the original version) that the env is a monkey patched env, which is not true.\n\nSimply importing eventlet is not synonym of monkey patching the env.\nI think this patch solve that.","commit_id":"38f8ad79705b5028c859802cfe72e31ef5bc59df"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cd82c4fa4debea744bdb9b38fb2c333f7f5af530","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6d20737a_9ede1b3e","updated":"2024-03-26 14:43:20.000000000","message":"The logic is consistent with the ones in oslo.messaging and makes clear sense.\n\nThe feature was added in 3.9.0 and the current minimum version is 3.36.0.","commit_id":"38f8ad79705b5028c859802cfe72e31ef5bc59df"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"a741e18b291704f6c29cf9974e88bf51c3675baf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8cd8ddcd_8a97422b","updated":"2024-03-26 14:00:28.000000000","message":"This fix should be backported to stable branches who also contains the original patch.","commit_id":"38f8ad79705b5028c859802cfe72e31ef5bc59df"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1733631f0dcd6dc983e105909368b3ad6ec24a75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5829afe1_d9333480","updated":"2024-03-26 14:51:03.000000000","message":"Repleased related-bug tag by closed-bug because we consider this is the actual fix.","commit_id":"a1fe1b9cfb841d632aa582a52c106b4ebab1c159"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"453749612a64b98b37756056391ac5711d568659","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4dbcb3af_30365869","in_reply_to":"5829afe1_d9333480","updated":"2024-03-26 17:17:25.000000000","message":"I hope it fixes actually :-)","commit_id":"a1fe1b9cfb841d632aa582a52c106b4ebab1c159"}],"oslo_log/log.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"669117e65402c03e5f0c469cbe61028a422bc5a1","unresolved":true,"context_lines":[{"line_number":274,"context_line":"    # If eventlet was not loaded before call to setup assume it\u0027s not used."},{"line_number":275,"context_line":"    eventlet \u003d sys.modules.get(\u0027eventlet\u0027)"},{"line_number":276,"context_line":"    if eventlet:"},{"line_number":277,"context_line":"        from eventlet.patcher import is_monkey_patched as is_eventlet"},{"line_number":278,"context_line":"        import socket"},{"line_number":279,"context_line":"        if is_eventlet(socket):"},{"line_number":280,"context_line":"            import eventlet.green.threading"}],"source_content_type":"text/x-python","patch_set":2,"id":"83e2de2a_e728009b","line":277,"updated":"2024-03-26 11:06:49.000000000","message":"I\u0027d encourage using the oslo.utils eventletutils module [1] to do your checks rather than importing eventlet itself.\n\noslo.utils is already imported.\n\n[1] https://opendev.org/openstack/oslo.utils/src/branch/master/oslo_utils/eventletutils.py#L134","commit_id":"a74b28364e7f6cbcad6e3af739d73a0588cdea6f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"cb9a8430e013b718ad6075ab9d0d4e90410c3f46","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    # If eventlet was not loaded before call to setup assume it\u0027s not used."},{"line_number":275,"context_line":"    eventlet \u003d sys.modules.get(\u0027eventlet\u0027)"},{"line_number":276,"context_line":"    if eventlet:"},{"line_number":277,"context_line":"        from eventlet.patcher import is_monkey_patched as is_eventlet"},{"line_number":278,"context_line":"        import socket"},{"line_number":279,"context_line":"        if is_eventlet(socket):"},{"line_number":280,"context_line":"            import eventlet.green.threading"}],"source_content_type":"text/x-python","patch_set":2,"id":"40eae924_05597d99","line":277,"in_reply_to":"58d822e2_e97e4337","updated":"2024-03-26 12:03:07.000000000","message":"Done","commit_id":"a74b28364e7f6cbcad6e3af739d73a0588cdea6f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ab624ac019b679d7aae5dff18c025b32813b0037","unresolved":true,"context_lines":[{"line_number":274,"context_line":"    # If eventlet was not loaded before call to setup assume it\u0027s not used."},{"line_number":275,"context_line":"    eventlet \u003d sys.modules.get(\u0027eventlet\u0027)"},{"line_number":276,"context_line":"    if eventlet:"},{"line_number":277,"context_line":"        from eventlet.patcher import is_monkey_patched as is_eventlet"},{"line_number":278,"context_line":"        import socket"},{"line_number":279,"context_line":"        if is_eventlet(socket):"},{"line_number":280,"context_line":"            import eventlet.green.threading"}],"source_content_type":"text/x-python","patch_set":2,"id":"58d822e2_e97e4337","line":277,"in_reply_to":"83e2de2a_e728009b","updated":"2024-03-26 12:03:00.000000000","message":"thanks for review, done.","commit_id":"a74b28364e7f6cbcad6e3af739d73a0588cdea6f"}]}