)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"41af238444dd06ee5cb8822b4a4df8b19ef8dcfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b06b4a38_69604d19","updated":"2024-04-04 13:43:33.000000000","message":"adding a -1 as i think this backport shouldn\u0027t be merged. see my previous comments about details.","commit_id":"88bbc8b82ca67b7bf622f54e8d48976bba2fb745"}],"oslo_log/_options.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"a1b8b91dec7a111c2f0087c668f910b4da0c51f3","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    cfg.BoolOpt(\u0027watch-log-file\u0027,"},{"line_number":76,"context_line":"                default\u003dFalse,"},{"line_number":77,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":78,"context_line":"                deprecated_reason\u003d(\u0027This function is known to have bene \u0027"},{"line_number":79,"context_line":"                                   \u0027broken for long time, and depends on \u0027"},{"line_number":80,"context_line":"                                   \u0027the unmaintained library\u0027),"},{"line_number":81,"context_line":"                help\u003d\u0027Uses logging handler designed to watch file \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"587520ce_3273fa90","line":78,"range":{"start_line":78,"start_character":67,"end_line":78,"end_character":71},"updated":"2024-04-03 15:36:52.000000000","message":"Hmmm I\u0027m not sure we want to go that way.\nIt looks weird to deprecate things on a stable branch.\nIMO, deprecation only happens on master.","commit_id":"88bbc8b82ca67b7bf622f54e8d48976bba2fb745"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"a1b8b91dec7a111c2f0087c668f910b4da0c51f3","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    cfg.BoolOpt(\u0027watch-log-file\u0027,"},{"line_number":76,"context_line":"                default\u003dFalse,"},{"line_number":77,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":78,"context_line":"                deprecated_reason\u003d(\u0027This function is known to have bene \u0027"},{"line_number":79,"context_line":"                                   \u0027broken for long time, and depends on \u0027"},{"line_number":80,"context_line":"                                   \u0027the unmaintained library\u0027),"},{"line_number":81,"context_line":"                help\u003d\u0027Uses logging handler designed to watch file \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"d36d3c05_cbe3d4ce","line":78,"range":{"start_line":78,"start_character":67,"end_line":78,"end_character":71},"updated":"2024-04-03 15:36:52.000000000","message":"In parallel there is a nit.","commit_id":"88bbc8b82ca67b7bf622f54e8d48976bba2fb745"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"bd072dc08875d53e782820c59a6be8a3b1935321","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    cfg.BoolOpt(\u0027watch-log-file\u0027,"},{"line_number":76,"context_line":"                default\u003dFalse,"},{"line_number":77,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":78,"context_line":"                deprecated_reason\u003d(\u0027This function is known to have bene \u0027"},{"line_number":79,"context_line":"                                   \u0027broken for long time, and depends on \u0027"},{"line_number":80,"context_line":"                                   \u0027the unmaintained library\u0027),"},{"line_number":81,"context_line":"                help\u003d\u0027Uses logging handler designed to watch file \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a442a47_4db69ddb","line":78,"range":{"start_line":78,"start_character":67,"end_line":78,"end_character":71},"in_reply_to":"1049bef6_85dbc47a","updated":"2024-04-04 13:35:54.000000000","message":"as I wrote on IRC: deprecations should happen on master branch. furthermore, there were some changes around deprecation (of features) due to SLURP releases (something like: things should be deprecated in a SLURP release, and can only be removed on another SLURP release, or something like that)... given though that this is needed for py312 compatibility, it\u0027s quite hard situation.\n\nSo any solution, that would help about keeping the \"non-functioning feature\", or at least that it\u0027s absence to not cause issues, that would be the great. So I\u0027m supporting Hervé\u0027s thinking about mocking it somehow. but other ideas are welcome, too.\n\n(and of course, if the removal is the best solution, then we have to remove it anyway (saying, there can be exceptions), but i don\u0027t think a deprecation warning backport should be added anyway)","commit_id":"88bbc8b82ca67b7bf622f54e8d48976bba2fb745"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"9c45636dfe1f51e0c2e1c06ffba7b43d238a9abe","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    cfg.BoolOpt(\u0027watch-log-file\u0027,"},{"line_number":76,"context_line":"                default\u003dFalse,"},{"line_number":77,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":78,"context_line":"                deprecated_reason\u003d(\u0027This function is known to have bene \u0027"},{"line_number":79,"context_line":"                                   \u0027broken for long time, and depends on \u0027"},{"line_number":80,"context_line":"                                   \u0027the unmaintained library\u0027),"},{"line_number":81,"context_line":"                help\u003d\u0027Uses logging handler designed to watch file \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1049bef6_85dbc47a","line":78,"range":{"start_line":78,"start_character":67,"end_line":78,"end_character":71},"in_reply_to":"4626c380_09482ee0","updated":"2024-04-04 13:22:47.000000000","message":"We could release this deprecation early once release files for dalmatian will be created. Users won\u0027t have lot of time to drop their usages of that feature.\n\nAn other option would be to mock that option with an empty mock to protect users who wouldn\u0027t have the time to adapt to this structural change, rather than abruptly removing the feature. That could be a compromise.","commit_id":"88bbc8b82ca67b7bf622f54e8d48976bba2fb745"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c50803e423631cd1ab6b9c8679756ccfa6a5767f","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    cfg.BoolOpt(\u0027watch-log-file\u0027,"},{"line_number":76,"context_line":"                default\u003dFalse,"},{"line_number":77,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":78,"context_line":"                deprecated_reason\u003d(\u0027This function is known to have bene \u0027"},{"line_number":79,"context_line":"                                   \u0027broken for long time, and depends on \u0027"},{"line_number":80,"context_line":"                                   \u0027the unmaintained library\u0027),"},{"line_number":81,"context_line":"                help\u003d\u0027Uses logging handler designed to watch file \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"8751a670_6ff0fde1","line":78,"range":{"start_line":78,"start_character":67,"end_line":78,"end_character":71},"in_reply_to":"587520ce_3273fa90","updated":"2024-04-04 00:13:43.000000000","message":"What I propose here is deprecating this feature in 2024.1 and remove it in 2024.2 . I know it\u0027s late but it\u0027s not too late as long as we can create a release very soon.\n\nThe core problem is that this breaks compatibility with Python 3.12 and blocks all the work to support it... If we won\u0027t deprecate it in 2024.1 that means we have to keep the feature in 2025.1, and we can\u0027t add python 3.12 support till 2025.2 .","commit_id":"88bbc8b82ca67b7bf622f54e8d48976bba2fb745"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d15358fc8b0839b600d3b70148a1c04d91e1752c","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    cfg.BoolOpt(\u0027watch-log-file\u0027,"},{"line_number":76,"context_line":"                default\u003dFalse,"},{"line_number":77,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":78,"context_line":"                deprecated_reason\u003d(\u0027This function is known to have bene \u0027"},{"line_number":79,"context_line":"                                   \u0027broken for long time, and depends on \u0027"},{"line_number":80,"context_line":"                                   \u0027the unmaintained library\u0027),"},{"line_number":81,"context_line":"                help\u003d\u0027Uses logging handler designed to watch file \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"4626c380_09482ee0","line":78,"range":{"start_line":78,"start_character":67,"end_line":78,"end_character":71},"in_reply_to":"8751a670_6ff0fde1","updated":"2024-04-04 13:15:23.000000000","message":"Ok, but in this case I\u0027d suggest to also discuss that strategy with Elod which is our stable policy expert.\n\nYour arguments looks rock solid. Elod could help us to socialize/officialize that situation. Let me add Elod at the list of the reviewers.","commit_id":"88bbc8b82ca67b7bf622f54e8d48976bba2fb745"}]}