)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"47e54e02840c337b4b0ecab04a1ea2d83a2d837e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     damani42 \u003cdbengt@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-05-07 12:30:23 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the usage of the debug feature from eventlet."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem with disabling this procedure is that it exposes you to risk. Deactivation applies to the entire stack. If a project uses oslo.log, for example nova, then it exposes all threads to concurrent access on the process file descriptors."},{"line_number":10,"context_line":"As explained in the function\u0027s documentation[1], when several greenlets are reading from the same socket, it\u0027s difficult to predict which greenlet will receive which data."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ae49ff6e_069a4ffc","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"updated":"2024-05-07 11:44:03.000000000","message":"I think the following sentence is more reflecting this change:\n\n`Remove the usage of the Eventlet debug feature from oslo.log`","commit_id":"741388754a68b8e65ae2ecfc78f46bdda04ee570"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"41d7e793543f22ff5e0d2057cf898bbf0eb60eca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     damani42 \u003cdbengt@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-05-07 12:30:23 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the usage of the debug feature from eventlet."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem with disabling this procedure is that it exposes you to risk. Deactivation applies to the entire stack. If a project uses oslo.log, for example nova, then it exposes all threads to concurrent access on the process file descriptors."},{"line_number":10,"context_line":"As explained in the function\u0027s documentation[1], when several greenlets are reading from the same socket, it\u0027s difficult to predict which greenlet will receive which data."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ecc53bf8_3fdaf0b9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"in_reply_to":"ae49ff6e_069a4ffc","updated":"2024-05-08 09:33:55.000000000","message":"Done","commit_id":"741388754a68b8e65ae2ecfc78f46bdda04ee570"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"47e54e02840c337b4b0ecab04a1ea2d83a2d837e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the usage of the debug feature from eventlet."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem with disabling this procedure is that it exposes you to risk. Deactivation applies to the entire stack. If a project uses oslo.log, for example nova, then it exposes all threads to concurrent access on the process file descriptors."},{"line_number":10,"context_line":"As explained in the function\u0027s documentation[1], when several greenlets are reading from the same socket, it\u0027s difficult to predict which greenlet will receive which data."},{"line_number":11,"context_line":"You really need to be sure of what you\u0027re doing to use this function. Also explained in the raise condition added by this commit[2] and we have a reproducer[3] that exposes the problem. According to our tests, removing this line does not change the fix provided. It also seems that cinder no longer uses[4] logging native thread."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7807f6f3_235b2d42","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":61},"updated":"2024-05-07 11:44:03.000000000","message":"Would be good to give the initial context that lead us to work on this topic.\n\nIndeed, we initially started to work on this topic with the intention to solve the problem of using the Eventlet `hub_prevent_multiple_readers` debug feature. This feature is a debug convenience. This feature is not supported by the new asyncio hub of Eventlet. \n\nhttps://review.opendev.org/c/openstack/governance/+/902585/17..18\n\nIn parallel using this feature should be really carefully considered. Indeed, using this debug feature abruptly remove green threads protections through oslo.log. When using this feature green threads are not safe. Several side effects may be expected around file descriptors, especially with sockets, and so many unexpected behavior can arise with memcached, rabbitmq, etc in a monkey patched context.\n\nBeyond this problem, we should also notice that by using this debug feature inside oslo.log, we also disabled the thread protection for all the consumers of oslo.log (nova, etc...). This oslo.log fix remove the thread protection in the entire stack of the services which use the oslo.log library. Meaning that all services which were not exposed to the original logging problem [1], by example nova (apparently), then, are now exposed to the side effects of using debug feature. All their green threads aren\u0027t anymore \"safe\".Nova is now potentially exposed to unexpected side effects on its file descriptors consumptions and also exposed to potential side effects with its sockets.\n\n[1] https://bugs.launchpad.net/oslo.log/+bug/1983863/","commit_id":"741388754a68b8e65ae2ecfc78f46bdda04ee570"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"41d7e793543f22ff5e0d2057cf898bbf0eb60eca","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the usage of the debug feature from eventlet."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem with disabling this procedure is that it exposes you to risk. Deactivation applies to the entire stack. If a project uses oslo.log, for example nova, then it exposes all threads to concurrent access on the process file descriptors."},{"line_number":10,"context_line":"As explained in the function\u0027s documentation[1], when several greenlets are reading from the same socket, it\u0027s difficult to predict which greenlet will receive which data."},{"line_number":11,"context_line":"You really need to be sure of what you\u0027re doing to use this function. Also explained in the raise condition added by this commit[2] and we have a reproducer[3] that exposes the problem. According to our tests, removing this line does not change the fix provided. It also seems that cinder no longer uses[4] logging native thread."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d8bc9cca_d1390601","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":61},"in_reply_to":"7807f6f3_235b2d42","updated":"2024-05-08 09:33:55.000000000","message":"Done","commit_id":"741388754a68b8e65ae2ecfc78f46bdda04ee570"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"47e54e02840c337b4b0ecab04a1ea2d83a2d837e","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem with disabling this procedure is that it exposes you to risk. Deactivation applies to the entire stack. If a project uses oslo.log, for example nova, then it exposes all threads to concurrent access on the process file descriptors."},{"line_number":10,"context_line":"As explained in the function\u0027s documentation[1], when several greenlets are reading from the same socket, it\u0027s difficult to predict which greenlet will receive which data."},{"line_number":11,"context_line":"You really need to be sure of what you\u0027re doing to use this function. Also explained in the raise condition added by this commit[2] and we have a reproducer[3] that exposes the problem. According to our tests, removing this line does not change the fix provided. It also seems that cinder no longer uses[4] logging native thread."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1983863"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7894c340_148213ed","line":11,"range":{"start_line":11,"start_character":186,"end_line":11,"end_character":262},"updated":"2024-05-07 11:44:03.000000000","message":"I confirm that our tested shown that even without using this Eventlet debug feature, the oslo.log fix originally proposed [1], still works.\n\nAdditional tests can be made by using our reproducer [2].\n\n[1] https://opendev.org/openstack/oslo.log/commit/94b9dc32ec1f52a582adbd97fe2847f7c87d6c17\n[2] https://github.com/4383/oslo.log/blob/reproducer2/reproducer.py","commit_id":"741388754a68b8e65ae2ecfc78f46bdda04ee570"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d5ddda7288c044aff8389bce1bbff1339254cc28","unresolved":true,"context_lines":[{"line_number":10,"context_line":"As explained in the function\u0027s documentation[1], when several greenlets are reading from the same socket, it\u0027s difficult to predict which greenlet will receive which data."},{"line_number":11,"context_line":"You really need to be sure of what you\u0027re doing to use this function. Also explained in the raise condition added by this commit[2] and we have a reproducer[3] that exposes the problem. According to our tests, removing this line does not change the fix provided. It also seems that cinder no longer uses[4] logging native thread."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1983863"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/eventlet/eventlet/blob/master/eventlet/debug.py#L149"},{"line_number":16,"context_line":"[2] https://github.com/eventlet/eventlet/commit/cb7c8c0196ed70665b0382909141ac743d7633a2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b5979f18_9226da03","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":20},"updated":"2024-05-07 12:50:55.000000000","message":"please correct me if I\u0027m wrong but this is not the direct fix of this bug, right ? Then I think we should not use Closes-Bug tag but should use Related-Bug, and need a dedicate bug for this change.","commit_id":"741388754a68b8e65ae2ecfc78f46bdda04ee570"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"41d7e793543f22ff5e0d2057cf898bbf0eb60eca","unresolved":true,"context_lines":[{"line_number":10,"context_line":"As explained in the function\u0027s documentation[1], when several greenlets are reading from the same socket, it\u0027s difficult to predict which greenlet will receive which data."},{"line_number":11,"context_line":"You really need to be sure of what you\u0027re doing to use this function. Also explained in the raise condition added by this commit[2] and we have a reproducer[3] that exposes the problem. According to our tests, removing this line does not change the fix provided. It also seems that cinder no longer uses[4] logging native thread."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1983863"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/eventlet/eventlet/blob/master/eventlet/debug.py#L149"},{"line_number":16,"context_line":"[2] https://github.com/eventlet/eventlet/commit/cb7c8c0196ed70665b0382909141ac743d7633a2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e2a7eb73_57592820","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":20},"in_reply_to":"b25b40d0_0725421d","updated":"2024-05-08 09:33:55.000000000","message":"Change to Related-Bug sorry, I\u0027m not sure we need to create a new bug for this change.","commit_id":"741388754a68b8e65ae2ecfc78f46bdda04ee570"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b52b93f0b540053ded2b587d06b6c20f0b07ba00","unresolved":true,"context_lines":[{"line_number":10,"context_line":"As explained in the function\u0027s documentation[1], when several greenlets are reading from the same socket, it\u0027s difficult to predict which greenlet will receive which data."},{"line_number":11,"context_line":"You really need to be sure of what you\u0027re doing to use this function. Also explained in the raise condition added by this commit[2] and we have a reproducer[3] that exposes the problem. According to our tests, removing this line does not change the fix provided. It also seems that cinder no longer uses[4] logging native thread."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1983863"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/eventlet/eventlet/blob/master/eventlet/debug.py#L149"},{"line_number":16,"context_line":"[2] https://github.com/eventlet/eventlet/commit/cb7c8c0196ed70665b0382909141ac743d7633a2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b25b40d0_0725421d","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":20},"in_reply_to":"b5979f18_9226da03","updated":"2024-05-07 12:56:27.000000000","message":"I agree with Takashi, this is more a related topic than a \"closing\" solution.","commit_id":"741388754a68b8e65ae2ecfc78f46bdda04ee570"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7ec9010de730093cc142599a989bbe6cb7ae0dfc","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the usage of the Eventlet debug feature from oslo.log."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We initially started to work on this topic with the intention to solve the problem of using the Eventlet hub_prevent_multiple_readers debug feature. This feature is a debug convenience. This feature is not supported by the new asyncio hub[1] of Eventlet."},{"line_number":10,"context_line":"The problem with disabling this procedure is that it exposes you to risk. Deactivation applies to the entire stack. If a project uses oslo.log, for example nova, then it exposes all threads to concurrent access on the process file descriptors."},{"line_number":11,"context_line":"As explained in the function\u0027s documentation[2], when several greenlets are reading from the same socket, it\u0027s difficult to predict which greenlet will receive which data."},{"line_number":12,"context_line":"You really need to be sure of what you\u0027re doing to use this function. Also explained in the raise condition added by this commit[3] and we have a reproducer[4] that exposes the problem. According to our tests, removing this line does not change the fix provided. It also seems that cinder no longer uses[5] logging native thread."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f19736c_7502f698","line":9,"updated":"2024-05-15 10:35:45.000000000","message":"It seems the lines in the whole paragraph are too long. Can you wrap these by 72 chars when you respin ?\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"ff0f3330236afaf18e556f860f08c088604a55be"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"e9959f3d90a8fcf0f4d244abf31a8eb132187c90","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the usage of the Eventlet debug feature from oslo.log."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We initially started to work on this topic with the intention to solve the problem of using the Eventlet hub_prevent_multiple_readers debug feature. This feature is a debug convenience. This feature is not supported by the new asyncio hub[1] of Eventlet."},{"line_number":10,"context_line":"The problem with disabling this procedure is that it exposes you to risk. Deactivation applies to the entire stack. If a project uses oslo.log, for example nova, then it exposes all threads to concurrent access on the process file descriptors."},{"line_number":11,"context_line":"As explained in the function\u0027s documentation[2], when several greenlets are reading from the same socket, it\u0027s difficult to predict which greenlet will receive which data."},{"line_number":12,"context_line":"You really need to be sure of what you\u0027re doing to use this function. Also explained in the raise condition added by this commit[3] and we have a reproducer[4] that exposes the problem. According to our tests, removing this line does not change the fix provided. It also seems that cinder no longer uses[5] logging native thread."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"c9c6dea9_133385cc","line":9,"in_reply_to":"7f19736c_7502f698","updated":"2024-05-15 11:28:19.000000000","message":"Done","commit_id":"ff0f3330236afaf18e556f860f08c088604a55be"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e30bdf4bd2b620899c4e7be41c1321d800f5c5e7","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We initially started to work on this topic with the intention to solve"},{"line_number":10,"context_line":"the problem of using the Eventlet hub_prevent_multiple_readers debug feature."},{"line_number":11,"context_line":"This feature is a debug convenience. This feature is not supported by the new"},{"line_number":12,"context_line":"asyncio hub[1] of Eventlet. The problem with disabling this procedure is that"},{"line_number":13,"context_line":"it exposes you to risk. Deactivation applies to the entire stack. If a project"},{"line_number":14,"context_line":"uses oslo.log, for example nova, then it exposes all threads to concurrent access"},{"line_number":15,"context_line":"on the process file descriptors."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"fa184b93_f1c4db8d","line":12,"range":{"start_line":11,"start_character":37,"end_line":12,"end_character":26},"updated":"2024-05-16 09:11:20.000000000","message":"You can also add a link toward this section doc https://eventlet.readthedocs.io/en/latest/asyncio/migration.html#known-limitations-and-work-in-progress","commit_id":"afb718ce1c62c88e476c200d96af7e7b27b03ad7"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"99d1d45ee3ec40b3824df8a3ec068c65ed1cd2d9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We initially started to work on this topic with the intention to solve"},{"line_number":10,"context_line":"the problem of using the Eventlet hub_prevent_multiple_readers debug feature."},{"line_number":11,"context_line":"This feature is a debug convenience. This feature is not supported by the new"},{"line_number":12,"context_line":"asyncio hub[1] of Eventlet. The problem with disabling this procedure is that"},{"line_number":13,"context_line":"it exposes you to risk. Deactivation applies to the entire stack. If a project"},{"line_number":14,"context_line":"uses oslo.log, for example nova, then it exposes all threads to concurrent access"},{"line_number":15,"context_line":"on the process file descriptors."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"0ac6a252_31a6fac2","line":12,"range":{"start_line":11,"start_character":37,"end_line":12,"end_character":26},"in_reply_to":"fa184b93_f1c4db8d","updated":"2024-05-16 09:45:57.000000000","message":"Done","commit_id":"afb718ce1c62c88e476c200d96af7e7b27b03ad7"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8d1bb9385ee32b4173af02672aae4a2662586033","unresolved":true,"context_lines":[{"line_number":9,"context_line":"We initially started to work on this topic with the intention to solve"},{"line_number":10,"context_line":"the problem of using the Eventlet hub_prevent_multiple_readers debug feature."},{"line_number":11,"context_line":"This feature is a debug convenience. This feature is not supported by the new"},{"line_number":12,"context_line":"asyncio hub[1] of Eventlet. The problem with disabling this procedure is that"},{"line_number":13,"context_line":"it exposes you to risk. Deactivation applies to the entire stack. If a project"},{"line_number":14,"context_line":"uses oslo.log, for example nova, then it exposes all threads to concurrent access"},{"line_number":15,"context_line":"on the process file descriptors."},{"line_number":16,"context_line":"As explained in the function\u0027s documentation[2], when several greenlets are reading from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"f16547bc_f67fe66e","line":13,"range":{"start_line":12,"start_character":28,"end_line":13,"end_character":21},"updated":"2024-05-16 08:05:22.000000000","message":"Please update this sentence with a link (a reference) to https://eventlet.readthedocs.io/en/latest/reference/api/eventlet.html#eventlet.debug.hub_prevent_multiple_readers\n\nand please that link at the both of this message with the other links","commit_id":"afb718ce1c62c88e476c200d96af7e7b27b03ad7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d5ddda7288c044aff8389bce1bbff1339254cc28","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"491c3368_83de26c0","updated":"2024-05-07 12:50:55.000000000","message":"I\u0027d agree with the direction but a few points need to be addressed.\n\n* The failure in unit tests looks a real one caused by this change\n* Please consider creating a new bug instead of using the existing closed one\n\nalso, as a side note, we may want an early release of oslo.log so that we can test the other projects with this change, to catch any problems caused by their unexpected usage.","commit_id":"741388754a68b8e65ae2ecfc78f46bdda04ee570"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"3bc6ed29d9b586deae7a3a1a194796567d655413","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"16ab6655_bd699fd6","updated":"2024-05-07 12:53:54.000000000","message":"Should be worth to also indicate in the commit message that using this Eventlet debug feature is blocker for migration initiative https://review.opendev.org/c/openstack/devstack/+/914108","commit_id":"741388754a68b8e65ae2ecfc78f46bdda04ee570"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"ec9624c7aa2f1f05ef250b29dae612e16cf12f9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0326aae1_0a9345ed","updated":"2024-05-07 12:40:48.000000000","message":"The failing test [1] do not reflect the reality...\n\nIt do not test tpool like it pretends... it test a restored version of the threading module [2], that\u0027s not the same thing [3].\n\nIMO if we move this test to tpool usages will fix the CI problem and will reflect the real intention of this test.\n\n[1] https://zuul.opendev.org/t/openstack/build/9246820368cd43c88b9e4c1acd2fdbce/log/job-output.txt#2124\n[2] https://opendev.org/openstack/oslo.log/src/branch/master/oslo_log/tests/unit/test_pipe_mutex.py#L144\n[3] https://eventlet.readthedocs.io/en/latest/threading.html#eventlet.tpool.execute","commit_id":"741388754a68b8e65ae2ecfc78f46bdda04ee570"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"adfeabb07e8e3ee4cc1af59df0ba2bd424fb4548","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b839e817_8e2310a8","updated":"2024-05-07 12:14:00.000000000","message":"This is how to use the reproducer:\n\n1. clone this patch locally (`git review -d 918426`)\n2. copy the reproducer script into your local copy\n3. run the following command:\n```\n$ tox -e venv -- python reproducer.py\n```","commit_id":"741388754a68b8e65ae2ecfc78f46bdda04ee570"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b52b93f0b540053ded2b587d06b6c20f0b07ba00","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"43f2b527_d55b761a","in_reply_to":"491c3368_83de26c0","updated":"2024-05-07 12:56:27.000000000","message":"See my previous comment about the unit test failure.","commit_id":"741388754a68b8e65ae2ecfc78f46bdda04ee570"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"2105709394420610f4578c1f993be4902521dfd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1b7bb33d_30a95784","updated":"2024-05-13 07:17:42.000000000","message":"The `tpool` module is not accessible from a base eventlet import (`import eventlet`). It should be imported on its own:\n\n```\nimport eventlet.tpool\n# or\nfrom eventlet import tpool\n```\n\nPlease see the eventlet doc:\n\nhttps://eventlet.readthedocs.io/en/latest/threading.html#tpool-simple-thread-pool\n\nLeading us to the broken CI:\n\n```\n2024-05-08 12:26:41.082322 | debian-bookworm | Captured traceback:\n2024-05-08 12:26:41.082340 | debian-bookworm | ~~~~~~~~~~~~~~~~~~~\n2024-05-08 12:26:41.082355 | debian-bookworm |     Traceback (most recent call last):\n2024-05-08 12:26:41.082370 | debian-bookworm |\n2024-05-08 12:26:41.082385 | debian-bookworm |       File \"/home/zuul/src/opendev.org/openstack/oslo.log/oslo_log/tests/unit/test_pipe_mutex.py\", line 191, in test_blocking_preserves_ownership\n2024-05-08 12:26:41.082401 | debian-bookworm |     real_thread1 \u003d eventlet.tpool.execute(pthread1)\n2024-05-08 12:26:41.082416 | debian-bookworm |                    ^^^^^^^^^^^^^^\n2024-05-08 12:26:41.082431 | debian-bookworm |\n2024-05-08 12:26:41.082445 | debian-bookworm |     AttributeError: module \u0027eventlet\u0027 has no attribute \u0027tpool\u0027\n```","commit_id":"326ee3565165324ced0c7f6bc4f7b300835440a3"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"2b62ef18855b3a3046c52627038529fd0c60df4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"20db8b5a_c29bf669","in_reply_to":"1b7bb33d_30a95784","updated":"2024-05-13 08:07:37.000000000","message":"Yes right. I have fixed that but forget to push.","commit_id":"326ee3565165324ced0c7f6bc4f7b300835440a3"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1e7b63db40c75a6e75bca4d751c488908f395a73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"31a26b44_357371c8","updated":"2024-05-13 11:16:01.000000000","message":"Please can you also add a release note with a summary of these changes.\nThanks in advance.","commit_id":"e559b1e736a4d3501aeece97b4b4791a300eca93"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7ec9010de730093cc142599a989bbe6cb7ae0dfc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b52ca338_fc9fc3e5","in_reply_to":"31a26b44_357371c8","updated":"2024-05-15 10:35:45.000000000","message":"+1","commit_id":"e559b1e736a4d3501aeece97b4b4791a300eca93"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"e9959f3d90a8fcf0f4d244abf31a8eb132187c90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2ef3441b_ac14d854","in_reply_to":"b52ca338_fc9fc3e5","updated":"2024-05-15 11:28:19.000000000","message":"Done","commit_id":"e559b1e736a4d3501aeece97b4b4791a300eca93"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7ec9010de730093cc142599a989bbe6cb7ae0dfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"95d5ce50_3a7f9803","updated":"2024-05-15 10:35:45.000000000","message":"I\u0027ll have more detailed look later, but am leaving a few comments so that these are not missed.","commit_id":"ff0f3330236afaf18e556f860f08c088604a55be"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b9bb22be3f314bed9deabcc5abf702f864ed1bff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"04c11bee_a1d984cd","updated":"2024-05-15 16:22:11.000000000","message":"Almost there","commit_id":"77e39f14cffa3c79fa6096693e84b567c6ee92d7"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8d1bb9385ee32b4173af02672aae4a2662586033","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"194b23a0_5d5d1d91","updated":"2024-05-16 08:05:22.000000000","message":"Please, one last thing, see my inline comments.\n(-1\u0027ed to highlight my comment)","commit_id":"afb718ce1c62c88e476c200d96af7e7b27b03ad7"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7b800a1833c4199f1b8dedfe2bbe8a869fb872d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"e0b20851_332e533e","updated":"2024-05-16 06:52:32.000000000","message":"Thanks Daniel","commit_id":"afb718ce1c62c88e476c200d96af7e7b27b03ad7"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"53fb621c64e5523c7c2c9eeb8fb25ccecce7323a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"ad966e2d_cc1790ee","updated":"2024-05-16 12:25:40.000000000","message":"Before merging this patch, I\u0027d suggest that we realize one last test with https://review.opendev.org/c/openstack/devstack/+/914108","commit_id":"8705f67bfbd733edf923003c0a5850e7a4a5735b"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"67801546c048ba98e05ac267ea235ca70923e439","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3824c545_daf20993","updated":"2024-05-21 07:17:41.000000000","message":"Thanks Sean for your confirmation","commit_id":"8705f67bfbd733edf923003c0a5850e7a4a5735b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cf10823b8d86449e9c2fb444047d0d01c63dc115","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"c9d3065f_94221261","updated":"2024-05-20 10:22:08.000000000","message":"this looks ok to me over all.","commit_id":"8705f67bfbd733edf923003c0a5850e7a4a5735b"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"47cf24c3f80665c29b970f8e55fa2e5e8e754a9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"ff5eb1c7_3f720f31","in_reply_to":"9bee7e70_927d6c62","updated":"2024-05-20 08:37:06.000000000","message":"I think we can merge it.","commit_id":"8705f67bfbd733edf923003c0a5850e7a4a5735b"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"7f5ebabbc713a2e17622520720d24454dc6a7f37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9bee7e70_927d6c62","in_reply_to":"ad966e2d_cc1790ee","updated":"2024-05-16 22:32:59.000000000","message":"Ok I work on that.","commit_id":"8705f67bfbd733edf923003c0a5850e7a4a5735b"}],"oslo_log/tests/unit/test_pipe_mutex.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1e7b63db40c75a6e75bca4d751c488908f395a73","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        self.assertEqual(\u0027\u0027.join(sequence), \"\u003c\u003e\" * 40)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def test_blocking_preserves_ownership(self):"},{"line_number":159,"context_line":"        pthread1_event \u003d eventlet.patcher.original(\u0027threading\u0027).Event()"},{"line_number":160,"context_line":"        pthread2_event1 \u003d eventlet.patcher.original(\u0027threading\u0027).Event()"},{"line_number":161,"context_line":"        pthread2_event2 \u003d eventlet.patcher.original(\u0027threading\u0027).Event()"},{"line_number":162,"context_line":"        thread_id \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"70547ff0_7e0e9032","line":159,"range":{"start_line":159,"start_character":33,"end_line":159,"end_character":63},"updated":"2024-05-13 11:16:01.000000000","message":"We should not mixing native threads and greenthreads without using tpool. Now that you replaced native threads usages by tpool, we should only rely on green events:\n\n`pthread1_event \u003d eventlet.Event()`\n\nUnpatching the Event module is not anymore necessary.\nThe same is true for the lines below.","commit_id":"e559b1e736a4d3501aeece97b4b4791a300eca93"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"01591b32f1741585820f26b7c986174f6a95e5b9","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        self.assertEqual(\u0027\u0027.join(sequence), \"\u003c\u003e\" * 40)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def test_blocking_preserves_ownership(self):"},{"line_number":159,"context_line":"        pthread1_event \u003d eventlet.patcher.original(\u0027threading\u0027).Event()"},{"line_number":160,"context_line":"        pthread2_event1 \u003d eventlet.patcher.original(\u0027threading\u0027).Event()"},{"line_number":161,"context_line":"        pthread2_event2 \u003d eventlet.patcher.original(\u0027threading\u0027).Event()"},{"line_number":162,"context_line":"        thread_id \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"8a64c450_3f56d2c1","line":159,"range":{"start_line":159,"start_character":33,"end_line":159,"end_character":63},"in_reply_to":"70547ff0_7e0e9032","updated":"2024-05-13 11:17:03.000000000","message":"Yes right.","commit_id":"e559b1e736a4d3501aeece97b4b4791a300eca93"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b9bb22be3f314bed9deabcc5abf702f864ed1bff","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        self.assertEqual(\u0027\u0027.join(sequence), \"\u003c\u003e\" * 40)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def test_blocking_preserves_ownership(self):"},{"line_number":159,"context_line":"        pthread1_event \u003d eventlet.patcher.original(\u0027threading\u0027).Event()"},{"line_number":160,"context_line":"        pthread2_event1 \u003d eventlet.patcher.original(\u0027threading\u0027).Event()"},{"line_number":161,"context_line":"        pthread2_event2 \u003d eventlet.patcher.original(\u0027threading\u0027).Event()"},{"line_number":162,"context_line":"        thread_id \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"d4dfe2a2_b823f0c2","line":159,"range":{"start_line":159,"start_character":33,"end_line":159,"end_character":63},"in_reply_to":"8a64c450_3f56d2c1","updated":"2024-05-15 16:22:11.000000000","message":"Done","commit_id":"e559b1e736a4d3501aeece97b4b4791a300eca93"}],"releasenotes/notes/remove-eventlet-hub_prevent_multiple_readers-usage-b23cea69a05cd6d4.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b9bb22be3f314bed9deabcc5abf702f864ed1bff","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the usage of the Eventlet debug feature from oslo.log"},{"line_number":5,"context_line":"    Then hub_prevent_multiple_readers is a debug convenience. This"},{"line_number":6,"context_line":"    feature is not supported by the newvasyncio hub[1] of Eventlet."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  [1] https://review.opendev.org/c/openstack/governance/+/902585/17..18"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dcbc4387_058e8912","line":6,"range":{"start_line":5,"start_character":62,"end_line":6,"end_character":67},"updated":"2024-05-15 16:22:11.000000000","message":"Here I would rather suggest to explain why using this debug convenience is a problem for the process running with it:\n\n\u003e This feature is a debug convenience. The problem with disabling this procedure is \u003e that it exposes you to risk. Deactivation applies to the entire stack.\n\u003e If a project uses oslo.log, for example nova, then it exposes all\n\u003e threads to concurrent access blablabla\n\nAnd that services using oslo.log should prefer using tpool rather than un-monkey patched version of the stdlib threading module which is not compatible with eventlet...","commit_id":"77e39f14cffa3c79fa6096693e84b567c6ee92d7"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b9bb22be3f314bed9deabcc5abf702f864ed1bff","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the usage of the Eventlet debug feature from oslo.log"},{"line_number":5,"context_line":"    Then hub_prevent_multiple_readers is a debug convenience. This"},{"line_number":6,"context_line":"    feature is not supported by the newvasyncio hub[1] of Eventlet."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  [1] https://review.opendev.org/c/openstack/governance/+/902585/17..18"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5b9e9119_e3f8352b","line":6,"range":{"start_line":6,"start_character":36,"end_line":6,"end_character":47},"updated":"2024-05-15 16:22:11.000000000","message":"nit","commit_id":"77e39f14cffa3c79fa6096693e84b567c6ee92d7"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"6e1c05ccae19cafd5e20786def2f5cde7d01118e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the usage of the Eventlet debug feature from oslo.log"},{"line_number":5,"context_line":"    Then hub_prevent_multiple_readers is a debug convenience. This"},{"line_number":6,"context_line":"    feature is not supported by the newvasyncio hub[1] of Eventlet."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  [1] https://review.opendev.org/c/openstack/governance/+/902585/17..18"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"64d59a64_9eab4a75","line":6,"range":{"start_line":6,"start_character":36,"end_line":6,"end_character":47},"in_reply_to":"5b9e9119_e3f8352b","updated":"2024-05-16 06:32:04.000000000","message":"Done","commit_id":"77e39f14cffa3c79fa6096693e84b567c6ee92d7"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"6e1c05ccae19cafd5e20786def2f5cde7d01118e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the usage of the Eventlet debug feature from oslo.log"},{"line_number":5,"context_line":"    Then hub_prevent_multiple_readers is a debug convenience. This"},{"line_number":6,"context_line":"    feature is not supported by the newvasyncio hub[1] of Eventlet."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  [1] https://review.opendev.org/c/openstack/governance/+/902585/17..18"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"26eb55fc_7150fc04","line":6,"range":{"start_line":5,"start_character":62,"end_line":6,"end_character":67},"in_reply_to":"dcbc4387_058e8912","updated":"2024-05-16 06:32:04.000000000","message":"Done","commit_id":"77e39f14cffa3c79fa6096693e84b567c6ee92d7"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b9bb22be3f314bed9deabcc5abf702f864ed1bff","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    Then hub_prevent_multiple_readers is a debug convenience. This"},{"line_number":6,"context_line":"    feature is not supported by the newvasyncio hub[1] of Eventlet."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  [1] https://review.opendev.org/c/openstack/governance/+/902585/17..18"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"8a6fcd5b_bea5638d","line":8,"range":{"start_line":8,"start_character":1,"end_line":8,"end_character":71},"updated":"2024-05-15 16:22:11.000000000","message":"If I\u0027m right, within reno links should be insider links and not bottom page links","commit_id":"77e39f14cffa3c79fa6096693e84b567c6ee92d7"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"6e1c05ccae19cafd5e20786def2f5cde7d01118e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    Then hub_prevent_multiple_readers is a debug convenience. This"},{"line_number":6,"context_line":"    feature is not supported by the newvasyncio hub[1] of Eventlet."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  [1] https://review.opendev.org/c/openstack/governance/+/902585/17..18"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"71c63796_3caed73f","line":8,"range":{"start_line":8,"start_character":1,"end_line":8,"end_character":71},"in_reply_to":"8a6fcd5b_bea5638d","updated":"2024-05-16 06:32:04.000000000","message":"Done","commit_id":"77e39f14cffa3c79fa6096693e84b567c6ee92d7"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"2a993dcd367fba97a704ecdfdda9f424941d0bee","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the usage of the Eventlet debug feature from oslo.log"},{"line_number":5,"context_line":"    Then hub_prevent_multiple_readers is a debug convenience. This"},{"line_number":6,"context_line":"    feature is not supported by the new asyncio hub of Eventlet."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9b4c8b05_9c20a47f","line":6,"range":{"start_line":5,"start_character":62,"end_line":6,"end_character":64},"updated":"2024-05-16 06:09:50.000000000","message":"Here I would rather suggest to explain why using this debug convenience is a problem for the process running with it:\n\n\u003e This feature is a debug convenience. The problem with disabling this procedure\n\u003e is that it exposes you to risk. Deactivation applies to the entire stack.\n\u003e If a project uses oslo.log, for example nova, then it exposes all\n\u003e threads to concurrent access blablabla\n\nAnd that services using oslo.log should prefer using tpool rather than un-monkey patched version of the stdlib threading module which is not compatible with eventlet...\n\nThe new eventlet hub is far to be adopted... I\u0027d not speak about it.","commit_id":"0c57d7c1ddcc9597162dd41dcaea9bee36c1150b"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"6e1c05ccae19cafd5e20786def2f5cde7d01118e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the usage of the Eventlet debug feature from oslo.log"},{"line_number":5,"context_line":"    Then hub_prevent_multiple_readers is a debug convenience. This"},{"line_number":6,"context_line":"    feature is not supported by the new asyncio hub of Eventlet."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"963b7e7b_3f3aca17","line":6,"range":{"start_line":5,"start_character":62,"end_line":6,"end_character":64},"in_reply_to":"9b4c8b05_9c20a47f","updated":"2024-05-16 06:32:04.000000000","message":"Done","commit_id":"0c57d7c1ddcc9597162dd41dcaea9bee36c1150b"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8d1bb9385ee32b4173af02672aae4a2662586033","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the usage of the Eventlet debug feature from oslo.log"},{"line_number":5,"context_line":"    Then hub_prevent_multiple_readers is a debug convenience. This"},{"line_number":6,"context_line":"    feature is a debug convenience. The problem with disabling this"},{"line_number":7,"context_line":"    procedure is that it exposes you to risk. Deactivation applies"},{"line_number":8,"context_line":"    to the entire stack. If a project uses oslo.log, for example nova,"},{"line_number":9,"context_line":"    then it exposes all threads to concurrent access on the process file"},{"line_number":10,"context_line":"    descriptors. When several greenlets are reading from the same socket,"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"b3605f31_be361699","line":7,"range":{"start_line":6,"start_character":36,"end_line":7,"end_character":44},"updated":"2024-05-16 08:05:22.000000000","message":"Please add an inline link who refer to https://eventlet.readthedocs.io/en/latest/reference/api/eventlet.html#eventlet.debug.hub_prevent_multiple_readers","commit_id":"afb718ce1c62c88e476c200d96af7e7b27b03ad7"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"9957e9bd90bc70608f615ab81a98f2c57f836765","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the usage of the Eventlet debug feature from oslo.log"},{"line_number":5,"context_line":"    Then hub_prevent_multiple_readers is a debug convenience. This"},{"line_number":6,"context_line":"    feature is a debug convenience. The problem with disabling this"},{"line_number":7,"context_line":"    procedure is that it exposes you to risk. Deactivation applies"},{"line_number":8,"context_line":"    to the entire stack. If a project uses oslo.log, for example nova,"},{"line_number":9,"context_line":"    then it exposes all threads to concurrent access on the process file"},{"line_number":10,"context_line":"    descriptors. When several greenlets are reading from the same socket,"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"68910a8b_2d2e6b73","line":7,"range":{"start_line":6,"start_character":36,"end_line":7,"end_character":44},"in_reply_to":"51873b0a_2fafb869","updated":"2024-05-17 09:32:47.000000000","message":"Maybe we can rebase it here?","commit_id":"afb718ce1c62c88e476c200d96af7e7b27b03ad7"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"2d776e6db4662bd481cdc91a3b7108b0c2d0b77b","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the usage of the Eventlet debug feature from oslo.log"},{"line_number":5,"context_line":"    Then hub_prevent_multiple_readers is a debug convenience. This"},{"line_number":6,"context_line":"    feature is a debug convenience. The problem with disabling this"},{"line_number":7,"context_line":"    procedure is that it exposes you to risk. Deactivation applies"},{"line_number":8,"context_line":"    to the entire stack. If a project uses oslo.log, for example nova,"},{"line_number":9,"context_line":"    then it exposes all threads to concurrent access on the process file"},{"line_number":10,"context_line":"    descriptors. When several greenlets are reading from the same socket,"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ff951429_e0311702","line":7,"range":{"start_line":6,"start_character":36,"end_line":7,"end_character":44},"in_reply_to":"b3605f31_be361699","updated":"2024-05-16 10:10:49.000000000","message":"You forgot to add that link...\nDoesn\u0027t matter, lets merge this patch and lets update this release note through a follow up patch...","commit_id":"afb718ce1c62c88e476c200d96af7e7b27b03ad7"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"53fb621c64e5523c7c2c9eeb8fb25ccecce7323a","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove the usage of the Eventlet debug feature from oslo.log"},{"line_number":5,"context_line":"    Then hub_prevent_multiple_readers is a debug convenience. This"},{"line_number":6,"context_line":"    feature is a debug convenience. The problem with disabling this"},{"line_number":7,"context_line":"    procedure is that it exposes you to risk. Deactivation applies"},{"line_number":8,"context_line":"    to the entire stack. If a project uses oslo.log, for example nova,"},{"line_number":9,"context_line":"    then it exposes all threads to concurrent access on the process file"},{"line_number":10,"context_line":"    descriptors. When several greenlets are reading from the same socket,"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"51873b0a_2fafb869","line":7,"range":{"start_line":6,"start_character":36,"end_line":7,"end_character":44},"in_reply_to":"ff951429_e0311702","updated":"2024-05-16 12:25:40.000000000","message":"Follow up patch created https://review.opendev.org/c/openstack/oslo.log/+/919822","commit_id":"afb718ce1c62c88e476c200d96af7e7b27b03ad7"}]}