)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"927303b384b43118c6aa9ed63cdacea7389fbaba","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Itamar Turner-Trauring \u003citamar@pythonspeed.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-20 10:06:52 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support running tests with eventlet monkey patching, and fix deadlock this found."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie9e012ac73bbfa8b5e6e0f610c11868466c7cf4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9b551dd2_beaaedc9","line":7,"updated":"2024-11-20 23:55:40.000000000","message":"IDK if it matters enough for oslo to reject a patch for it, but this is longer than 50 lines and ends with a period: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"178d93e978d0f513ba08a32fcf8c29fdf9d613ab"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c3320ad94ee027028462914238d9f99945175ace","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Itamar Turner-Trauring \u003citamar@pythonspeed.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-20 10:06:52 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support running tests with eventlet monkey patching, and fix deadlock this found."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie9e012ac73bbfa8b5e6e0f610c11868466c7cf4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aee07b0_e14e487a","line":7,"in_reply_to":"9b551dd2_beaaedc9","updated":"2024-11-21 09:49:23.000000000","message":"I don\u0027t think that this is a blocker for us","commit_id":"178d93e978d0f513ba08a32fcf8c29fdf9d613ab"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0b9f3e3ffff98716d402889534be95d083cf18d5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fc87d657_16d84e5e","updated":"2024-11-21 17:47:30.000000000","message":"I\u0027ll own the follow-ups to this patch. Will get around to pushing an update today or tomorrow.","commit_id":"178d93e978d0f513ba08a32fcf8c29fdf9d613ab"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1e281838696c31d18d2632cd6a25efe4a504df31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"02811019_2fb683e9","updated":"2024-11-20 16:09:30.000000000","message":"Just for context and history, there are previous attempts to remove the pipemutex in oslo.log:\n- https://review.opendev.org/c/openstack/oslo.log/+/923961\n- https://review.opendev.org/c/openstack/oslo.log/+/918426","commit_id":"178d93e978d0f513ba08a32fcf8c29fdf9d613ab"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"a6b37c7dcb334d03ce5e5f8288347faf86e88db9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"23de904a_d4472f57","updated":"2024-11-20 15:26:06.000000000","message":"Thank you Itamar.\nDo you mind if I attach your patch to the eventlet-removal topic?\nhttps://review.opendev.org/q/topic:%22eventlet-removal%22\n\nIt help us to track all the pieces of puzzle. The oslo.log patches around eventlet are significant ones, so it would be good to have them hosted into this topic.","commit_id":"178d93e978d0f513ba08a32fcf8c29fdf9d613ab"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"72693a30f4f79bd6d607f510e5fa519cc0a9a1df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0b5dcfa8_3c998857","updated":"2024-11-22 09:12:31.000000000","message":"Excellent guys, thank you!","commit_id":"98bb185f15d1d74a40d7473887d7c57b966ae048"}],"tox.ini":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b2d8943ab794b14107b73d8ed8ef45b567b63355","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  # Without eventlet monkeypatching:"},{"line_number":17,"context_line":"  stestr run {posargs}"},{"line_number":18,"context_line":"  # With eventlet monkeypatching, with the default hub:"},{"line_number":19,"context_line":"  env OSLO_LOG_TEST_EVENTLET\u003d1 stestr run {posargs}"},{"line_number":20,"context_line":"  stestr slowest"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[testenv:pep8]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"6058187d_03775694","line":19,"range":{"start_line":19,"start_character":2,"end_line":19,"end_character":30},"updated":"2024-11-21 09:56:57.000000000","message":"Can we rather use `passenv` to give `OSLO_LOG_TEST_EVENTLET` instead of forcing here?\n\nHence, the user would be able to tweak this env var in his shell and the `stestr`  call and the tox.ini logic will remains more or less the same no matter if eventlet is used or not","commit_id":"178d93e978d0f513ba08a32fcf8c29fdf9d613ab"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f6c945ca5359dc63440b3108111f3c74d49df335","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  # Without eventlet monkeypatching:"},{"line_number":17,"context_line":"  stestr run {posargs}"},{"line_number":18,"context_line":"  # With eventlet monkeypatching, with the default hub:"},{"line_number":19,"context_line":"  env OSLO_LOG_TEST_EVENTLET\u003d1 stestr run {posargs}"},{"line_number":20,"context_line":"  stestr slowest"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[testenv:pep8]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"c903e8df_2296092f","line":19,"range":{"start_line":19,"start_character":2,"end_line":19,"end_character":30},"in_reply_to":"3d71ab4a_00b49759","updated":"2024-11-21 10:04:21.000000000","message":"And if we want to go further with gates and jobs and test both versions, maybe we can add some new zuul config here and play with this env var again https://opendev.org/openstack/oslo.log/src/branch/master/.zuul.yaml","commit_id":"178d93e978d0f513ba08a32fcf8c29fdf9d613ab"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1bd7666bd24aba00c71967f1836f1b5e2dc8bdca","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  # Without eventlet monkeypatching:"},{"line_number":17,"context_line":"  stestr run {posargs}"},{"line_number":18,"context_line":"  # With eventlet monkeypatching, with the default hub:"},{"line_number":19,"context_line":"  env OSLO_LOG_TEST_EVENTLET\u003d1 stestr run {posargs}"},{"line_number":20,"context_line":"  stestr slowest"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[testenv:pep8]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3d71ab4a_00b49759","line":19,"range":{"start_line":19,"start_character":2,"end_line":19,"end_character":30},"in_reply_to":"6058187d_03775694","updated":"2024-11-21 10:02:18.000000000","message":"It would give something like:\n\n```\n[testenv]\nbasepython \u003d python3\nallowlist_externals \u003d\n  find\n  env\ndeps \u003d\n  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}\n  -r{toxinidir}/test-requirements.txt\npassenv \u003d OSLO_LOG_TEST_EVENTLET\ncommands \u003d\n  find . -type f -name \"*.pyc\" -delete\n  stestr run {posargs}\n```\n\nand it would be tweaked like that:\n\n`export OSLO_LOG_TEST_EVENTLET\u003d1; tox`","commit_id":"178d93e978d0f513ba08a32fcf8c29fdf9d613ab"}]}