)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"12ec43b31502128299ee64a1b1dc33e586d71344","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ff2c4291_6861f9bb","updated":"2026-04-28 08:08:51.000000000","message":"A minor concern, but IMO not a blocker, see my inline comment,","commit_id":"10be32cbf1546aac6df186fd84fb9835a0b56dd3"}],"tox.ini":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"405c6e1edd5069ec7dea23e641972c4486f7fafb","unresolved":true,"context_lines":[{"line_number":55,"context_line":"allowlist_externals \u003d rm"},{"line_number":56,"context_line":"deps \u003d"},{"line_number":57,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":58,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":59,"context_line":"commands \u003d"},{"line_number":60,"context_line":"  rm -rf releasenotes/build"},{"line_number":61,"context_line":"  sphinx-build -a -E -W --keep-going -b html releasenotes/source releasenotes/build/html"}],"source_content_type":"text/x-properties","patch_set":1,"id":"74581121_66bc814e","side":"PARENT","line":58,"range":{"start_line":58,"start_character":2,"end_line":58,"end_character":36},"updated":"2026-04-28 08:02:10.000000000","message":"I tested your patch on a fresh clone of oslo.log on my laptop, and I wonder why this requirements file is still pulled when I run this tox target:\n\n```\n~/dev ❯ git clone https://opendev.org/openstack/oslo.log\nCloning into \u0027oslo.log\u0027...\nremote: Enumerating objects: 5971, done.\nremote: Counting objects: 100% (2436/2436), done.\nremote: Compressing objects: 100% (735/735), done.\nremote: Total 5971 (delta 2335), reused 1701 (delta 1701), pack-reused 3535 (from 1)\nReceiving objects: 100% (5971/5971), 1.09 MiB | 750.00 KiB/s, done.\nResolving deltas: 100% (3300/3300), done.\n\n~/dev ❯ cd oslo.log\n\noslo.log master ❯ git review -s\nCreating a git remote called \u0027gerrit\u0027 that maps to:\n\tssh://hberaud@review.opendev.org:29418/openstack/oslo.log.git\n\noslo.log master ❯ git review -d 986401\nDownloading refs/changes/01/986401/1 from gerrit\nSwitched to branch \"review/986401\"\n\noslo.log review/986401 ❯ tox -e releasenotes\nreleasenotes: install_deps\u003e python -I -m pip install -r /home/hberaud/dev/oslo.log/doc/requirements.txt -c https://releases.openstack.org/constraints/upper/master\n.pkg: install_requires\u003e python -I -m pip install \u0027pbr\u003e\u003d6.1.1\u0027\n.pkg: _optional_hooks\u003e python /home/hberaud/.local/share/mise/installs/python/3.14.0/lib/python3.14/site-packages/pyproject_api/_backend.py True pbr.build\n```","commit_id":"546add476e8a40954c9b34eb5fb584e5b2f1cb68"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"17e9421b04ff93d45a1b55214eba04fa2699dab1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"allowlist_externals \u003d rm"},{"line_number":56,"context_line":"deps \u003d"},{"line_number":57,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":58,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":59,"context_line":"commands \u003d"},{"line_number":60,"context_line":"  rm -rf releasenotes/build"},{"line_number":61,"context_line":"  sphinx-build -a -E -W --keep-going -b html releasenotes/source releasenotes/build/html"}],"source_content_type":"text/x-properties","patch_set":1,"id":"b2fe1b75_0ecbdf21","side":"PARENT","line":58,"range":{"start_line":58,"start_character":2,"end_line":58,"end_character":36},"in_reply_to":"01eeb919_787a87ff","updated":"2026-04-29 12:17:42.000000000","message":"Acknowledged","commit_id":"546add476e8a40954c9b34eb5fb584e5b2f1cb68"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8fc7ff313d23ed25ee82eb00fc1a431bbe294dcd","unresolved":true,"context_lines":[{"line_number":55,"context_line":"allowlist_externals \u003d rm"},{"line_number":56,"context_line":"deps \u003d"},{"line_number":57,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":58,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":59,"context_line":"commands \u003d"},{"line_number":60,"context_line":"  rm -rf releasenotes/build"},{"line_number":61,"context_line":"  sphinx-build -a -E -W --keep-going -b html releasenotes/source releasenotes/build/html"}],"source_content_type":"text/x-properties","patch_set":1,"id":"01eeb919_787a87ff","side":"PARENT","line":58,"range":{"start_line":58,"start_character":2,"end_line":58,"end_character":36},"in_reply_to":"1357486a_c1dea8c7","updated":"2026-04-28 16:39:08.000000000","message":"Sorry ignore my comment above. I misunderstood your comment.\n\nThe described behavior is expected. This change reuses the existing definition of docs env, which installs doc/requirements.txt.","commit_id":"546add476e8a40954c9b34eb5fb584e5b2f1cb68"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"253274b039c138ce0f58edcb9086f879841ab1a8","unresolved":true,"context_lines":[{"line_number":55,"context_line":"allowlist_externals \u003d rm"},{"line_number":56,"context_line":"deps \u003d"},{"line_number":57,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":58,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":59,"context_line":"commands \u003d"},{"line_number":60,"context_line":"  rm -rf releasenotes/build"},{"line_number":61,"context_line":"  sphinx-build -a -E -W --keep-going -b html releasenotes/source releasenotes/build/html"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1357486a_c1dea8c7","side":"PARENT","line":58,"range":{"start_line":58,"start_character":2,"end_line":58,"end_character":36},"in_reply_to":"74581121_66bc814e","updated":"2026-04-28 16:37:24.000000000","message":"requirements.txt is automatically loaded unless we set skip_install\u003dTrue. We can add it to the doc/releasenotes env (but that may be a separate topic).","commit_id":"546add476e8a40954c9b34eb5fb584e5b2f1cb68"}]}