)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c16fe6536733b916dfb3f8a79cce437506c539d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d0797241_6ddd9bce","updated":"2026-10-22 01:07:22.000000000","message":"lgtm except kombu \u003c5.2.4 support removal","commit_id":"2f5715d3058916e72e159093f9db87479194eb26"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"81f5de76d2e0a9d0c86765c16644e507bbad5841","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"98c7b14b_bd037d83","updated":"2026-10-22 10:06:55.000000000","message":"@mharley@redhat.com previously deprecated the `ssl_version` opt in https://review.opendev.org/c/openstack/oslo.messaging/+/991074/ on the basis that we could let py-amqp automatically configure this for us. I\u0027m sure there\u0027s a good reason for introducing a new option rather than adding `TLSv1_3` to that option? Is it just to ensure we auto-negotiate the appropriate version?","commit_id":"43396df53e881edd235247e7010998ad0efc16bb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f00ea776a4f801d78911d5775be38a940a231bb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"87e229de_679d9e54","updated":"2026-10-22 10:35:34.000000000","message":"Wait. I noticed I didn\u0027t add a conversion logic. Let me fix that.","commit_id":"43396df53e881edd235247e7010998ad0efc16bb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e170a4cc6fe61de61c0481f841d7b7c842de8546","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"95508faa_15abed0e","updated":"2026-10-22 07:21:55.000000000","message":"recheck","commit_id":"43396df53e881edd235247e7010998ad0efc16bb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"977e8e60efa88e3cc8ffa0cd315c462d9cf9dbf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ee4ebae6_fe964b27","in_reply_to":"099eeaf2_52384fcf","updated":"2026-10-22 17:07:33.000000000","message":"Okay, good to know.","commit_id":"43396df53e881edd235247e7010998ad0efc16bb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"65a86d46aae997d58e952921b7869182e2786288","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"099eeaf2_52384fcf","in_reply_to":"13eaa2d0_2f5bb1ef","updated":"2026-10-22 10:44:56.000000000","message":"To be more clear, ssl.PROTOCOL_TLSv1_3 is not available and we need to use the new min/max version interface to require TLSv1.3 . The existing ssl_version option uses the deprecated interface to require a specific one version which doesn\u0027t support TLS v1.3. I attempted to expose the underlying interface instead of adding our conversion because these two interfaces are quite different.","commit_id":"43396df53e881edd235247e7010998ad0efc16bb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c55f263768b021c9cb552d50492c6621aa447ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"59d707f2_10b18424","in_reply_to":"87e229de_679d9e54","updated":"2026-10-22 10:42:24.000000000","message":"Done.","commit_id":"43396df53e881edd235247e7010998ad0efc16bb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1c7a5335bca4962986773dab30089fc8a7d3811a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"13eaa2d0_2f5bb1ef","in_reply_to":"98c7b14b_bd037d83","updated":"2026-10-22 10:32:52.000000000","message":"TLSv1_3 is not available and usage of min/max version is the only available solution to require tls v1.3 (by setting both min and max to \u00271.3\u0027 ) from client side.\n\ncf. https://docs.python.org/ja/3/library/ssl.html#ssl.PROTOCOL_TLSv1_2","commit_id":"43396df53e881edd235247e7010998ad0efc16bb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"86251f2a087b38386cdc03635aeb2a5dcbff951a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"be1898b5_2fa2134a","updated":"2026-10-23 22:01:29.000000000","message":"recheck","commit_id":"754899288e1051cc285857715c4cb030122481b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"977e8e60efa88e3cc8ffa0cd315c462d9cf9dbf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d4d25160_3e89e07d","updated":"2026-10-22 17:07:33.000000000","message":"recheck","commit_id":"754899288e1051cc285857715c4cb030122481b2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3f94c073b3fe8a0ed82bfbc7d09167eaa5d39ff6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3cd225a5_f65e7b23","updated":"2026-10-23 14:38:01.000000000","message":"recheck CI wasn\u0027t triggered ?","commit_id":"754899288e1051cc285857715c4cb030122481b2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6716c52c3961c9deb545611575680fa7cc928a37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"afea7f0b_99ae2178","updated":"2026-10-23 19:10:06.000000000","message":"thanks lgtm","commit_id":"754899288e1051cc285857715c4cb030122481b2"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"81f5de76d2e0a9d0c86765c16644e507bbad5841","unresolved":true,"context_lines":[{"line_number":892,"context_line":""},{"line_number":893,"context_line":"        self.direct_mandatory_flag \u003d driver_conf.direct_mandatory_flag"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"        if self.ssl:"},{"line_number":896,"context_line":"            self.ssl_version \u003d driver_conf.ssl_version"},{"line_number":897,"context_line":"            self.ssl_key_file \u003d driver_conf.ssl_key_file"},{"line_number":898,"context_line":"            self.ssl_cert_file \u003d driver_conf.ssl_cert_file"}],"source_content_type":"text/x-python","patch_set":5,"id":"8ebf29f5_7430e328","side":"PARENT","line":895,"updated":"2026-10-22 10:06:55.000000000","message":"nit: Any particular reason for removing this? I know they won\u0027t be used since we have an equivalent check in `_fetch_ssl_params` but not actually setting them seemed like a sane thing to do?","commit_id":"88afc2bf19587634eddd862f45d420a4b1c1c8ae"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"977e8e60efa88e3cc8ffa0cd315c462d9cf9dbf4","unresolved":false,"context_lines":[{"line_number":892,"context_line":""},{"line_number":893,"context_line":"        self.direct_mandatory_flag \u003d driver_conf.direct_mandatory_flag"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"        if self.ssl:"},{"line_number":896,"context_line":"            self.ssl_version \u003d driver_conf.ssl_version"},{"line_number":897,"context_line":"            self.ssl_key_file \u003d driver_conf.ssl_key_file"},{"line_number":898,"context_line":"            self.ssl_cert_file \u003d driver_conf.ssl_cert_file"}],"source_content_type":"text/x-python","patch_set":5,"id":"37acda99_3e9e541a","side":"PARENT","line":895,"in_reply_to":"87bcffa1_66a96654","updated":"2026-10-22 17:07:33.000000000","message":"Okay, not a big deal. If it\u0027s intentional then wfm","commit_id":"88afc2bf19587634eddd862f45d420a4b1c1c8ae"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1c7a5335bca4962986773dab30089fc8a7d3811a","unresolved":true,"context_lines":[{"line_number":892,"context_line":""},{"line_number":893,"context_line":"        self.direct_mandatory_flag \u003d driver_conf.direct_mandatory_flag"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"        if self.ssl:"},{"line_number":896,"context_line":"            self.ssl_version \u003d driver_conf.ssl_version"},{"line_number":897,"context_line":"            self.ssl_key_file \u003d driver_conf.ssl_key_file"},{"line_number":898,"context_line":"            self.ssl_cert_file \u003d driver_conf.ssl_cert_file"}],"source_content_type":"text/x-python","patch_set":5,"id":"87bcffa1_66a96654","side":"PARENT","line":895,"in_reply_to":"8ebf29f5_7430e328","updated":"2026-10-22 10:32:52.000000000","message":"This is rather a preference but I find this it confusing to change available attributes aynamically, and am concerned by unexpected access resulting in AttributeError.\n\nAs you said we control actual usage in _fetch_ssl_params control at this layer is redundant.","commit_id":"88afc2bf19587634eddd862f45d420a4b1c1c8ae"}],"oslo_messaging/tests/drivers/test_impl_rabbit.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c16fe6536733b916dfb3f8a79cce437506c539d1","unresolved":true,"context_lines":[{"line_number":1403,"context_line":"            mock_callback,"},{"line_number":1404,"context_line":"            retry\u003d4,"},{"line_number":1405,"context_line":"        )"},{"line_number":1406,"context_line":"        # TODO(stephenfin): Remove when we drop support for kombu \u003c 5.2.4"},{"line_number":1407,"context_line":"        expected \u003d 5"},{"line_number":1408,"context_line":"        if kombu.VERSION \u003c (5, 2, 4):"},{"line_number":1409,"context_line":"            expected \u003d 6"}],"source_content_type":"text/x-python","patch_set":4,"id":"aeb18f4d_89517197","side":"PARENT","line":1406,"range":{"start_line":1406,"start_character":2,"end_line":1406,"end_character":73},"updated":"2026-10-22 01:07:22.000000000","message":"we are not bumping kombu version so we still support \u003c5.2.4 right?","commit_id":"d50893544cdd048b8341957444b9a182ef6af169"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0e3e504d795cfb488d586d6fae0bca95c4ecbbdb","unresolved":true,"context_lines":[{"line_number":1403,"context_line":"            mock_callback,"},{"line_number":1404,"context_line":"            retry\u003d4,"},{"line_number":1405,"context_line":"        )"},{"line_number":1406,"context_line":"        # TODO(stephenfin): Remove when we drop support for kombu \u003c 5.2.4"},{"line_number":1407,"context_line":"        expected \u003d 5"},{"line_number":1408,"context_line":"        if kombu.VERSION \u003c (5, 2, 4):"},{"line_number":1409,"context_line":"            expected \u003d 6"}],"source_content_type":"text/x-python","patch_set":4,"id":"ea806bf5_104bc5ca","side":"PARENT","line":1406,"range":{"start_line":1406,"start_character":2,"end_line":1406,"end_character":73},"in_reply_to":"aeb18f4d_89517197","updated":"2026-10-22 04:00:54.000000000","message":"Oh yes. This should be separate. Let me fix that.","commit_id":"d50893544cdd048b8341957444b9a182ef6af169"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7adba39a4eeed05f8ab40509804ed4fa3c7f432e","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"            mock_callback,"},{"line_number":1404,"context_line":"            retry\u003d4,"},{"line_number":1405,"context_line":"        )"},{"line_number":1406,"context_line":"        # TODO(stephenfin): Remove when we drop support for kombu \u003c 5.2.4"},{"line_number":1407,"context_line":"        expected \u003d 5"},{"line_number":1408,"context_line":"        if kombu.VERSION \u003c (5, 2, 4):"},{"line_number":1409,"context_line":"            expected \u003d 6"}],"source_content_type":"text/x-python","patch_set":4,"id":"16562793_64dbb7bf","side":"PARENT","line":1406,"range":{"start_line":1406,"start_character":2,"end_line":1406,"end_character":73},"in_reply_to":"ea806bf5_104bc5ca","updated":"2026-10-22 04:03:27.000000000","message":"Done","commit_id":"d50893544cdd048b8341957444b9a182ef6af169"}]}