)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"48b6c84014718a0b0c3b10d86d59b8631fd350f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f35916ac_0906b2bc","updated":"2026-10-07 03:27:32.000000000","message":"The logic change looks good but have one suggestion about testing.","commit_id":"fc16718ebdda394fce0f08f8125609c39f518e37"},{"author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"change_message_id":"cb42605e13a506028940598e6ec464fd7bb08d68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c4f2fb09_e2565ae3","in_reply_to":"f35916ac_0906b2bc","updated":"2026-10-09 02:49:35.000000000","message":"Thank you. Patch set 2 addresses the testing suggestion below and removes the redundant release-note sentence.","commit_id":"fc16718ebdda394fce0f08f8125609c39f518e37"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"031e74a519bbe821ea32d203db3f6cd93ad2c980","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8e437f75_bb70e58c","updated":"2026-10-10 21:09:21.000000000","message":"If we keep the default to 0 so that the default behavior is not change, I am OK with that change, but remember that, for rabbitmq, you have a much simpler and nicer solution which is to use policies.\nPolicies allows you to set an expiration on queues, and, in opposition to x-expire, it can be changed live (update the policy and the queue is going to have a new expiry).","commit_id":"a892d8aa265e7f4c77ea0b68e85c9948054487b4"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"3949238a20b3982ee4bd105359cb954d56816a61","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7d86a198_ffb04758","in_reply_to":"54b1a68d_210ae36d","updated":"2026-10-20 19:51:03.000000000","message":"That is true for operator policies, but not for regular policies. x-args have a higher priority.\nIMHO we should avoid as much as possible to set x-args parameters, because then the only way to change the value is to delete the queue, and oslo.messaging does not do that by itself.\nIn a perfect world, I would recommend getting rid of all these params and use only policies.\n\nAbout the kubernetes issue that create queues with random name, have you considered switching to stateful set instead?\nOr maybe we should consider not create the queues that are not needed at all. In your situation I believe the queues that have random name are unused anyway?","commit_id":"a892d8aa265e7f4c77ea0b68e85c9948054487b4"},{"author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"change_message_id":"8137c650cb22a2639a67bb01595fac32fb414ed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"54b1a68d_210ae36d","in_reply_to":"8e437f75_bb70e58c","updated":"2026-10-20 07:41:06.000000000","message":"Yes, the default stays 0, so nothing changes unless the option is set. Agreed that a policy is the more flexible tool where an operator writes one, since it can be changed live. The option is for deployments where nobody does: the per-server queues of pods renamed on every rollout pile up by default, and with rabbit_quorum_queue they also survive broker restarts. The two also combine: when a policy and the queue argument both set an expiry, RabbitMQ applies the lower one, so an operator\u0027s policy can still shorten it.","commit_id":"a892d8aa265e7f4c77ea0b68e85c9948054487b4"}],"oslo_messaging/tests/drivers/test_impl_rabbit.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"48b6c84014718a0b0c3b10d86d59b8631fd350f0","unresolved":true,"context_lines":[{"line_number":690,"context_line":"        ) as consumer:"},{"line_number":691,"context_line":"            transport._driver.listen(target, None, None)"},{"line_number":692,"context_line":"        return {"},{"line_number":693,"context_line":"            call.kwargs[\u0027queue_name\u0027]: rabbit_driver._get_queue_arguments("},{"line_number":694,"context_line":"                rabbit_ha_queues\u003dcall.kwargs.get(\u0027rabbit_ha_queues\u0027),"},{"line_number":695,"context_line":"                rabbit_queue_ttl\u003dcall.kwargs.get(\u0027rabbit_queue_ttl\u0027, 0),"},{"line_number":696,"context_line":"                rabbit_quorum_queue\u003dcall.kwargs.get("},{"line_number":697,"context_line":"                    \u0027rabbit_quorum_queue\u0027, False"},{"line_number":698,"context_line":"                ),"},{"line_number":699,"context_line":"                rabbit_quorum_queue_config\u003dcall.kwargs.get("},{"line_number":700,"context_line":"                    \u0027rabbit_quorum_queue_config\u0027,"},{"line_number":701,"context_line":"                    rabbit_driver.QuorumMemConfig(0, 0, 0),"},{"line_number":702,"context_line":"                ),"},{"line_number":703,"context_line":"                rabbit_stream_fanout\u003dcall.kwargs.get("},{"line_number":704,"context_line":"                    \u0027rabbit_stream_fanout\u0027, False"},{"line_number":705,"context_line":"                ),"},{"line_number":706,"context_line":"            )"},{"line_number":707,"context_line":"            for call in consumer.call_args_list"},{"line_number":708,"context_line":"        }"},{"line_number":709,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a4fa8d0e_d9ebfbb3","line":706,"range":{"start_line":693,"start_character":39,"end_line":706,"end_character":13},"updated":"2026-10-07 03:27:32.000000000","message":"This requires us to import the logic from Consumer, which is not desired. Can we assert queue_arguments directly ?","commit_id":"fc16718ebdda394fce0f08f8125609c39f518e37"},{"author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"change_message_id":"cb42605e13a506028940598e6ec464fd7bb08d68","unresolved":false,"context_lines":[{"line_number":703,"context_line":"                rabbit_stream_fanout\u003dcall.kwargs.get("},{"line_number":704,"context_line":"                    \u0027rabbit_stream_fanout\u0027, False"},{"line_number":705,"context_line":"                ),"},{"line_number":706,"context_line":"            )"},{"line_number":707,"context_line":"            for call in consumer.call_args_list"},{"line_number":708,"context_line":"        }"},{"line_number":709,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"46f50d92_f1fa5f5a","line":706,"in_reply_to":"a4fa8d0e_d9ebfbb3","updated":"2026-10-09 02:49:35.000000000","message":"Done in patch set 2: the tests inspect queue_arguments on the actual Consumer instances created by the listener. They no longer mock Consumer or call _get_queue_arguments to reconstruct the expected result. The notification test also inspects the real consumer arguments.","commit_id":"fc16718ebdda394fce0f08f8125609c39f518e37"}],"releasenotes/notes/rabbit-server-queues-ttl-53bdfcc6b47af460.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"48b6c84014718a0b0c3b10d86d59b8631fd350f0","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    differs from the one it was created with. When"},{"line_number":21,"context_line":"    ``rabbit_server_queues_ttl`` is set or changed and a server finds its"},{"line_number":22,"context_line":"    queue already declared with another TTL, or none, it now logs a warning"},{"line_number":23,"context_line":"    and uses the queue with its existing arguments instead of failing to"},{"line_number":24,"context_line":"    start. Delete the queue for it to be declared with the new TTL."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4bfd6312_a68c5af2","line":24,"range":{"start_line":23,"start_character":50,"end_line":24,"end_character":9},"updated":"2026-10-07 03:27:32.000000000","message":"(nit) I think the behavior is clear enough without this so I would remove this.","commit_id":"fc16718ebdda394fce0f08f8125609c39f518e37"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e8e308d4cd85113e8f2a141d36387b5451e3ee31","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    differs from the one it was created with. When"},{"line_number":21,"context_line":"    ``rabbit_server_queues_ttl`` is set or changed and a server finds its"},{"line_number":22,"context_line":"    queue already declared with another TTL, or none, it now logs a warning"},{"line_number":23,"context_line":"    and uses the queue with its existing arguments instead of failing to"},{"line_number":24,"context_line":"    start. Delete the queue for it to be declared with the new TTL."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"78614b7c_9bbc7369","line":24,"range":{"start_line":23,"start_character":50,"end_line":24,"end_character":9},"in_reply_to":"444169af_2d7a74ac","updated":"2026-10-09 03:33:22.000000000","message":"Sorry but I noticed I selected the wrong range. I intended to ask you to delete \"instead of failing to start\". I think the last sentence is required to make operators aware of the action needed.\nCould you fix it ?","commit_id":"fc16718ebdda394fce0f08f8125609c39f518e37"},{"author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"change_message_id":"cb42605e13a506028940598e6ec464fd7bb08d68","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    ``rabbit_server_queues_ttl`` is set or changed and a server finds its"},{"line_number":22,"context_line":"    queue already declared with another TTL, or none, it now logs a warning"},{"line_number":23,"context_line":"    and uses the queue with its existing arguments instead of failing to"},{"line_number":24,"context_line":"    start. Delete the queue for it to be declared with the new TTL."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"444169af_2d7a74ac","line":24,"in_reply_to":"4bfd6312_a68c5af2","updated":"2026-10-09 02:49:35.000000000","message":"Removed in patch set 2: the note no longer includes the final sentence telling the operator to delete the queue.","commit_id":"fc16718ebdda394fce0f08f8125609c39f518e37"},{"author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"change_message_id":"8137c650cb22a2639a67bb01595fac32fb414ed7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    ``rabbit_server_queues_ttl`` is set or changed and a server finds its"},{"line_number":22,"context_line":"    queue already declared with another TTL, or none, it now logs a warning"},{"line_number":23,"context_line":"    and uses the queue with its existing arguments instead of failing to"},{"line_number":24,"context_line":"    start."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7de914c2_367d285d","line":24,"in_reply_to":"78614b7c_9bbc7369","updated":"2026-10-20 07:41:06.000000000","message":"Done in patch set 3, sorry for the misread: \"instead of failing to start\" is gone and \"Delete the queue for it to be declared with the new TTL.\" is back.","commit_id":"a892d8aa265e7f4c77ea0b68e85c9948054487b4"}]}
